* [PATCH] power: supply: olpc_battery: force the le/be casts
@ 2019-05-11 8:56 Lubomir Rintel
0 siblings, 0 replies; only message in thread
From: Lubomir Rintel @ 2019-05-11 8:56 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-pm, linux-kernel, Lubomir Rintel, kbuild test robot
The endianness of data returned from the EC depends on the particular EC
version determined at run time. Cast from little/big endian explicitey
in the routine that flips endianness to the native one to make sparse
happy.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 76311b9a3295 ("power: supply: olpc_battery: Add OLPC XO 1.75 support")
---
drivers/power/supply/olpc_battery.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/power/supply/olpc_battery.c b/drivers/power/supply/olpc_battery.c
index 4ccd242fcf72..066ec9a11153 100644
--- a/drivers/power/supply/olpc_battery.c
+++ b/drivers/power/supply/olpc_battery.c
@@ -326,9 +326,9 @@ static int olpc_bat_get_voltage_max_design(union power_supply_propval *val)
static u16 ecword_to_cpu(struct olpc_battery_data *data, u16 ec_word)
{
if (data->little_endian)
- return le16_to_cpu(ec_word);
+ return le16_to_cpu((__force __le16)ec_word);
else
- return be16_to_cpu(ec_word);
+ return be16_to_cpu((__force __be16)ec_word);
}
/*********************************************************************
@@ -340,7 +340,7 @@ static int olpc_bat_get_property(struct power_supply *psy,
{
struct olpc_battery_data *data = power_supply_get_drvdata(psy);
int ret = 0;
- __be16 ec_word;
+ u16 ec_word;
uint8_t ec_byte;
__be64 ser_buf;
--
2.21.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-11 8:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-11 8:56 [PATCH] power: supply: olpc_battery: force the le/be casts Lubomir Rintel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).