* [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.
@ 2019-05-05 13:22 Vatsala Narang
2019-05-13 9:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Vatsala Narang @ 2019-05-05 13:22 UTC (permalink / raw)
To: gregkh
Cc: hadess, hdegoede, devel, linux-kernel, julia.lawall, Vatsala Narang
Move logical operator to previous line to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 0b5bd047a552..b5e355de1199 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
);
#endif
- if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
- && sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
- && sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
+ if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
+ sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
+ sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
) {
ret = false;
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.
2019-05-05 13:22 [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line Vatsala Narang
@ 2019-05-13 9:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-05-13 9:33 UTC (permalink / raw)
To: Vatsala Narang; +Cc: devel, julia.lawall, linux-kernel, hdegoede, hadess
On Sun, May 05, 2019 at 06:52:53PM +0530, Vatsala Narang wrote:
> Move logical operator to previous line to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 0b5bd047a552..b5e355de1199 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
> );
> #endif
>
> - if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
> - && sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
> - && sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
> + if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
> + sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
> + sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
Odd, you should align these two lines, right?
> ) {
This should go on the previous line.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-13 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 13:22 [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line Vatsala Narang
2019-05-13 9:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).