* [PATCH] of_net: Fix missing of_find_device_by_node ref count drop
@ 2019-05-13 9:41 Petr Štetiar
2019-05-13 12:55 ` Andrew Lunn
2019-05-13 15:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Petr Štetiar @ 2019-05-13 9:41 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Rob Herring,
Frank Rowand
Cc: Petr Štetiar, netdev, devicetree, linux-kernel
of_find_device_by_node takes a reference to the embedded struct device
which needs to be dropped after use.
Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
drivers/of/of_net.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c
index a4b392a5406b..6f1be80e8c4e 100644
--- a/drivers/of/of_net.c
+++ b/drivers/of/of_net.c
@@ -60,10 +60,13 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np)
return ERR_PTR(-ENODEV);
ret = nvmem_get_mac_address(&pdev->dev, &nvmem_mac);
- if (ret)
+ if (ret) {
+ put_device(&pdev->dev);
return ERR_PTR(ret);
+ }
mac = devm_kmemdup(&pdev->dev, nvmem_mac, ETH_ALEN, GFP_KERNEL);
+ put_device(&pdev->dev);
if (!mac)
return ERR_PTR(-ENOMEM);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of_net: Fix missing of_find_device_by_node ref count drop
2019-05-13 9:41 [PATCH] of_net: Fix missing of_find_device_by_node ref count drop Petr Štetiar
@ 2019-05-13 12:55 ` Andrew Lunn
2019-05-13 15:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-05-13 12:55 UTC (permalink / raw)
To: Petr Štetiar
Cc: Florian Fainelli, Heiner Kallweit, Rob Herring, Frank Rowand,
netdev, devicetree, linux-kernel
On Mon, May 13, 2019 at 11:41:39AM +0200, Petr Štetiar wrote:
> of_find_device_by_node takes a reference to the embedded struct device
> which needs to be dropped after use.
>
> Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address")
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of_net: Fix missing of_find_device_by_node ref count drop
2019-05-13 9:41 [PATCH] of_net: Fix missing of_find_device_by_node ref count drop Petr Štetiar
2019-05-13 12:55 ` Andrew Lunn
@ 2019-05-13 15:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-13 15:53 UTC (permalink / raw)
To: ynezz
Cc: andrew, f.fainelli, hkallweit1, robh+dt, frowand.list, netdev,
devicetree, linux-kernel
From: Petr Štetiar <ynezz@true.cz>
Date: Mon, 13 May 2019 11:41:39 +0200
> of_find_device_by_node takes a reference to the embedded struct device
> which needs to be dropped after use.
>
> Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address")
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-13 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 9:41 [PATCH] of_net: Fix missing of_find_device_by_node ref count drop Petr Štetiar
2019-05-13 12:55 ` Andrew Lunn
2019-05-13 15:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).