* [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
@ 2019-05-15 14:17 parna.naveenkumar
2019-05-15 15:13 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: parna.naveenkumar @ 2019-05-15 14:17 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Naveen Kumar Parna
From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
function/variable.
This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
---
drivers/char/misc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 53cfe574d8d4..f6a147427029 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -226,6 +226,7 @@ int misc_register(struct miscdevice *misc)
mutex_unlock(&misc_mtx);
return err;
}
+EXPORT_SYMBOL(misc_register);
/**
* misc_deregister - unregister a miscellaneous device
@@ -249,8 +250,6 @@ void misc_deregister(struct miscdevice *misc)
clear_bit(i, misc_minors);
mutex_unlock(&misc_mtx);
}
-
-EXPORT_SYMBOL(misc_register);
EXPORT_SYMBOL(misc_deregister);
static char *misc_devnode(struct device *dev, umode_t *mode)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
2019-05-15 14:17 [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles parna.naveenkumar
@ 2019-05-15 15:13 ` Greg KH
2019-05-16 11:06 ` Naveen Kumar Parna
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-05-15 15:13 UTC (permalink / raw)
To: parna.naveenkumar; +Cc: arnd, linux-kernel
On Wed, May 15, 2019 at 07:47:31PM +0530, parna.naveenkumar@gmail.com wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
>
> According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> function/variable.
>
> This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> ---
> drivers/char/misc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Where are patches 1/3 and 2/3 of this series?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
2019-05-15 15:13 ` Greg KH
@ 2019-05-16 11:06 ` Naveen Kumar Parna
2019-05-16 17:23 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Naveen Kumar Parna @ 2019-05-16 11:06 UTC (permalink / raw)
To: Greg KH; +Cc: arnd, linux-kernel
On Wed, 15 May 2019 at 20:43, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, May 15, 2019 at 07:47:31PM +0530, parna.naveenkumar@gmail.com wrote:
> > From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> >
> > According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> > function/variable.
> >
> > This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> >
> > Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> > ---
> > drivers/char/misc.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Where are patches 1/3 and 2/3 of this series?
It does not has corresponding 1/3 and 2/3 patches. By mistake I used
wrong argument to 'git format-patch' command.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
2019-05-16 11:06 ` Naveen Kumar Parna
@ 2019-05-16 17:23 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-05-16 17:23 UTC (permalink / raw)
To: Naveen Kumar Parna; +Cc: arnd, linux-kernel
On Thu, May 16, 2019 at 04:36:08PM +0530, Naveen Kumar Parna wrote:
> On Wed, 15 May 2019 at 20:43, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, May 15, 2019 at 07:47:31PM +0530, parna.naveenkumar@gmail.com wrote:
> > > From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> > >
> > > According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> > > function/variable.
> > >
> > > This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > >
> > > Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> > > ---
> > > drivers/char/misc.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Where are patches 1/3 and 2/3 of this series?
> It does not has corresponding 1/3 and 2/3 patches. By mistake I used
> wrong argument to 'git format-patch' command.
Ok, now dropped, please fix up and resend properly.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-16 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 14:17 [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles parna.naveenkumar
2019-05-15 15:13 ` Greg KH
2019-05-16 11:06 ` Naveen Kumar Parna
2019-05-16 17:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).