* [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC
@ 2019-05-15 15:31 Matthias Kaehlcke
2019-05-15 15:31 ` [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
2019-05-15 18:30 ` [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Doug Anderson
0 siblings, 2 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-05-15 15:31 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
This value matches what is used by the downstream Chrome OS 3.14
kernel, the 'official' kernel for veyron devices.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 1252522392c7..169da06e1c09 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -446,6 +446,14 @@
status = "okay";
};
+&gpu_thermal {
+ trips {
+ gpu_alert0: gpu_alert0 {
+ temperature = <72500>; /* millicelsius */
+ };
+ };
+};
+
&pinctrl {
pinctrl-names = "default", "sleep";
pinctrl-0 = <
--
2.21.0.1020.gf2820cf01a-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC
2019-05-15 15:31 [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Matthias Kaehlcke
@ 2019-05-15 15:31 ` Matthias Kaehlcke
2019-05-15 18:30 ` Doug Anderson
2019-05-15 18:30 ` [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Doug Anderson
1 sibling, 1 reply; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-05-15 15:31 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
Raise the temperature of the GPU thermal trip point for speedy
to 80°C. This is the value used by the downstream Chrome OS 3.14
kernel, the 'official' kernel for speedy.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index 2ac8748a3a0c..394a9648faee 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -64,6 +64,10 @@
temperature = <70000>;
};
+&gpu_alert0 {
+ temperature = <80000>;
+};
+
&edp {
/delete-property/pinctrl-names;
/delete-property/pinctrl-0;
--
2.21.0.1020.gf2820cf01a-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC
2019-05-15 15:31 ` [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
@ 2019-05-15 18:30 ` Doug Anderson
2019-05-15 21:47 ` Matthias Kaehlcke
0 siblings, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 18:30 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
Hi,
On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> Raise the temperature of the GPU thermal trip point for speedy
> to 80°C. This is the value used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for speedy.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> index 2ac8748a3a0c..394a9648faee 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> @@ -64,6 +64,10 @@
> temperature = <70000>;
> };
>
> +&gpu_alert0 {
> + temperature = <80000>;
> +};
> +
> &edp {
Similar comments to patch set #1 about sort ordering.
...I'll also notice that if we do end up setting the "critical" to 100
C for most of veyron then I guess we'll have to switch it back to 90 C
here for speedy to match downstream? Maybe that's an argument for
doing it in this patchset so we don't forget? I'm somewhat amazed
that downstream has only 10 C between "alert" and 'critical" for GPU
for speedy, but I guess it's OK?
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC
2019-05-15 18:30 ` Doug Anderson
@ 2019-05-15 21:47 ` Matthias Kaehlcke
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-05-15 21:47 UTC (permalink / raw)
To: Doug Anderson
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
On Wed, May 15, 2019 at 11:30:12AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > Raise the temperature of the GPU thermal trip point for speedy
> > to 80°C. This is the value used by the downstream Chrome OS 3.14
> > kernel, the 'official' kernel for speedy.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> > index 2ac8748a3a0c..394a9648faee 100644
> > --- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> > +++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> > @@ -64,6 +64,10 @@
> > temperature = <70000>;
> > };
> >
> > +&gpu_alert0 {
> > + temperature = <80000>;
> > +};
> > +
> > &edp {
>
> Similar comments to patch set #1 about sort ordering.
ack
> ...I'll also notice that if we do end up setting the "critical" to 100
> C for most of veyron then I guess we'll have to switch it back to 90 C
> here for speedy to match downstream?
yes
> Maybe that's an argument for doing it in this patchset so we don't
> forget?
sounds good to me
> I'm somewhat amazed that downstream has only 10 C between "alert"
> and 'critical" for GPU for speedy, but I guess it's OK?
In tests on other veyron devices I observed gradual temperature
in response to CPU or GPU load, so unless there's a sudden spike in
the ambient temperature I think the 10°C delta should be fine with the
current polling interval of 100ms.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC
2019-05-15 15:31 [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Matthias Kaehlcke
2019-05-15 15:31 ` [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
@ 2019-05-15 18:30 ` Doug Anderson
2019-05-15 21:37 ` Matthias Kaehlcke
1 sibling, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 18:30 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
Hi,
On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> This value matches what is used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for veyron devices.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 1252522392c7..169da06e1c09 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -446,6 +446,14 @@
> status = "okay";
> };
>
> +&gpu_thermal {
> + trips {
> + gpu_alert0: gpu_alert0 {
> + temperature = <72500>; /* millicelsius */
> + };
> + };
> +};
> +
This should be sorted alphabetically. Thus this should sort right
after this in rk3288-veyron.dtsi
&gpu {
mali-supply = <&vdd_gpu>;
status = "okay";
};
Also you don't need to replicate the whole structure? I think the
above should just be:
&gpu_alert0 {
temperature = <72500>; /* millicelsius */
};
NOTE also that that gpu and cpu critical is 100 C downstream. Should
we do that too? Ah, but before we do that I guess we'd need to also
override the "rockchip,hw-tshut-temp" to 125000 to match downstream.
I guess that could be a separate series?
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC
2019-05-15 18:30 ` [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Doug Anderson
@ 2019-05-15 21:37 ` Matthias Kaehlcke
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-05-15 21:37 UTC (permalink / raw)
To: Doug Anderson
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
Hi Doug,
thanks for the review!
On Wed, May 15, 2019 at 11:30:24AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > This value matches what is used by the downstream Chrome OS 3.14
> > kernel, the 'official' kernel for veyron devices.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> > index 1252522392c7..169da06e1c09 100644
> > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> > @@ -446,6 +446,14 @@
> > status = "okay";
> > };
> >
> > +&gpu_thermal {
> > + trips {
> > + gpu_alert0: gpu_alert0 {
> > + temperature = <72500>; /* millicelsius */
> > + };
> > + };
> > +};
> > +
>
> This should be sorted alphabetically. Thus this should sort right
> after this in rk3288-veyron.dtsi
>
> &gpu {
> mali-supply = <&vdd_gpu>;
> status = "okay";
> };
will do in the next revision.
> Also you don't need to replicate the whole structure? I think the
> above should just be:
>
> &gpu_alert0 {
> temperature = <72500>; /* millicelsius */
> };
ack
> NOTE also that that gpu and cpu critical is 100 C downstream. Should
> we do that too?
I missed this delta, yes let's do this too in this series.
> Ah, but before we do that I guess we'd need to also override the
> "rockchip,hw-tshut-temp" to 125000 to match downstream. I guess that
> could be a separate series?
Yes, the value should at least be higher than the critical trip point,
matching downstream seems to make sense.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-15 21:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 15:31 [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Matthias Kaehlcke
2019-05-15 15:31 ` [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
2019-05-15 18:30 ` Doug Anderson
2019-05-15 21:47 ` Matthias Kaehlcke
2019-05-15 18:30 ` [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Doug Anderson
2019-05-15 21:37 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).