* [PATCH] Fix comments with paths pointing to renamed or moved files.
@ 2019-05-21 15:54 Lukas Prause
2019-05-22 18:36 ` Pavel Machek
2019-05-23 18:35 ` Steven Rostedt
0 siblings, 2 replies; 4+ messages in thread
From: Lukas Prause @ 2019-05-21 15:54 UTC (permalink / raw)
To: lizefan, tj, hannes, peterz, mingo, will.deacon, rjw, len.brown,
pavel, rostedt
Cc: linux-doc, linux-kernel, cgroups, linux-pm, Lukas Prause, Lennart Glauer
This patch corrects renamed or moved paths in comments.
Signed-off-by: Lukas Prause <langspielplatte@black-mesa.xyz>
Signed-off-by: Lennart Glauer <mail@lennart-glauer.de>
---
kernel/cgroup/cpuset.c | 2 +-
kernel/locking/mutex-debug.h | 2 +-
kernel/power/power.h | 2 +-
kernel/sched/core.c | 2 +-
kernel/trace/trace.h | 14 +++++++-------
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 6a1942ed781c..6381622e2f2f 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -329,7 +329,7 @@ static struct cpuset top_cpuset = {
* cpumasks and nodemasks.
*
* Accessing a task's cpuset should be done in accordance with the
- * guidelines for accessing subsystem state in kernel/cgroup.c
+ * guidelines for accessing subsystem state in kernel/cgroup/cgroup.c
*/
static DEFINE_MUTEX(cpuset_mutex);
diff --git a/kernel/locking/mutex-debug.h b/kernel/locking/mutex-debug.h
index 1edd3f45a4ec..0dee0a07cd4c 100644
--- a/kernel/locking/mutex-debug.h
+++ b/kernel/locking/mutex-debug.h
@@ -8,7 +8,7 @@
*
* This file contains mutex debugging related internal declarations,
* prototypes and inline functions, for the CONFIG_DEBUG_MUTEXES case.
- * More details are in kernel/mutex-debug.c.
+ * More details are in kernel/locking/mutex-debug.c.
*/
/*
diff --git a/kernel/power/power.h b/kernel/power/power.h
index 9e58bdc8a562..5de8b0c7f657 100644
--- a/kernel/power/power.h
+++ b/kernel/power/power.h
@@ -182,7 +182,7 @@ extern int swsusp_unmark(void);
#endif
struct timeval;
-/* kernel/power/swsusp.c */
+/* kernel/power/hibernate.c */
extern void swsusp_show_speed(ktime_t, ktime_t, unsigned int, char *);
#ifdef CONFIG_SUSPEND
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 102dfcf0a29a..0ce0dc44ffc3 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3334,7 +3334,7 @@ pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
* 1. Explicit blocking: mutex, semaphore, waitqueue, etc.
*
* 2. TIF_NEED_RESCHED flag is checked on interrupt and userspace return
- * paths. For example, see arch/x86/entry_64.S.
+ * paths. For example, see arch/x86/entry/entry_64.S.
*
* To drive preemption between tasks, the scheduler sets the flag in timer
* interrupt handler scheduler_tick().
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 1974ce818ddb..0c304d6f5b31 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -1684,7 +1684,7 @@ extern int register_trigger_hist_enable_disable_cmds(void);
* initialization such as incrementing a per-trigger reference
* count, for instance. This is usually implemented by the
* generic utility function @event_trigger_init() (see
- * trace_event_triggers.c).
+ * trace_events_trigger.c).
*
* @free: An optional de-initialization function called for the
* trigger when the trigger is unregistered (via the
@@ -1693,12 +1693,12 @@ extern int register_trigger_hist_enable_disable_cmds(void);
* per-trigger reference count and freeing corresponding trigger
* data, for instance. This is usually implemented by the
* generic utility function @event_trigger_free() (see
- * trace_event_triggers.c).
+ * trace_events_trigger.c).
*
* @print: The callback function invoked to have the trigger print
* itself. This is usually implemented by a wrapper function
* that calls the generic utility function @event_trigger_print()
- * (see trace_event_triggers.c).
+ * (see trace_events_trigger.c).
*/
struct event_trigger_ops {
void (*func)(struct event_trigger_data *data,
@@ -1758,7 +1758,7 @@ struct event_trigger_ops {
* the appropriate trace event. It makes use of the other
* event_command callback functions to orchestrate this, and is
* usually implemented by the generic utility function
- * @event_trigger_callback() (see trace_event_triggers.c).
+ * @event_trigger_callback() (see trace_events_trigger.c).
*
* @reg: Adds the trigger to the list of triggers associated with the
* event, and enables the event trigger itself, after
@@ -1767,13 +1767,13 @@ struct event_trigger_ops {
* make the decision as to whether or not multiple instances of
* the trigger should be allowed. This is usually implemented by
* the generic utility function @register_trigger() (see
- * trace_event_triggers.c).
+ * trace_events_trigger.c).
*
* @unreg: Removes the trigger from the list of triggers associated
* with the event, and disables the event trigger itself, after
* initializing it (via the event_trigger_ops @free() function).
* This is usually implemented by the generic utility function
- * @unregister_trigger() (see trace_event_triggers.c).
+ * @unregister_trigger() (see trace_events_trigger.c).
*
* @unreg_all: An optional function called to remove all the triggers
* from the list of triggers associated with the event. Called
@@ -1783,7 +1783,7 @@ struct event_trigger_ops {
* for the trigger. If no @set_filter() method is set for the
* event command, filters set by the user for the command will be
* ignored. This is usually implemented by the generic utility
- * function @set_trigger_filter() (see trace_event_triggers.c).
+ * function @set_trigger_filter() (see trace_events_trigger.c).
*
* @get_trigger_ops: The callback function invoked to retrieve the
* event_trigger_ops implementation associated with the command.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix comments with paths pointing to renamed or moved files.
2019-05-21 15:54 [PATCH] Fix comments with paths pointing to renamed or moved files Lukas Prause
@ 2019-05-22 18:36 ` Pavel Machek
2019-05-22 18:54 ` Joe Perches
2019-05-23 18:35 ` Steven Rostedt
1 sibling, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2019-05-22 18:36 UTC (permalink / raw)
To: Lukas Prause
Cc: lizefan, tj, hannes, peterz, mingo, will.deacon, rjw, len.brown,
rostedt, linux-doc, linux-kernel, cgroups, linux-pm,
Lennart Glauer
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Tue 2019-05-21 17:54:30, Lukas Prause wrote:
> This patch corrects renamed or moved paths in comments.
>
> Signed-off-by: Lukas Prause <langspielplatte@black-mesa.xyz>
> Signed-off-by: Lennart Glauer <mail@lennart-glauer.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
> diff --git a/kernel/power/power.h b/kernel/power/power.h
> index 9e58bdc8a562..5de8b0c7f657 100644
> --- a/kernel/power/power.h
> +++ b/kernel/power/power.h
> @@ -182,7 +182,7 @@ extern int swsusp_unmark(void);
> #endif
>
> struct timeval;
> -/* kernel/power/swsusp.c */
> +/* kernel/power/hibernate.c */
> extern void swsusp_show_speed(ktime_t, ktime_t, unsigned int, char *);
>
> #ifdef CONFIG_SUSPEND
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix comments with paths pointing to renamed or moved files.
2019-05-22 18:36 ` Pavel Machek
@ 2019-05-22 18:54 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2019-05-22 18:54 UTC (permalink / raw)
To: Pavel Machek, Lukas Prause
Cc: lizefan, tj, hannes, peterz, mingo, will.deacon, rjw, len.brown,
rostedt, linux-doc, linux-kernel, cgroups, linux-pm,
Lennart Glauer
On Wed, 2019-05-22 at 20:36 +0200, Pavel Machek wrote:
> On Tue 2019-05-21 17:54:30, Lukas Prause wrote:
> > This patch corrects renamed or moved paths in comments.
> >
> > Signed-off-by: Lukas Prause <langspielplatte@black-mesa.xyz>
> > Signed-off-by: Lennart Glauer <mail@lennart-glauer.de>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> > diff --git a/kernel/power/power.h b/kernel/power/power.h
> > index 9e58bdc8a562..5de8b0c7f657 100644
> > --- a/kernel/power/power.h
> > +++ b/kernel/power/power.h
> > @@ -182,7 +182,7 @@ extern int swsusp_unmark(void);
> > #endif
> >
> > struct timeval;
> > -/* kernel/power/swsusp.c */
> > +/* kernel/power/hibernate.c */
> > extern void swsusp_show_speed(ktime_t, ktime_t, unsigned int, char *);
> >
> > #ifdef CONFIG_SUSPEND
I think all of these markings should be removed instead.
Why are these useful?
It seems many of these filenames in power.h aren't correct anyway.
For instance power.h has:
/* kernel/power/hibernate.c */
extern int swsusp_check(void);
extern void swsusp_free(void);
extern int swsusp_read(unsigned int *flags_p);
extern int swsusp_write(unsigned int flags);
extern void swsusp_close(fmode_t);
#ifdef CONFIG_SUSPEND
extern int swsusp_unmark(void);
#endif
but:
swsusp_check is in swap.c
swsusp_free is in snapshot.c
swsusp_read is in swap.c
etc...
Perhaps:
---
kernel/power/power.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/kernel/power/power.h b/kernel/power/power.h
index 9e58bdc8a562..52bcb72564e5 100644
--- a/kernel/power/power.h
+++ b/kernel/power/power.h
@@ -16,7 +16,6 @@ struct swsusp_info {
} __aligned(PAGE_SIZE);
#ifdef CONFIG_HIBERNATION
-/* kernel/power/snapshot.c */
extern void __init hibernate_reserved_size_init(void);
extern void __init hibernate_image_size_init(void);
@@ -55,7 +54,6 @@ extern int hibernate_resume_nonboot_cpu_disable(void);
asmlinkage int swsusp_save(void);
-/* kernel/power/hibernate.c */
extern bool freezer_test_done;
extern int hibernation_snapshot(int platform_mode);
@@ -63,7 +61,6 @@ extern int hibernation_restore(int platform_mode);
extern int hibernation_platform_enter(void);
#ifdef CONFIG_STRICT_KERNEL_RWX
-/* kernel/power/snapshot.c */
extern void enable_restore_image_protection(void);
#else
static inline void enable_restore_image_protection(void) {}
@@ -171,7 +168,6 @@ extern int swsusp_swap_in_use(void);
#define SF_NOCOMPRESS_MODE 2
#define SF_CRC32_MODE 4
-/* kernel/power/hibernate.c */
extern int swsusp_check(void);
extern void swsusp_free(void);
extern int swsusp_read(unsigned int *flags_p);
@@ -182,11 +178,9 @@ extern int swsusp_unmark(void);
#endif
struct timeval;
-/* kernel/power/swsusp.c */
extern void swsusp_show_speed(ktime_t, ktime_t, unsigned int, char *);
#ifdef CONFIG_SUSPEND
-/* kernel/power/suspend.c */
extern const char * const pm_labels[];
extern const char *pm_states[];
extern const char *mem_sleep_states[];
@@ -202,7 +196,6 @@ static inline int suspend_devices_and_enter(suspend_state_t state)
#endif /* !CONFIG_SUSPEND */
#ifdef CONFIG_PM_TEST_SUSPEND
-/* kernel/power/suspend_test.c */
extern void suspend_test_start(void);
extern void suspend_test_finish(const char *label);
#else /* !CONFIG_PM_TEST_SUSPEND */
@@ -211,7 +204,6 @@ static inline void suspend_test_finish(const char *label) {}
#endif /* !CONFIG_PM_TEST_SUSPEND */
#ifdef CONFIG_PM_SLEEP
-/* kernel/power/main.c */
extern int __pm_notifier_call_chain(unsigned long val, int nr_to_call,
int *nr_calls);
extern int pm_notifier_call_chain(unsigned long val);
@@ -289,7 +281,6 @@ static inline void suspend_thaw_processes(void)
#ifdef CONFIG_PM_AUTOSLEEP
-/* kernel/power/autosleep.c */
extern int pm_autosleep_init(void);
extern int pm_autosleep_lock(void);
extern void pm_autosleep_unlock(void);
@@ -307,7 +298,6 @@ static inline suspend_state_t pm_autosleep_state(void) { return PM_SUSPEND_ON; }
#ifdef CONFIG_PM_WAKELOCKS
-/* kernel/power/wakelock.c */
extern ssize_t pm_show_wakelocks(char *buf, bool show_active);
extern int pm_wake_lock(const char *buf);
extern int pm_wake_unlock(const char *buf);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix comments with paths pointing to renamed or moved files.
2019-05-21 15:54 [PATCH] Fix comments with paths pointing to renamed or moved files Lukas Prause
2019-05-22 18:36 ` Pavel Machek
@ 2019-05-23 18:35 ` Steven Rostedt
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2019-05-23 18:35 UTC (permalink / raw)
To: Lukas Prause
Cc: lizefan, tj, hannes, peterz, mingo, will.deacon, rjw, len.brown,
pavel, linux-doc, linux-kernel, cgroups, linux-pm,
Lennart Glauer
On Tue, 21 May 2019 17:54:30 +0200
Lukas Prause <langspielplatte@black-mesa.xyz> wrote:
> This patch corrects renamed or moved paths in comments.
>
> Signed-off-by: Lukas Prause <langspielplatte@black-mesa.xyz>
> Signed-off-by: Lennart Glauer <mail@lennart-glauer.de>
> ---
> kernel/cgroup/cpuset.c | 2 +-
> kernel/locking/mutex-debug.h | 2 +-
> kernel/power/power.h | 2 +-
> kernel/sched/core.c | 2 +-
> kernel/trace/trace.h | 14 +++++++-------
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> 5 files changed, 11 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-23 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 15:54 [PATCH] Fix comments with paths pointing to renamed or moved files Lukas Prause
2019-05-22 18:36 ` Pavel Machek
2019-05-22 18:54 ` Joe Perches
2019-05-23 18:35 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).