* [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)
@ 2019-05-25 17:59 ` Hariprasad Kelam
2019-06-13 13:09 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-05-25 17:59 UTC (permalink / raw)
To: Andrzej Hajda, Laurent Pinchart, David Airlie, Daniel Vetter,
Maarten Lankhorst, Sam Ravnborg, Gwan-gyeong Mun,
Enric Balletbo i Serra, Hariprasad Kelam, Marc Zyngier,
dri-devel, linux-kernel
fix below warning reported by coccicheck
./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
possible condition with no effect (if == else)
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 257d69b..cfcd159 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
video->color_space = COLOR_YCBCR444;
else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
video->color_space = COLOR_YCBCR422;
- else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
- video->color_space = COLOR_RGB;
else
video->color_space = COLOR_RGB;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)
2019-05-25 17:59 ` [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else) Hariprasad Kelam
@ 2019-06-13 13:09 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2019-06-13 13:09 UTC (permalink / raw)
To: Hariprasad Kelam, Laurent Pinchart, David Airlie, Daniel Vetter,
Maarten Lankhorst, Sam Ravnborg, Gwan-gyeong Mun,
Enric Balletbo i Serra, Marc Zyngier, dri-devel, linux-kernel
On 25.05.2019 19:59, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> ./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Mixed feelings about it, but:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
I will queue it to drm-misc-next.
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 257d69b..cfcd159 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
> video->color_space = COLOR_YCBCR444;
> else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
> video->color_space = COLOR_YCBCR422;
> - else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
> - video->color_space = COLOR_RGB;
> else
> video->color_space = COLOR_RGB;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-13 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190525175948epcas2p31156b3ec2ee712634558e04faa42b342@epcas2p3.samsung.com>
2019-05-25 17:59 ` [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else) Hariprasad Kelam
2019-06-13 13:09 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).