* [PATCH] Input: qt1050 - remove unnecessary comparison of unsigned integer with < 0
@ 2019-05-27 14:10 Gustavo A. R. Silva
0 siblings, 0 replies; only message in thread
From: Gustavo A. R. Silva @ 2019-05-27 14:10 UTC (permalink / raw)
To: Dmitry Torokhov, Marco Felsch
Cc: linux-input, linux-kernel, Gustavo A. R. Silva
There is no need to compare button.num with < 0 because such comparison
of an unsigned value is always false.
Fix this by removing such comparison.
Addresses-Coverity-ID: 1445492 ("Unsigned compared against 0")
Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/input/keyboard/qt1050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index 403060d05c3b..a9ac99f62e39 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -368,7 +368,7 @@ static int qt1050_parse_fw(struct qt1050_priv *ts)
dev_err(dev, "Button without pad number\n");
goto err;
}
- if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1)
+ if (button.num > QT1050_MAX_KEYS - 1)
goto err;
ts->reg_keys |= BIT(button.num);
--
2.21.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-27 14:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 14:10 [PATCH] Input: qt1050 - remove unnecessary comparison of unsigned integer with < 0 Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).