linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build warning after merge of the userns tree
@ 2019-05-30  5:33 Stephen Rothwell
  2019-05-30 11:34 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-05-30  5:33 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi Eric,

After merging the userns tree, today's linux-next build (i386 defconfig)
produced this warning:

arch/x86/mm/fault.c: In function 'do_sigbus':
arch/x86/mm/fault.c:1017:22: warning: unused variable 'tsk' [-Wunused-variable]
  struct task_struct *tsk = current;
                      ^~~

Introduced by commit

  351b6825b3a9 ("signal: Explicitly call force_sig_fault on current")

The remaining used of "tsk" are protected by CONFIG_MEMORY_FAILURE.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: build warning after merge of the userns tree
  2019-05-30  5:33 linux-next: build warning after merge of the userns tree Stephen Rothwell
@ 2019-05-30 11:34 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2019-05-30 11:34 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> After merging the userns tree, today's linux-next build (i386 defconfig)
> produced this warning:
>
> arch/x86/mm/fault.c: In function 'do_sigbus':
> arch/x86/mm/fault.c:1017:22: warning: unused variable 'tsk' [-Wunused-variable]
>   struct task_struct *tsk = current;
>                       ^~~
>
> Introduced by commit
>
>   351b6825b3a9 ("signal: Explicitly call force_sig_fault on current")
>
> The remaining used of "tsk" are protected by CONFIG_MEMORY_FAILURE.

Yes.  Thank you.  I will add a commit to move tsk inside
CONFIG_MEMORY_FAILURE.

Eric


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-30 11:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30  5:33 linux-next: build warning after merge of the userns tree Stephen Rothwell
2019-05-30 11:34 ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).