* [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config
@ 2019-05-31 22:37 Maciej S. Szmigiero
2019-06-03 12:14 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Maciej S. Szmigiero @ 2019-05-31 22:37 UTC (permalink / raw)
To: Michael Krufky, Mauro Carvalho Chehab
Cc: linux-kernel, linux-media, Hans Verkuil, kbuild test robot
Use ARRAY_SIZE for computing element count of cxusub_medion_pin_config
array as suggested by the kbuild test robot.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
drivers/media/usb/dvb-usb/cxusb-analog.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c
index 9b42ca71c177..51d3cba32b60 100644
--- a/drivers/media/usb/dvb-usb/cxusb-analog.c
+++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
@@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
/* TODO: setup audio samples insertion */
ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
- sizeof(cxusub_medion_pin_config) /
- sizeof(cxusub_medion_pin_config[0]),
+ ARRAY_SIZE(cxusub_medion_pin_config),
cxusub_medion_pin_config);
if (ret != 0)
dev_warn(&dvbdev->udev->dev,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config
2019-05-31 22:37 [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config Maciej S. Szmigiero
@ 2019-06-03 12:14 ` Hans Verkuil
2019-06-03 13:40 ` Maciej S. Szmigiero
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2019-06-03 12:14 UTC (permalink / raw)
To: Maciej S. Szmigiero, Michael Krufky, Mauro Carvalho Chehab
Cc: linux-kernel, linux-media, kbuild test robot
Hi Maciej,
Thank you for the patch, but I posted a fix for this earlier already:
https://patchwork.linuxtv.org/patch/56441/
I'll drop this patch in favor of the one above. Apologies for not
CC-ing you on my patch, I should have done that.
Regards,
Hans
On 6/1/19 12:37 AM, Maciej S. Szmigiero wrote:
> Use ARRAY_SIZE for computing element count of cxusub_medion_pin_config
> array as suggested by the kbuild test robot.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> drivers/media/usb/dvb-usb/cxusb-analog.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c
> index 9b42ca71c177..51d3cba32b60 100644
> --- a/drivers/media/usb/dvb-usb/cxusb-analog.c
> +++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
> @@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
> /* TODO: setup audio samples insertion */
>
> ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
> - sizeof(cxusub_medion_pin_config) /
> - sizeof(cxusub_medion_pin_config[0]),
> + ARRAY_SIZE(cxusub_medion_pin_config),
> cxusub_medion_pin_config);
> if (ret != 0)
> dev_warn(&dvbdev->udev->dev,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config
2019-06-03 12:14 ` Hans Verkuil
@ 2019-06-03 13:40 ` Maciej S. Szmigiero
0 siblings, 0 replies; 3+ messages in thread
From: Maciej S. Szmigiero @ 2019-06-03 13:40 UTC (permalink / raw)
To: Hans Verkuil
Cc: Michael Krufky, Mauro Carvalho Chehab, linux-kernel, linux-media,
kbuild test robot
Hi Hans,
On 03.06.2019 14:14, Hans Verkuil wrote:
> Hi Maciej,
>
> Thank you for the patch, but I posted a fix for this earlier already:
>
> https://patchwork.linuxtv.org/patch/56441/
>
> I'll drop this patch in favor of the one above. Apologies for not
> CC-ing you on my patch, I should have done that.
All right, thanks for the information.
> Regards,
>
> Hans
Regards,
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 22:37 [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config Maciej S. Szmigiero
2019-06-03 12:14 ` Hans Verkuil
2019-06-03 13:40 ` Maciej S. Szmigiero
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).