* [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node
2019-06-03 9:47 [PATCH 0/4] arm64: dts: meson-g12a: bluetooth fixups Neil Armstrong
@ 2019-06-03 9:47 ` Neil Armstrong
2019-06-05 7:35 ` Neil Armstrong
2019-06-06 19:46 ` Martin Blumenstingl
2019-06-03 9:47 ` [PATCH 2/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
` (2 subsequent siblings)
3 siblings, 2 replies; 11+ messages in thread
From: Neil Armstrong @ 2019-06-03 9:47 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
The 32k low power clock is necessary for the bluetooth part of the
combo module to initialize correctly, simply add the same clock we
use for the sdio pwrseq.
Fixes: d1c023af1988 ("arm64: dts: meson-g12a-sei510: Add ADC Key and BT support")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
index eac57d997e0b..3e0e119c13ce 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
@@ -530,6 +530,8 @@
bluetooth {
compatible = "brcm,bcm43438-bt";
shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+ clocks = <&wifi32k>;
+ clock-names = "lpo";
vbat-supply = <&vddao_3v3>;
vddio-supply = <&vddio_ao1v8>;
};
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node
2019-06-03 9:47 ` [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node Neil Armstrong
@ 2019-06-05 7:35 ` Neil Armstrong
2019-06-06 19:46 ` Martin Blumenstingl
1 sibling, 0 replies; 11+ messages in thread
From: Neil Armstrong @ 2019-06-05 7:35 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel
On 03/06/2019 11:47, Neil Armstrong wrote:
> The 32k low power clock is necessary for the bluetooth part of the
> combo module to initialize correctly, simply add the same clock we
> use for the sdio pwrseq.
>
> Fixes: d1c023af1988 ("arm64: dts: meson-g12a-sei510: Add ADC Key and BT support")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index eac57d997e0b..3e0e119c13ce 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -530,6 +530,8 @@
> bluetooth {
> compatible = "brcm,bcm43438-bt";
> shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> + clocks = <&wifi32k>;
> + clock-names = "lpo";
> vbat-supply = <&vddao_3v3>;
> vddio-supply = <&vddio_ao1v8>;
> };
>
The Fixes is wrong... wifi32k was not present at this time.
Neil
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node
2019-06-03 9:47 ` [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node Neil Armstrong
2019-06-05 7:35 ` Neil Armstrong
@ 2019-06-06 19:46 ` Martin Blumenstingl
1 sibling, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2019-06-06 19:46 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
On Mon, Jun 3, 2019 at 11:48 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The 32k low power clock is necessary for the bluetooth part of the
> combo module to initialize correctly, simply add the same clock we
> use for the sdio pwrseq.
>
> Fixes: d1c023af1988 ("arm64: dts: meson-g12a-sei510: Add ADC Key and BT support")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
with the correct fixes tag:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/4] arm64: dts: meson-g12a-x96-max: add 32k clock to bluetooth node
2019-06-03 9:47 [PATCH 0/4] arm64: dts: meson-g12a: bluetooth fixups Neil Armstrong
2019-06-03 9:47 ` [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node Neil Armstrong
@ 2019-06-03 9:47 ` Neil Armstrong
2019-06-05 7:36 ` Neil Armstrong
2019-06-06 19:47 ` Martin Blumenstingl
2019-06-03 9:47 ` [PATCH 3/4] arm64: dts: meson-g12a-sei510: bump bluetooth bus speed to 2Mbaud/s Neil Armstrong
2019-06-03 9:47 ` [PATCH 4/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
3 siblings, 2 replies; 11+ messages in thread
From: Neil Armstrong @ 2019-06-03 9:47 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
The 32k low power clock is necessary for the bluetooth part of the
combo module to initialize correctly, simply add the same clock we
use for the sdio pwrseq.
Fixes: c5c9c7cff269 ("arm64: dts: meson-g12a-x96-max: Enable BT Module")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index 2c10ebfd9e7c..aa9da5de5c2d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -206,6 +206,8 @@
bluetooth {
compatible = "brcm,bcm43438-bt";
shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+ clocks = <&wifi32k>;
+ clock-names = "lpo";
};
};
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] arm64: dts: meson-g12a-x96-max: add 32k clock to bluetooth node
2019-06-03 9:47 ` [PATCH 2/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
@ 2019-06-05 7:36 ` Neil Armstrong
2019-06-06 19:47 ` Martin Blumenstingl
1 sibling, 0 replies; 11+ messages in thread
From: Neil Armstrong @ 2019-06-05 7:36 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel
On 03/06/2019 11:47, Neil Armstrong wrote:
> The 32k low power clock is necessary for the bluetooth part of the
> combo module to initialize correctly, simply add the same clock we
> use for the sdio pwrseq.
>
> Fixes: c5c9c7cff269 ("arm64: dts: meson-g12a-x96-max: Enable BT Module")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index 2c10ebfd9e7c..aa9da5de5c2d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -206,6 +206,8 @@
> bluetooth {
> compatible = "brcm,bcm43438-bt";
> shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> + clocks = <&wifi32k>;
> + clock-names = "lpo";
> };
> };
>
>
The Fixes is wrong... wifi32k was not present at this time.
Neil
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] arm64: dts: meson-g12a-x96-max: add 32k clock to bluetooth node
2019-06-03 9:47 ` [PATCH 2/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-06-05 7:36 ` Neil Armstrong
@ 2019-06-06 19:47 ` Martin Blumenstingl
1 sibling, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2019-06-06 19:47 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
On Mon, Jun 3, 2019 at 11:48 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The 32k low power clock is necessary for the bluetooth part of the
> combo module to initialize correctly, simply add the same clock we
> use for the sdio pwrseq.
>
> Fixes: c5c9c7cff269 ("arm64: dts: meson-g12a-x96-max: Enable BT Module")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
with the correct fixes tag:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/4] arm64: dts: meson-g12a-sei510: bump bluetooth bus speed to 2Mbaud/s
2019-06-03 9:47 [PATCH 0/4] arm64: dts: meson-g12a: bluetooth fixups Neil Armstrong
2019-06-03 9:47 ` [PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node Neil Armstrong
2019-06-03 9:47 ` [PATCH 2/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
@ 2019-06-03 9:47 ` Neil Armstrong
2019-06-06 19:54 ` Martin Blumenstingl
2019-06-03 9:47 ` [PATCH 4/4] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
3 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2019-06-03 9:47 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Setting to 2Mbaud/s is the nominal bus speed for common usages.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
index 3e0e119c13ce..4fc30131e5e7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
@@ -530,6 +530,7 @@
bluetooth {
compatible = "brcm,bcm43438-bt";
shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+ max-speed = <2000000>;
clocks = <&wifi32k>;
clock-names = "lpo";
vbat-supply = <&vddao_3v3>;
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/4] arm64: dts: meson-g12a-x96-max: bump bluetooth bus speed to 2Mbaud/s
2019-06-03 9:47 [PATCH 0/4] arm64: dts: meson-g12a: bluetooth fixups Neil Armstrong
` (2 preceding siblings ...)
2019-06-03 9:47 ` [PATCH 3/4] arm64: dts: meson-g12a-sei510: bump bluetooth bus speed to 2Mbaud/s Neil Armstrong
@ 2019-06-03 9:47 ` Neil Armstrong
2019-06-06 19:54 ` Martin Blumenstingl
3 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2019-06-03 9:47 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Setting to 2Mbaud/s is the nominal bus speed for common usages.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index aa9da5de5c2d..300c29dad49f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -206,6 +206,7 @@
bluetooth {
compatible = "brcm,bcm43438-bt";
shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+ max-speed = <2000000>;
clocks = <&wifi32k>;
clock-names = "lpo";
};
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread