From: Oscar Salvador <osalvador@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, "David Hildenbrand" <david@redhat.com>,
"Jane Chu" <jane.chu@oracle.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Pavel Tatashin" <pasha.tatashin@soleen.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Paul Mackerras" <paulus@samba.org>,
"Toshi Kani" <toshi.kani@hpe.com>,
"Jeff Moyer" <jmoyer@redhat.com>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
stable@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>,
linux-nvdimm@lists.01.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/12] mm: Sub-section memory hotplug support
Date: Tue, 4 Jun 2019 09:41:00 +0200 [thread overview]
Message-ID: <20190604074056.GA2853@linux> (raw)
In-Reply-To: <155718596657.130019.17139634728875079809.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon, May 06, 2019 at 04:39:26PM -0700, Dan Williams wrote:
> Changes since v7 [1]:
>
> - Make subsection helpers pfn based rather than physical-address based
> (Oscar and Pavel)
>
> - Make subsection bitmap definition scalable for different section and
> sub-section sizes across architectures. As a result:
>
> unsigned long map_active
>
> ...is converted to:
>
> DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION)
>
> ...and the helpers are renamed with a 'subsection' prefix. (Pavel)
>
> - New in this version is a touch of arch/powerpc/include/asm/sparsemem.h
> in "[PATCH v8 01/12] mm/sparsemem: Introduce struct mem_section_usage"
> to define ARCH_SUBSECTION_SHIFT.
>
> - Drop "mm/sparsemem: Introduce common definitions for the size and mask
> of a section" in favor of Robin's "mm/memremap: Rename and consolidate
> SECTION_SIZE" (Pavel)
>
> - Collect some more Reviewed-by tags. Patches that still lack review
> tags: 1, 3, 9 - 12
Hi Dan,
are you planning to send V10 anytime soon?
After you addressed comments from Patch#9, the general implementation looks
fine to me and nothing sticked out from the other patches.
But I would rather wait to see v10 with the comments addressed before stamping
my Reviewed-by.
I am planning to fire my vmemmap patchset again [1], and I would like to re-base
it on top of this work, otherwise we will face many unnecessary collisions.
Thanks
[1] https://patchwork.kernel.org/patch/10875025/
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2019-06-04 7:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 23:39 [PATCH v8 00/12] mm: Sub-section memory hotplug support Dan Williams
2019-05-06 23:39 ` [PATCH v8 01/12] mm/sparsemem: Introduce struct mem_section_usage Dan Williams
2019-05-10 13:30 ` osalvador
2019-05-10 19:38 ` Dan Williams
2019-05-06 23:39 ` [PATCH v8 02/12] mm/memremap: Rename and consolidate SECTION_SIZE Dan Williams
2019-05-06 23:39 ` [PATCH v8 03/12] mm/sparsemem: Add helpers track active portions of a section at boot Dan Williams
2019-05-10 12:56 ` osalvador
2019-05-06 23:39 ` [PATCH v8 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal Dan Williams
2019-05-06 23:39 ` [PATCH v8 05/12] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap() Dan Williams
2019-05-06 23:39 ` [PATCH v8 06/12] mm/hotplug: Kill is_dev_zone() usage in __remove_pages() Dan Williams
2019-05-06 23:40 ` [PATCH v8 07/12] mm: Kill is_dev_zone() helper Dan Williams
2019-05-06 23:40 ` [PATCH v8 08/12] mm/sparsemem: Prepare for sub-section ranges Dan Williams
2019-05-10 13:00 ` osalvador
2019-05-06 23:40 ` [PATCH v8 09/12] mm/sparsemem: Support sub-section hotplug Dan Williams
2019-05-08 23:15 ` Oscar Salvador
2019-05-13 13:54 ` Oscar Salvador
2019-06-04 4:47 ` Dan Williams
2019-05-06 23:40 ` [PATCH v8 10/12] mm/devm_memremap_pages: Enable sub-section remap Dan Williams
2019-05-06 23:40 ` [PATCH v8 11/12] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields Dan Williams
2019-05-06 23:40 ` [PATCH v8 12/12] libnvdimm/pfn: Stop padding pmem namespaces to section alignment Dan Williams
2019-05-13 21:01 ` [PATCH v8 00/12] mm: Sub-section memory hotplug support Mike Rapoport
2019-05-13 21:11 ` Dan Williams
2019-06-04 7:41 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604074056.GA2853@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jane.chu@oracle.com \
--cc=jglisse@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=pasha.tatashin@soleen.com \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=toshi.kani@hpe.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).