linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH
@ 2019-06-04  7:58 Krzysztof Kozlowski
  2019-06-04  8:00 ` Geert Uytterhoeven
  2019-06-04 14:55 ` Heiko Carstens
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-04  7:58 UTC (permalink / raw)
  To: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390,
	linux-kernel
  Cc: Geert Uytterhoeven, Krzysztof Kozlowski

Remove the CONFIG_UEVENT_HELPER_PATH because:
1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
   CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
   made default to 'n',
2. It is not recommended (help message: "This should not be used today
   [...] creates a high system load") and was kept only for ancient
   userland,
3. Certain userland specifically requests it to be disabled (systemd
   README: "Legacy hotplug slows down the system and confuses udev").

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/s390/configs/defconfig          | 1 -
 arch/s390/configs/zfcpdump_defconfig | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
index c59b922cb6c5..18cff2e4607d 100644
--- a/arch/s390/configs/defconfig
+++ b/arch/s390/configs/defconfig
@@ -94,7 +94,6 @@ CONFIG_NET_CLS_RSVP6=m
 CONFIG_NET_CLS_ACT=y
 CONFIG_NET_ACT_POLICE=y
 CONFIG_BPF_JIT=y
-CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_NBD=m
diff --git a/arch/s390/configs/zfcpdump_defconfig b/arch/s390/configs/zfcpdump_defconfig
index 7dc7f58c4287..d92bab844b73 100644
--- a/arch/s390/configs/zfcpdump_defconfig
+++ b/arch/s390/configs/zfcpdump_defconfig
@@ -24,7 +24,6 @@ CONFIG_CRASH_DUMP=y
 # CONFIG_SECCOMP is not set
 CONFIG_NET=y
 # CONFIG_IUCV is not set
-CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_BLK_DEV_RAM=y
 # CONFIG_BLK_DEV_XPRAM is not set
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH
  2019-06-04  7:58 [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
@ 2019-06-04  8:00 ` Geert Uytterhoeven
  2019-06-04 14:55 ` Heiko Carstens
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-06-04  8:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390,
	Linux Kernel Mailing List, Geert Uytterhoeven

On Tue, Jun 4, 2019 at 9:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Remove the CONFIG_UEVENT_HELPER_PATH because:
> 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
>    CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
>    made default to 'n',
> 2. It is not recommended (help message: "This should not be used today
>    [...] creates a high system load") and was kept only for ancient
>    userland,
> 3. Certain userland specifically requests it to be disabled (systemd
>    README: "Legacy hotplug slows down the system and confuses udev").
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH
  2019-06-04  7:58 [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
  2019-06-04  8:00 ` Geert Uytterhoeven
@ 2019-06-04 14:55 ` Heiko Carstens
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2019-06-04 14:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Vasily Gorbik, Christian Borntraeger, linux-s390, linux-kernel,
	Geert Uytterhoeven

On Tue, Jun 04, 2019 at 09:58:57AM +0200, Krzysztof Kozlowski wrote:
> Remove the CONFIG_UEVENT_HELPER_PATH because:
> 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
>    CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
>    made default to 'n',
> 2. It is not recommended (help message: "This should not be used today
>    [...] creates a high system load") and was kept only for ancient
>    userland,
> 3. Certain userland specifically requests it to be disabled (systemd
>    README: "Legacy hotplug slows down the system and confuses udev").
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/s390/configs/defconfig          | 1 -
>  arch/s390/configs/zfcpdump_defconfig | 1 -
>  2 files changed, 2 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-04 14:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04  7:58 [PATCH] s390: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
2019-06-04  8:00 ` Geert Uytterhoeven
2019-06-04 14:55 ` Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).