[PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[megous]

From: Ondrej Jirman <megous@megous.com>

The current code defines W1 clock gate to be at 0x1cc, overlaying it
with the IR gate.

Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
causing interrupt floods on H6 (because interrupt flags can't be cleared,
due to IR module's bus being disabled).

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c
index 27554eaf6929..8d05d4f1f8a1 100644
--- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c
+++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c
@@ -104,7 +104,7 @@ static SUNXI_CCU_GATE(r_apb2_i2c_clk,	"r-apb2-i2c",	"r-apb2",
 static SUNXI_CCU_GATE(r_apb1_ir_clk,	"r-apb1-ir",	"r-apb1",
 		      0x1cc, BIT(0), 0);
 static SUNXI_CCU_GATE(r_apb1_w1_clk,	"r-apb1-w1",	"r-apb1",
-		      0x1cc, BIT(0), 0);
+		      0x1ec, BIT(0), 0);
 
 /* Information of IR(RX) mod clock is gathered from BSP source code */
 static const char * const r_mod0_default_parents[] = { "osc32k", "osc24M" };
-- 
2.21.0

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[Jernej Škrabec]

Dne torek, 04. junij 2019 ob 17:00:54 CEST je megous via linux-sunxi 
napisal(a):
> From: Ondrej Jirman <megous@megous.com>
> 
> The current code defines W1 clock gate to be at 0x1cc, overlaying it
> with the IR gate.
> 
> Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
> causing interrupt floods on H6 (because interrupt flags can't be cleared,
> due to IR module's bus being disabled).
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>

You should add Fixes tag and CC stable with this.

Best regards,
Jernej

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[Ondřej Jirman]

Hi Jernej,

On Tue, Jun 04, 2019 at 05:03:55PM +0200, Jernej Škrabec wrote:
> Dne torek, 04. junij 2019 ob 17:00:54 CEST je megous via linux-sunxi 
> napisal(a):
> > From: Ondrej Jirman <megous@megous.com>
> > 
> > The current code defines W1 clock gate to be at 0x1cc, overlaying it
> > with the IR gate.
> > 
> > Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
> > causing interrupt floods on H6 (because interrupt flags can't be cleared,
> > due to IR module's bus being disabled).
> > 
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> 
> You should add Fixes tag and CC stable with this.

Not necessary, since H6 IR is not yet supported on mainline.

regards,
	o.

> Best regards,
> Jernej
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[Jernej Škrabec]

Hi!

Dne torek, 04. junij 2019 ob 17:31:20 CEST je 'Ondřej Jirman' via linux-sunxi 
napisal(a):
> Hi Jernej,
> 
> On Tue, Jun 04, 2019 at 05:03:55PM +0200, Jernej Škrabec wrote:
> > Dne torek, 04. junij 2019 ob 17:00:54 CEST je megous via linux-sunxi
> > 
> > napisal(a):
> > > From: Ondrej Jirman <megous@megous.com>
> > > 
> > > The current code defines W1 clock gate to be at 0x1cc, overlaying it
> > > with the IR gate.
> > > 
> > > Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
> > > causing interrupt floods on H6 (because interrupt flags can't be
> > > cleared,
> > > due to IR module's bus being disabled).
> > > 
> > > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > 
> > You should add Fixes tag and CC stable with this.
> 
> Not necessary, since H6 IR is not yet supported on mainline.

Well, CCing stable is probably really not necessary, but you are fixing bug in 
existing driver (clk), fixes tag still apply.

Best regards,
Jernej

> 
> regards,
> 	o.
> 
> > Best regards,
> > Jernej
> > 
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[Ondřej Jirman]

Hello Jernej,

On Tue, Jun 04, 2019 at 05:35:48PM +0200, Jernej Škrabec wrote:
> Hi!
> 
> Dne torek, 04. junij 2019 ob 17:31:20 CEST je 'Ondřej Jirman' via linux-sunxi 
> napisal(a):
> > Hi Jernej,
> > 
> > On Tue, Jun 04, 2019 at 05:03:55PM +0200, Jernej Škrabec wrote:
> > > Dne torek, 04. junij 2019 ob 17:00:54 CEST je megous via linux-sunxi
> > > 
> > > napisal(a):
> > > > From: Ondrej Jirman <megous@megous.com>
> > > > 
> > > > The current code defines W1 clock gate to be at 0x1cc, overlaying it
> > > > with the IR gate.
> > > > 
> > > > Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
> > > > causing interrupt floods on H6 (because interrupt flags can't be
> > > > cleared,
> > > > due to IR module's bus being disabled).
> > > > 
> > > > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > > 
> > > You should add Fixes tag and CC stable with this.
> > 
> > Not necessary, since H6 IR is not yet supported on mainline.
> 
> Well, CCing stable is probably really not necessary, but you are fixing bug in 
> existing driver (clk), fixes tag still apply.

Right, resent v2.

thank you and regards,
	o.

> Best regards,
> Jernej
> 
> > 
> > regards,
> > 	o.
> > 
> > > Best regards,
> > > Jernej
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel