From: Greg KH <gregkh@linuxfoundation.org>
To: Talel Shenhar <talel@amazon.com>
Cc: nicolas.ferre@microchip.com, jason@lakedaemon.net,
marc.zyngier@arm.com, mark.rutland@arm.com,
mchehab+samsung@kernel.org, robh+dt@kernel.org,
davem@davemloft.net, shawn.lin@rock-chips.com,
tglx@linutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk,
benh@kernel.crashing.org, jonnyc@amazon.com, hhhawa@amazon.com,
ronenk@amazon.com, hanochu@amazon.com, barakw@amazon.com
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Wed, 5 Jun 2019 14:50:55 +0200 [thread overview]
Message-ID: <20190605125055.GA3184@kroah.com> (raw)
In-Reply-To: <1559731921-14023-3-git-send-email-talel@amazon.com>
On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
> --- /dev/null
> +++ b/drivers/irqchip/irq-al-fic.c
> @@ -0,0 +1,289 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**
No need for kernel-doc format style here.
> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
"or its affiliates"? You know the answer to this, don't keep us in
suspense. Put the proper copyright holder here please, otherwise this
is totally useless.
Well, copyright notices are technically useless anyway, but lawyers like
to cargo-cult with the best of them, so it should be correct at the
least.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-05 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 10:51 [PATCH v2 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-05 10:52 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-05 11:08 ` Sudeep Holla
2019-06-05 15:49 ` Eduardo Valentin
2019-06-06 7:23 ` Shenhar, Talel
2019-06-05 10:52 ` [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
2019-06-05 12:22 ` Marc Zyngier
2019-06-05 14:38 ` Shenhar, Talel
2019-06-05 15:12 ` Marc Zyngier
2019-06-05 22:06 ` Benjamin Herrenschmidt
2019-06-06 7:05 ` Marc Zyngier
2019-06-06 7:49 ` Benjamin Herrenschmidt
2019-06-06 7:25 ` Shenhar, Talel
2019-06-05 22:02 ` Benjamin Herrenschmidt
2019-06-06 7:10 ` Marc Zyngier
2019-06-05 12:50 ` Greg KH [this message]
2019-06-05 14:51 ` Shenhar, Talel
2019-06-05 15:40 ` Greg KH
2019-06-05 14:56 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605125055.GA3184@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jason@lakedaemon.net \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=shawn.lin@rock-chips.com \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).