From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Marc Zyngier <marc.zyngier@arm.com>,
"Shenhar, Talel" <talel@amazon.com>,
nicolas.ferre@microchip.com, jason@lakedaemon.net,
mark.rutland@arm.com, mchehab+samsung@kernel.org,
robh+dt@kernel.org, davem@davemloft.net,
shawn.lin@rock-chips.com, tglx@linutronix.de,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: dwmw@amazon.co.uk, jonnyc@amazon.com, hhhawa@amazon.com,
ronenk@amazon.com, hanochu@amazon.com, barakw@amazon.com
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Thu, 06 Jun 2019 08:06:05 +1000 [thread overview]
Message-ID: <54df139cc6cfef9202be6b945c968c3040591607.camel@kernel.crashing.org> (raw)
In-Reply-To: <0915892c-0e53-8f53-e858-b1c3298a4d35@arm.com>
On Wed, 2019-06-05 at 16:12 +0100, Marc Zyngier wrote:
> > Those error messages are control path messages. if we return the same
> > error value from here and from the previous error, how can we
> > differentiate between the two error cases by looking at the log?
> >
> > Having informative printouts seems like a good idea for bad
> > configuration cases as such, wouldn't you agree?
>
> I completely disagree. The kernel log isn't a dumping ground for this
> kind of pretty useless information. Furthermore, the irq subsystem will
> also shout at you when it gets an error, so no need to add insult to injury.
>
> If you really want to keep them around, turn them into pr_debug.
I disagree Marc. This is a rather bad error which indicates that the device-tree
is probably incorrect (or the HW was wired in a way that cannot work).
Basically a given FIC can either be entirely level sensitive or entirely edge
sensitive. This catches cases where the DT has routed a mixed of both to the
same FIC. Definitely worth barfing loudly about rather than trying to understand
subtle odd misbehaviours of the device in the field.
Cheers,
Ben.
next prev parent reply other threads:[~2019-06-05 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 10:51 [PATCH v2 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-05 10:52 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-05 11:08 ` Sudeep Holla
2019-06-05 15:49 ` Eduardo Valentin
2019-06-06 7:23 ` Shenhar, Talel
2019-06-05 10:52 ` [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
2019-06-05 12:22 ` Marc Zyngier
2019-06-05 14:38 ` Shenhar, Talel
2019-06-05 15:12 ` Marc Zyngier
2019-06-05 22:06 ` Benjamin Herrenschmidt [this message]
2019-06-06 7:05 ` Marc Zyngier
2019-06-06 7:49 ` Benjamin Herrenschmidt
2019-06-06 7:25 ` Shenhar, Talel
2019-06-05 22:02 ` Benjamin Herrenschmidt
2019-06-06 7:10 ` Marc Zyngier
2019-06-05 12:50 ` Greg KH
2019-06-05 14:51 ` Shenhar, Talel
2019-06-05 15:40 ` Greg KH
2019-06-05 14:56 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54df139cc6cfef9202be6b945c968c3040591607.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=barakw@amazon.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jason@lakedaemon.net \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=shawn.lin@rock-chips.com \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).