From: Bharath Vedartham <linux.bhar@gmail.com>
To: Michal Hocko <mhocko@kernel.org>,
akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com
Cc: khalid.aziz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Remove VM_BUG_ON in __alloc_pages_node
Date: Wed, 5 Jun 2019 18:37:28 +0530 [thread overview]
Message-ID: <20190605130727.GA25529@bharath12345-Inspiron-5559> (raw)
In-Reply-To: <20190605070312.GB15685@dhcp22.suse.cz>
[Not replying inline as my mail is bouncing back]
This patch is based on reading the code rather than a kernel crash. My
thought process was that if an invalid node id was passed to
__alloc_pages_node, it would be better to add a VM_WARN_ON and fail the
allocation rather than crashing the kernel.
I feel it would be better to fail the allocation early in the hot path
if an invalid node id is passed. This is irrespective of whether the
VM_[BUG|WARN]_*s are enabled or not. I do not see any checks in the hot
path for the node id, which in turn may cause NODE_DATA(nid) to fail to
get the pglist_data pointer for the node id.
We can optimise the branch by wrapping it around in unlikely(), if
performance is the issue?
What are your thoughts on this?
Thank you
Bharath
next prev parent reply other threads:[~2019-06-05 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 6:02 [PATCH] mm: Remove VM_BUG_ON in __alloc_pages_node Bharath Vedartham
2019-06-05 7:03 ` Michal Hocko
2019-06-05 13:07 ` Bharath Vedartham [this message]
2019-06-05 14:22 ` Michal Hocko
2019-06-05 15:55 ` Bharath Vedartham
2019-06-06 5:29 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605130727.GA25529@bharath12345-Inspiron-5559 \
--to=linux.bhar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).