* [PATCH v5 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation
@ 2019-06-05 22:22 Paul Cercueil
2019-06-05 22:22 ` [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Paul Cercueil
2019-06-05 22:22 ` [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
0 siblings, 2 replies; 6+ messages in thread
From: Paul Cercueil @ 2019-06-05 22:22 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, Hans Verkuil, Mauro Carvalho Chehab
Cc: dri-devel, devicetree, linux-kernel, linux-media, od,
Paul Cercueil, Rob Herring
The GPM940B0 is a 3.0" 320x240 24-bit TFT LCD panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Notes:
v2: New patch
v3: Add Rob's ack
v4-v5: No change
.../bindings/display/panel/giantplus,gpm940b0.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
diff --git a/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
new file mode 100644
index 000000000000..3dab52f92c26
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
@@ -0,0 +1,12 @@
+GiantPlus 3.0" (320x240 pixels) 24-bit TFT LCD panel
+
+Required properties:
+- compatible: should be "giantplus,gpm940b0"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
2.21.0.593.g511ec345e18
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format
2019-06-05 22:22 [PATCH v5 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil
@ 2019-06-05 22:22 ` Paul Cercueil
2019-06-05 23:41 ` Mauro Carvalho Chehab
2019-06-06 8:17 ` Sakari Ailus
2019-06-05 22:22 ` [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
1 sibling, 2 replies; 6+ messages in thread
From: Paul Cercueil @ 2019-06-05 22:22 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, Hans Verkuil, Mauro Carvalho Chehab
Cc: dri-devel, devicetree, linux-kernel, linux-media, od, Paul Cercueil
This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus
GPM940B0 24-bit TFT panel, where the RGB components are transferred
sequentially on a 8-bit bus.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: New patch
v3: No change
v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care about
endianness
v5: Also update Documentation/media/uapi/v4l/subdev-formats.rst
.../media/uapi/v4l/subdev-formats.rst | 107 ++++++++++++++++++
include/uapi/linux/media-bus-format.h | 3 +-
2 files changed, 109 insertions(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst b/Documentation/media/uapi/v4l/subdev-formats.rst
index ab1a48a5ae80..f4f8de31ac63 100644
--- a/Documentation/media/uapi/v4l/subdev-formats.rst
+++ b/Documentation/media/uapi/v4l/subdev-formats.rst
@@ -1305,6 +1305,113 @@ The following tables list existing packed RGB formats.
- g\ :sub:`6`
- g\ :sub:`5`
- g\ :sub:`4`
+ * .. _MEDIA-BUS-FMT-RGB888-3X8:
+
+ - MEDIA_BUS_FMT_RGB888_3X8
+ - 0x101c
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ - r\ :sub:`7`
+ - r\ :sub:`6`
+ - r\ :sub:`5`
+ - r\ :sub:`4`
+ - r\ :sub:`3`
+ - r\ :sub:`2`
+ - r\ :sub:`1`
+ - r\ :sub:`0`
+ * -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ - g\ :sub:`7`
+ - g\ :sub:`6`
+ - g\ :sub:`5`
+ - g\ :sub:`4`
+ - g\ :sub:`3`
+ - g\ :sub:`2`
+ - g\ :sub:`1`
+ - g\ :sub:`0`
+ * -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ -
+ - b\ :sub:`7`
+ - b\ :sub:`6`
+ - b\ :sub:`5`
+ - b\ :sub:`4`
+ - b\ :sub:`3`
+ - b\ :sub:`2`
+ - b\ :sub:`1`
+ - b\ :sub:`0`
* .. _MEDIA-BUS-FMT-ARGB888-1X32:
- MEDIA_BUS_FMT_ARGB888_1X32
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index 2a6b253cfb05..16c1fa2d89a4 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -34,7 +34,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x101c */
+/* RGB - next is 0x101d */
#define MEDIA_BUS_FMT_RGB444_1X12 0x1016
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
@@ -55,6 +55,7 @@
#define MEDIA_BUS_FMT_RGB888_1X24 0x100a
#define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
#define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
+#define MEDIA_BUS_FMT_RGB888_3X8 0x101c
#define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
#define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
#define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
--
2.21.0.593.g511ec345e18
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support
2019-06-05 22:22 [PATCH v5 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil
2019-06-05 22:22 ` [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Paul Cercueil
@ 2019-06-05 22:22 ` Paul Cercueil
2019-06-25 20:19 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2019-06-05 22:22 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, Hans Verkuil, Mauro Carvalho Chehab
Cc: dri-devel, devicetree, linux-kernel, linux-media, od,
Paul Cercueil, Artur Rojek
The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
Notes:
v2: Change bus format to MEDIA_BUS_FMT_RGB888_3X8_BE
v3: No change
v4: Change bus format to MEDIA_BUS_FMT_RGB888_3X8
v5: No change
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5a93c4edf1e4..eec9a9efcc73 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1335,6 +1335,31 @@ static const struct panel_desc giantplus_gpg482739qs5 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+static const struct display_timing giantplus_gpm940b0_timing = {
+ .pixelclock = { 13500000, 27000000, 27500000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 14, 686, 718 },
+ .hback_porch = { 50, 70, 255 },
+ .hsync_len = { 1, 1, 1 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 1, 1, 179 },
+ .vback_porch = { 1, 21, 31 },
+ .vsync_len = { 1, 1, 6 },
+ .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc giantplus_gpm940b0 = {
+ .timings = &giantplus_gpm940b0_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 60,
+ .height = 45,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_3X8,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
static const struct display_timing hannstar_hsd070pww1_timing = {
.pixelclock = { 64300000, 71100000, 82000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2882,6 +2907,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "giantplus,gpg482739qs5",
.data = &giantplus_gpg482739qs5
+ }, {
+ .compatible = "giantplus,gpm940b0",
+ .data = &giantplus_gpm940b0,
}, {
.compatible = "hannstar,hsd070pww1",
.data = &hannstar_hsd070pww1,
--
2.21.0.593.g511ec345e18
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format
2019-06-05 22:22 ` [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Paul Cercueil
@ 2019-06-05 23:41 ` Mauro Carvalho Chehab
2019-06-06 8:17 ` Sakari Ailus
1 sibling, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2019-06-05 23:41 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, Sam Ravnborg, Hans Verkuil, dri-devel,
devicetree, linux-kernel, linux-media, od
Em Thu, 6 Jun 2019 00:22:46 +0200
Paul Cercueil <paul@crapouillou.net> escreveu:
> This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus
> GPM940B0 24-bit TFT panel, where the RGB components are transferred
> sequentially on a 8-bit bus.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Looks ok to me. Feel free to apply via DRM tree.
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
>
> Notes:
> v2: New patch
>
> v3: No change
>
> v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care about
> endianness
>
> v5: Also update Documentation/media/uapi/v4l/subdev-formats.rst
>
> .../media/uapi/v4l/subdev-formats.rst | 107 ++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 3 +-
> 2 files changed, 109 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst b/Documentation/media/uapi/v4l/subdev-formats.rst
> index ab1a48a5ae80..f4f8de31ac63 100644
> --- a/Documentation/media/uapi/v4l/subdev-formats.rst
> +++ b/Documentation/media/uapi/v4l/subdev-formats.rst
> @@ -1305,6 +1305,113 @@ The following tables list existing packed RGB formats.
> - g\ :sub:`6`
> - g\ :sub:`5`
> - g\ :sub:`4`
> + * .. _MEDIA-BUS-FMT-RGB888-3X8:
> +
> + - MEDIA_BUS_FMT_RGB888_3X8
> + - 0x101c
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + - r\ :sub:`7`
> + - r\ :sub:`6`
> + - r\ :sub:`5`
> + - r\ :sub:`4`
> + - r\ :sub:`3`
> + - r\ :sub:`2`
> + - r\ :sub:`1`
> + - r\ :sub:`0`
> + * -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + - g\ :sub:`7`
> + - g\ :sub:`6`
> + - g\ :sub:`5`
> + - g\ :sub:`4`
> + - g\ :sub:`3`
> + - g\ :sub:`2`
> + - g\ :sub:`1`
> + - g\ :sub:`0`
> + * -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + -
> + - b\ :sub:`7`
> + - b\ :sub:`6`
> + - b\ :sub:`5`
> + - b\ :sub:`4`
> + - b\ :sub:`3`
> + - b\ :sub:`2`
> + - b\ :sub:`1`
> + - b\ :sub:`0`
> * .. _MEDIA-BUS-FMT-ARGB888-1X32:
>
> - MEDIA_BUS_FMT_ARGB888_1X32
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 2a6b253cfb05..16c1fa2d89a4 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x101c */
> +/* RGB - next is 0x101d */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -55,6 +55,7 @@
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
> +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c
> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
Thanks,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format
2019-06-05 22:22 ` [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Paul Cercueil
2019-06-05 23:41 ` Mauro Carvalho Chehab
@ 2019-06-06 8:17 ` Sakari Ailus
1 sibling, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2019-06-06 8:17 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, Sam Ravnborg, Hans Verkuil,
Mauro Carvalho Chehab, dri-devel, devicetree, linux-kernel,
linux-media, od
On Thu, Jun 06, 2019 at 12:22:46AM +0200, Paul Cercueil wrote:
> This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus
> GPM940B0 24-bit TFT panel, where the RGB components are transferred
> sequentially on a 8-bit bus.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support
2019-06-05 22:22 ` [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
@ 2019-06-25 20:19 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2019-06-25 20:19 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, Hans Verkuil, Mauro Carvalho Chehab, dri-devel,
devicetree, linux-kernel, linux-media, od, Artur Rojek
On Thu, Jun 06, 2019 at 12:22:47AM +0200, Paul Cercueil wrote:
> The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
All patches applied to drm-misc-next.
Added the ack from the mails to patch 2.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-25 20:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 22:22 [PATCH v5 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil
2019-06-05 22:22 ` [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Paul Cercueil
2019-06-05 23:41 ` Mauro Carvalho Chehab
2019-06-06 8:17 ` Sakari Ailus
2019-06-05 22:22 ` [PATCH v5 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
2019-06-25 20:19 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).