* [PATCH v2 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration
2019-05-16 4:32 [PATCH v2 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
@ 2019-05-16 4:32 ` Keerthy
2019-06-13 21:28 ` Rob Herring
2019-05-16 4:32 ` [PATCH v2 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-16 4:32 ` [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
2 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2019-05-16 4:32 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
lp87561 is a single output 4-phase regulator configuration.
Add support for the same.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../devicetree/bindings/mfd/lp87565.txt | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
index a48df7c08ab0..41671e0dc26b 100644
--- a/Documentation/devicetree/bindings/mfd/lp87565.txt
+++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
@@ -41,3 +41,39 @@ lp87565_pmic: pmic@60 {
};
};
};
+
+TI LP87561 PMIC:
+
+This is a single output 4-phase regulator configuration
+
+Required properties:
+ - compatible: "ti,lp87561-q1"
+ - reg: I2C slave address.
+ - gpio-controller: Marks the device node as a GPIO Controller.
+ - #gpio-cells: Should be two. The first cell is the pin number and
+ the second cell is used to specify flags.
+ See ../gpio/gpio.txt for more information.
+ - xxx-in-supply: Phandle to parent supply node of each regulator
+ populated under regulators node. xxx should match
+ the supply_name populated in driver.
+Example:
+
+lp87561_pmic: pmic@62 {
+ compatible = "ti,lp87561-q1";
+ reg = <0x62>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ buck3210-in-supply = <&vsys_3v3>;
+
+ regulators: regulators {
+ buck3210_reg: buck3210 {
+ /* VDD_CORE */
+ regulator-name = "buck3210";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration
2019-05-16 4:32 ` [PATCH v2 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
@ 2019-06-13 21:28 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2019-06-13 21:28 UTC (permalink / raw)
To: Keerthy
Cc: lee.jones, broonie, linux-kernel, devicetree, linux-omap, t-kristo
On Thu, May 16, 2019 at 10:02:16AM +0530, Keerthy wrote:
> lp87561 is a single output 4-phase regulator configuration.
> Add support for the same.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> .../devicetree/bindings/mfd/lp87565.txt | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
> index a48df7c08ab0..41671e0dc26b 100644
> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
> @@ -41,3 +41,39 @@ lp87565_pmic: pmic@60 {
> };
> };
> };
> +
> +TI LP87561 PMIC:
> +
> +This is a single output 4-phase regulator configuration
> +
> +Required properties:
> + - compatible: "ti,lp87561-q1"
> + - reg: I2C slave address.
> + - gpio-controller: Marks the device node as a GPIO Controller.
> + - #gpio-cells: Should be two. The first cell is the pin number and
> + the second cell is used to specify flags.
> + See ../gpio/gpio.txt for more information.
> + - xxx-in-supply: Phandle to parent supply node of each regulator
> + populated under regulators node. xxx should match
> + the supply_name populated in driver.
This is not something we can validate. You need to enumerate values of
'xxx'.
> +Example:
> +
> +lp87561_pmic: pmic@62 {
> + compatible = "ti,lp87561-q1";
> + reg = <0x62>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + buck3210-in-supply = <&vsys_3v3>;
> +
> + regulators: regulators {
> + buck3210_reg: buck3210 {
> + /* VDD_CORE */
> + regulator-name = "buck3210";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> + };
> +};
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination
2019-05-16 4:32 [PATCH v2 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-16 4:32 ` [PATCH v2 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
@ 2019-05-16 4:32 ` Keerthy
2019-05-16 4:32 ` [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
2 siblings, 0 replies; 13+ messages in thread
From: Keerthy @ 2019-05-16 4:32 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
Add support for 4-phase lp87561 combination.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/mfd/lp87565.c | 4 ++++
include/linux/mfd/lp87565.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 32d2a07d4354..8ad688fe75f9 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -33,6 +33,10 @@ static const struct of_device_id of_lp87565_match_table[] = {
.compatible = "ti,lp87565-q1",
.data = (void *)LP87565_DEVICE_TYPE_LP87565_Q1,
},
+ {
+ .compatible = "ti,lp87561-q1",
+ .data = (void *)LP87565_DEVICE_TYPE_LP87561_Q1,
+ },
{}
};
MODULE_DEVICE_TABLE(of, of_lp87565_match_table);
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index d0c91ba65525..976447607ea2 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -17,6 +17,7 @@
enum lp87565_device_type {
LP87565_DEVICE_TYPE_UNKNOWN = 0,
+ LP87565_DEVICE_TYPE_LP87561_Q1,
LP87565_DEVICE_TYPE_LP87565_Q1,
};
@@ -249,6 +250,7 @@ enum LP87565_regulator_id {
LP87565_BUCK_3,
LP87565_BUCK_10,
LP87565_BUCK_23,
+ LP87565_BUCK_3210,
};
/**
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-16 4:32 [PATCH v2 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-16 4:32 ` [PATCH v2 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
2019-05-16 4:32 ` [PATCH v2 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
@ 2019-05-16 4:32 ` Keerthy
2019-05-22 15:35 ` Mark Brown
2 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2019-05-16 4:32 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
The LP8756x family has a single output 4-phase regulator
configuration. Add support for the same. The control
lies in the master buck which is buck0 for 4-phase
configuration. Enable/disable/voltage set happen via
buck0 registers.
Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Changes in v2:
* Changed if/else block to switch statement.
drivers/regulator/lp87565-regulator.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
index 81eb4b890c0c..af00d1ffcf33 100644
--- a/drivers/regulator/lp87565-regulator.c
+++ b/drivers/regulator/lp87565-regulator.c
@@ -153,6 +153,12 @@ static const struct lp87565_regulator regulators[] = {
LP87565_REG_BUCK2_CTRL_1,
LP87565_BUCK_CTRL_1_EN, 3230,
buck0_1_2_3_ranges, LP87565_REG_BUCK2_CTRL_2),
+ LP87565_REGULATOR("BUCK3210", LP87565_BUCK_3210, "buck3210",
+ lp87565_buck_ops, 256, LP87565_REG_BUCK0_VOUT,
+ LP87565_BUCK_VSET, LP87565_REG_BUCK0_CTRL_1,
+ LP87565_BUCK_CTRL_1_EN |
+ LP87565_BUCK_CTRL_1_FPWM_MP_0_2, 3230,
+ buck0_1_2_3_ranges, LP87565_REG_BUCK0_CTRL_2),
};
static int lp87565_regulator_probe(struct platform_device *pdev)
@@ -169,9 +175,18 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
config.driver_data = lp87565;
config.regmap = lp87565->regmap;
- if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
+ switch (lp87565->dev_type) {
+ case LP87565_DEVICE_TYPE_LP87565_Q1:
min_idx = LP87565_BUCK_10;
max_idx = LP87565_BUCK_23;
+ break;
+ case LP87565_DEVICE_TYPE_LP87561_Q1:
+ min_idx = LP87565_BUCK_3210;
+ max_idx = LP87565_BUCK_3210;
+ default:
+ dev_err(lp87565->dev, "Invalid lp config %d\n",
+ lp87565->dev_type);
+ return -EINVAL;
}
for (i = min_idx; i <= max_idx; i++) {
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-16 4:32 ` [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
@ 2019-05-22 15:35 ` Mark Brown
2019-05-28 9:53 ` Keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2019-05-22 15:35 UTC (permalink / raw)
To: Keerthy
Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote:
> The LP8756x family has a single output 4-phase regulator
> configuration. Add support for the same. The control
> lies in the master buck which is buck0 for 4-phase
> configuration. Enable/disable/voltage set happen via
> buck0 registers.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-22 15:35 ` Mark Brown
@ 2019-05-28 9:53 ` Keerthy
2019-05-28 13:27 ` Mark Brown
0 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2019-05-28 9:53 UTC (permalink / raw)
To: Mark Brown, lee.jones
Cc: robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
On 22/05/19 9:05 PM, Mark Brown wrote:
> On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote:
>> The LP8756x family has a single output 4-phase regulator
>> configuration. Add support for the same. The control
>> lies in the master buck which is buck0 for 4-phase
>> configuration. Enable/disable/voltage set happen via
>> buck0 registers.
>
> Acked-by: Mark Brown <broonie@kernel.org>
Mark/Lee,
This patch will come via the mfd branch?
- Keerthy
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-28 9:53 ` Keerthy
@ 2019-05-28 13:27 ` Mark Brown
2019-06-08 3:56 ` keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2019-05-28 13:27 UTC (permalink / raw)
To: Keerthy
Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
On Tue, May 28, 2019 at 03:23:41PM +0530, Keerthy wrote:
> On 22/05/19 9:05 PM, Mark Brown wrote:
> > On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote:
> > Acked-by: Mark Brown <broonie@kernel.org>
> This patch will come via the mfd branch?
I'd expect so, IIRC it had a build dependency on the earlier patches in
the series so if that doesn't happen I'll need to merge the relevant MFD
commits.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-28 13:27 ` Mark Brown
@ 2019-06-08 3:56 ` keerthy
2019-06-08 19:51 ` Mark Brown
0 siblings, 1 reply; 13+ messages in thread
From: keerthy @ 2019-06-08 3:56 UTC (permalink / raw)
To: Mark Brown
Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
On 5/28/2019 6:57 PM, Mark Brown wrote:
> On Tue, May 28, 2019 at 03:23:41PM +0530, Keerthy wrote:
>> On 22/05/19 9:05 PM, Mark Brown wrote:
>>> On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote:
>
>>> Acked-by: Mark Brown <broonie@kernel.org>
>
>> This patch will come via the mfd branch?
>
> I'd expect so, IIRC it had a build dependency on the earlier patches in
> the series so if that doesn't happen I'll need to merge the relevant MFD
> commits.
Mark,
mfd patches are on linux-next already. Hope you can pull this one now
that dependencies are met.
- Keerthy
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-06-08 3:56 ` keerthy
@ 2019-06-08 19:51 ` Mark Brown
2019-06-10 5:48 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2019-06-08 19:51 UTC (permalink / raw)
To: keerthy
Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote:
> mfd patches are on linux-next already. Hope you can pull this one now that
> dependencies are met.
Someone will need to send me a copy of the patch, if I acked it I was
expecting it to go in with the MFD changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-06-08 19:51 ` Mark Brown
@ 2019-06-10 5:48 ` Lee Jones
2019-06-12 10:47 ` Keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2019-06-10 5:48 UTC (permalink / raw)
To: Mark Brown
Cc: keerthy, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
On Sat, 08 Jun 2019, Mark Brown wrote:
> On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote:
>
> > mfd patches are on linux-next already. Hope you can pull this one now that
> > dependencies are met.
>
> Someone will need to send me a copy of the patch, if I acked it I was
> expecting it to go in with the MFD changes.
There is/was no need for that. Patches are built-time orthogonal.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-06-10 5:48 ` Lee Jones
@ 2019-06-12 10:47 ` Keerthy
2019-06-12 14:33 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2019-06-12 10:47 UTC (permalink / raw)
To: Lee Jones, Mark Brown
Cc: robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
On 10/06/19 11:18 AM, Lee Jones wrote:
> On Sat, 08 Jun 2019, Mark Brown wrote:
>
>> On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote:
>>
>>> mfd patches are on linux-next already. Hope you can pull this one now that
>>> dependencies are met.
>>
>> Someone will need to send me a copy of the patch, if I acked it I was
>> expecting it to go in with the MFD changes.
>
> There is/was no need for that. Patches are built-time orthogonal.
Sorry i am still not clear. Should i resend this patch?
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-06-12 10:47 ` Keerthy
@ 2019-06-12 14:33 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2019-06-12 14:33 UTC (permalink / raw)
To: Keerthy
Cc: Mark Brown, robh+dt, linux-kernel, devicetree, linux-omap, t-kristo
On Wed, 12 Jun 2019, Keerthy wrote:
>
>
> On 10/06/19 11:18 AM, Lee Jones wrote:
> > On Sat, 08 Jun 2019, Mark Brown wrote:
> >
> > > On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote:
> > >
> > > > mfd patches are on linux-next already. Hope you can pull this one now that
> > > > dependencies are met.
> > >
> > > Someone will need to send me a copy of the patch, if I acked it I was
> > > expecting it to go in with the MFD changes.
> >
> > There is/was no need for that. Patches are built-time orthogonal.
>
> Sorry i am still not clear. Should i resend this patch?
Yes. It sounds like Mark no longer has the patch to apply.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread