* [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc
@ 2019-06-11 11:16 Grygorii Strashko
2019-06-12 0:54 ` Stephen Rothwell
2019-06-12 18:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Grygorii Strashko @ 2019-06-11 11:16 UTC (permalink / raw)
To: David S. Miller, Stephen Rothwell, netdev
Cc: Sekhar Nori, linux-kernel, linux-arm-kernel, linux-next,
Grygorii Strashko
Add dependency to TI CPTS from Common CLK framework COMMON_CLK to fix
allyesconfig build for Powerpc:
drivers/net/ethernet/ti/cpts.c: In function 'cpts_of_mux_clk_setup':
drivers/net/ethernet/ti/cpts.c:567:2: error: implicit declaration of function 'of_clk_parent_fill'; did you mean 'of_clk_get_parent_name'? [-Werror=implicit-function-declaration]
of_clk_parent_fill(refclk_np, parent_names, num_parents);
^~~~~~~~~~~~~~~~~~
of_clk_get_parent_name
Fixes: a3047a81ba13 ("net: ethernet: ti: cpts: add support for ext rftclk selection")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Resending due to missed netdev@vger.kernel.org list in prev post.
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index bd05a977ee7e..a800d3417411 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -60,6 +60,7 @@ config TI_CPSW
config TI_CPTS
bool "TI Common Platform Time Sync (CPTS) Support"
depends on TI_CPSW || TI_KEYSTONE_NETCP || COMPILE_TEST
+ depends on COMMON_CLK
depends on POSIX_TIMERS
---help---
This driver supports the Common Platform Time Sync unit of
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc
2019-06-11 11:16 [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc Grygorii Strashko
@ 2019-06-12 0:54 ` Stephen Rothwell
2019-06-12 18:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2019-06-12 0:54 UTC (permalink / raw)
To: Grygorii Strashko
Cc: David S. Miller, netdev, Sekhar Nori, linux-kernel,
linux-arm-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
Hi all,
On Tue, 11 Jun 2019 14:16:32 +0300 Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>
> Add dependency to TI CPTS from Common CLK framework COMMON_CLK to fix
> allyesconfig build for Powerpc:
>
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_of_mux_clk_setup':
> drivers/net/ethernet/ti/cpts.c:567:2: error: implicit declaration of function 'of_clk_parent_fill'; did you mean 'of_clk_get_parent_name'? [-Werror=implicit-function-declaration]
> of_clk_parent_fill(refclk_np, parent_names, num_parents);
> ^~~~~~~~~~~~~~~~~~
> of_clk_get_parent_name
>
> Fixes: a3047a81ba13 ("net: ethernet: ti: cpts: add support for ext rftclk selection")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
I have applied this to linu-next today instead of reverting a3047a81ba13.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc
2019-06-11 11:16 [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc Grygorii Strashko
2019-06-12 0:54 ` Stephen Rothwell
@ 2019-06-12 18:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-12 18:16 UTC (permalink / raw)
To: grygorii.strashko
Cc: sfr, netdev, nsekhar, linux-kernel, linux-arm-kernel, linux-next
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Tue, 11 Jun 2019 14:16:32 +0300
> Add dependency to TI CPTS from Common CLK framework COMMON_CLK to fix
> allyesconfig build for Powerpc:
>
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_of_mux_clk_setup':
> drivers/net/ethernet/ti/cpts.c:567:2: error: implicit declaration of function 'of_clk_parent_fill'; did you mean 'of_clk_get_parent_name'? [-Werror=implicit-function-declaration]
> of_clk_parent_fill(refclk_np, parent_names, num_parents);
> ^~~~~~~~~~~~~~~~~~
> of_clk_get_parent_name
>
> Fixes: a3047a81ba13 ("net: ethernet: ti: cpts: add support for ext rftclk selection")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Resending due to missed netdev@vger.kernel.org list in prev post.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-12 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 11:16 [RESEND PATCH net-next] net: ethernet: ti: cpts: fix build failure for powerpc Grygorii Strashko
2019-06-12 0:54 ` Stephen Rothwell
2019-06-12 18:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).