* [PATCH net] mpls: fix af_mpls dependencies for real
@ 2019-06-12 9:50 Matteo Croce
2019-06-12 16:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2019-06-12 9:50 UTC (permalink / raw)
To: netdev, David Miller, Linux Next Mailing List, Randy Dunlap; +Cc: akpm, LKML
Randy reported that selecting MPLS_ROUTING without PROC_FS breaks
the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls
dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select
doesn't recursively handle dependencies.
Change the select into a dependency.
Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
net/mpls/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
index 2b802a48d5a6..d1ad69b7942a 100644
--- a/net/mpls/Kconfig
+++ b/net/mpls/Kconfig
@@ -26,7 +26,7 @@ config NET_MPLS_GSO
config MPLS_ROUTING
tristate "MPLS: routing support"
depends on NET_IP_TUNNEL || NET_IP_TUNNEL=n
- select PROC_SYSCTL
+ depends on PROC_SYSCTL
---help---
Add support for forwarding of mpls packets.
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] mpls: fix af_mpls dependencies for real
2019-06-12 9:50 [PATCH net] mpls: fix af_mpls dependencies for real Matteo Croce
@ 2019-06-12 16:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-12 16:42 UTC (permalink / raw)
To: mcroce; +Cc: netdev, linux-next, rdunlap, akpm, linux-kernel
From: Matteo Croce <mcroce@redhat.com>
Date: Wed, 12 Jun 2019 11:50:37 +0200
> Randy reported that selecting MPLS_ROUTING without PROC_FS breaks
> the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls
> dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select
> doesn't recursively handle dependencies.
> Change the select into a dependency.
>
> Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-12 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 9:50 [PATCH net] mpls: fix af_mpls dependencies for real Matteo Croce
2019-06-12 16:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).