* [PATCH] sparc: fix unknown type name u_int in uapi header
@ 2019-06-04 8:23 Masahiro Yamada
2019-06-13 21:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-06-04 8:23 UTC (permalink / raw)
To: David S . Miller, sparclinux; +Cc: Masahiro Yamada, linux-kernel
'u_int' is a shorthand that is only available in the kernel space
because it is defined in include/linux/types.h, which is not exported
to the user space.
You cannot use it in uapi headers even if you include <linux/types.h>
Detected by compile-testing exported headers.
./usr/include/asm/openpromio.h:16:2: error: unknown type name ‘u_int’
u_int oprom_size; /* Actual size of the oprom_array. */
^~~~~
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/sparc/include/uapi/asm/openpromio.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/sparc/include/uapi/asm/openpromio.h b/arch/sparc/include/uapi/asm/openpromio.h
index 8817f7d1a70c..d4494b679e99 100644
--- a/arch/sparc/include/uapi/asm/openpromio.h
+++ b/arch/sparc/include/uapi/asm/openpromio.h
@@ -4,7 +4,6 @@
#include <linux/compiler.h>
#include <linux/ioctl.h>
-#include <linux/types.h>
/*
* SunOS and Solaris /dev/openprom definitions. The ioctl values
@@ -13,7 +12,7 @@
struct openpromio
{
- u_int oprom_size; /* Actual size of the oprom_array. */
+ unsigned int oprom_size; /* Actual size of the oprom_array. */
char oprom_array[1]; /* Holds property names and values. */
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sparc: fix unknown type name u_int in uapi header
2019-06-04 8:23 [PATCH] sparc: fix unknown type name u_int in uapi header Masahiro Yamada
@ 2019-06-13 21:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-13 21:13 UTC (permalink / raw)
To: yamada.masahiro; +Cc: sparclinux, linux-kernel
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Tue, 4 Jun 2019 17:23:14 +0900
> 'u_int' is a shorthand that is only available in the kernel space
> because it is defined in include/linux/types.h, which is not exported
> to the user space.
>
> You cannot use it in uapi headers even if you include <linux/types.h>
>
> Detected by compile-testing exported headers.
>
> ./usr/include/asm/openpromio.h:16:2: error: unknown type name ‘u_int’
> u_int oprom_size; /* Actual size of the oprom_array. */
> ^~~~~
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-13 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 8:23 [PATCH] sparc: fix unknown type name u_int in uapi header Masahiro Yamada
2019-06-13 21:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).