* [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 2:32 Hariprasad Kelam
2019-06-13 2:35 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:32 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter,
Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng, Anthony Koo,
Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun, Gloria Li,
amd-gfx, dri-devel, linux-kernel
this patch fixes below compilation error
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
function ‘dcn10_apply_ctx_for_surface’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
error: implicit declaration of function ‘udelay’
[-Werror=implicit-function-declaration]
udelay(underflow_check_delay_us);
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index d2352949..1ac9a4f 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -23,6 +23,7 @@
*
*/
+#include <linux/delay.h>
#include "dm_services.h"
#include "core_types.h"
#include "resource.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:32 [PATCH] drm/amd/display: fix compilation error Hariprasad Kelam
@ 2019-06-13 2:35 ` Alex Deucher
2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 18:42 ` Sam Ravnborg
0 siblings, 2 replies; 6+ messages in thread
From: Alex Deucher @ 2019-06-13 2:35 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter,
Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng, Anthony Koo,
Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun, Gloria Li,
amd-gfx list, Maling list - DRI developers, LKML
On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> this patch fixes below compilation error
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> function ‘dcn10_apply_ctx_for_surface’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> error: implicit declaration of function ‘udelay’
> [-Werror=implicit-function-declaration]
> udelay(underflow_check_delay_us);
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
What branch is this patch based on?
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index d2352949..1ac9a4f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -23,6 +23,7 @@
> *
> */
>
> +#include <linux/delay.h>
> #include "dm_services.h"
> #include "core_types.h"
> #include "resource.h"
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:35 ` Alex Deucher
@ 2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 8:23 ` Daniel Vetter
2019-06-13 18:42 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:48 UTC (permalink / raw)
To: Alex Deucher, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter, Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng,
Anthony Koo, Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun,
Gloria Li, amd-gfx, dri-devel, linux-kernel
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> What branch is this patch based on?
>
> Alex
Hi Alex,
It is on linux-next
Thanks,
Hariprasad k
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > index d2352949..1ac9a4f 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > @@ -23,6 +23,7 @@
> > *
> > */
> >
> > +#include <linux/delay.h>
> > #include "dm_services.h"
> > #include "core_types.h"
> > #include "resource.h"
> > --
> > 2.7.4
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:48 ` Hariprasad Kelam
@ 2019-06-13 8:23 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2019-06-13 8:23 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Alex Deucher, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter, Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng,
Anthony Koo, Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun,
Gloria Li, amd-gfx, dri-devel, linux-kernel
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote:
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> >
> > What branch is this patch based on?
> >
> > Alex
>
> Hi Alex,
>
> It is on linux-next
drm-misc-next has Sam's header cleanup. I guess we pull linux/delay.h in
implicitly somewhere, but not for all configs.
-Daniel
>
> Thanks,
> Hariprasad k
> > > ---
> > > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > index d2352949..1ac9a4f 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > @@ -23,6 +23,7 @@
> > > *
> > > */
> > >
> > > +#include <linux/delay.h>
> > > #include "dm_services.h"
> > > #include "core_types.h"
> > > #include "resource.h"
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:35 ` Alex Deucher
2019-06-13 2:48 ` Hariprasad Kelam
@ 2019-06-13 18:42 ` Sam Ravnborg
2019-06-13 18:52 ` Alex Deucher
1 sibling, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2019-06-13 18:42 UTC (permalink / raw)
To: Alex Deucher
Cc: Hariprasad Kelam, LKML, Yongqiang Sun, Charlene Liu, Leo Li,
Bhawanpreet Lakha, Gloria Li, amd-gfx list, Nicholas Kazlauskas,
David Airlie, Dmytro Laktyushkin, Tony Cheng,
Maling list - DRI developers, Alex Deucher, Christian König,
Anthony Koo
Hi Alex.
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Am I right in assuming you took this patch?
I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h
The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 18:42 ` Sam Ravnborg
@ 2019-06-13 18:52 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2019-06-13 18:52 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Hariprasad Kelam, LKML, Yongqiang Sun, Charlene Liu, Leo Li,
Bhawanpreet Lakha, Gloria Li, amd-gfx list, Nicholas Kazlauskas,
David Airlie, Dmytro Laktyushkin, Tony Cheng,
Maling list - DRI developers, Alex Deucher, Christian König,
Anthony Koo
On Thu, Jun 13, 2019 at 2:42 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Alex.
>
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> Am I right in assuming you took this patch?
>
> I expect that new code using udelay was added to the amd tree,
> and when merged with drm-misc-next it failed, because drm-misc-next no
> longer had drmP.h included so no implicit include of delay.h
>
> The root cause was that my original patchset should have been based
> on the amd tree, and applied there :-(
No worries. I've picked it up.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-13 18:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 2:32 [PATCH] drm/amd/display: fix compilation error Hariprasad Kelam
2019-06-13 2:35 ` Alex Deucher
2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 8:23 ` Daniel Vetter
2019-06-13 18:42 ` Sam Ravnborg
2019-06-13 18:52 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).