From: Vivien Didelot <vivien.didelot@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
f.fainelli@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH net-next 0/4] net: dsa: use switchdev attr and obj handlers
Date: Thu, 13 Jun 2019 13:28:17 -0400 [thread overview]
Message-ID: <20190613132817.GB22277@t480s.localdomain> (raw)
In-Reply-To: <20190611214747.22285-1-vivien.didelot@gmail.com>
Hi David,
On Tue, 11 Jun 2019 17:47:43 -0400, Vivien Didelot <vivien.didelot@gmail.com> wrote:
> This series reduces boilerplate in the handling of switchdev attribute and
> object operations by using the switchdev_handle_* helpers, which check the
> targeted devices and recurse into their lower devices.
>
> This also brings back the ability to inspect operations targeting the bridge
> device itself (where .orig_dev is the bridge device and .dev is the slave),
> even though that is of no use yet and skipped by this series.
>
> Vivien Didelot (4):
> net: dsa: do not check orig_dev in vlan del
> net: dsa: make cpu_dp non const
> net: dsa: make dsa_slave_dev_check use const
> net: dsa: use switchdev handle helpers
>
> include/net/dsa.h | 2 +-
> net/dsa/port.c | 9 ------
> net/dsa/slave.c | 81 ++++++++++++++++++++---------------------------
> 3 files changed, 36 insertions(+), 56 deletions(-)
Please do not merge. The orig_dev != dev test in patch 4 is not correct,
because it skips the programming of the HOST_MDB object. I'll respin in a few.
Thanks,
Vivien
prev parent reply other threads:[~2019-06-13 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:47 [PATCH net-next 0/4] net: dsa: use switchdev attr and obj handlers Vivien Didelot
2019-06-11 21:47 ` [PATCH net-next 1/4] net: dsa: do not check orig_dev in vlan del Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli
2019-06-11 21:47 ` [PATCH net-next 2/4] net: dsa: make cpu_dp non const Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli
2019-06-11 21:47 ` [PATCH net-next 3/4] net: dsa: make dsa_slave_dev_check use const Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli
2019-06-11 21:47 ` [PATCH net-next 4/4] net: dsa: use switchdev handle helpers Vivien Didelot
2019-06-11 23:10 ` Florian Fainelli
2019-06-13 17:28 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613132817.GB22277@t480s.localdomain \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).