From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
andrew@lunn.ch
Subject: Re: [PATCH net-next 1/4] net: dsa: do not check orig_dev in vlan del
Date: Tue, 11 Jun 2019 16:07:11 -0700 [thread overview]
Message-ID: <3d73efad-17ee-8ba7-5c1f-c35f6e95cade@gmail.com> (raw)
In-Reply-To: <20190611214747.22285-2-vivien.didelot@gmail.com>
On 6/11/19 2:47 PM, Vivien Didelot wrote:
> The current DSA code handling switchdev objects does not recurse into
> the lower devices thus is never called with an orig_dev member being
> a bridge device, hence remove this useless check.
>
> At the same time, remove the comments about the callers, which is
> unlikely to be updated if the code changes and thus confusing.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-06-11 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:47 [PATCH net-next 0/4] net: dsa: use switchdev attr and obj handlers Vivien Didelot
2019-06-11 21:47 ` [PATCH net-next 1/4] net: dsa: do not check orig_dev in vlan del Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli [this message]
2019-06-11 21:47 ` [PATCH net-next 2/4] net: dsa: make cpu_dp non const Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli
2019-06-11 21:47 ` [PATCH net-next 3/4] net: dsa: make dsa_slave_dev_check use const Vivien Didelot
2019-06-11 23:07 ` Florian Fainelli
2019-06-11 21:47 ` [PATCH net-next 4/4] net: dsa: use switchdev handle helpers Vivien Didelot
2019-06-11 23:10 ` Florian Fainelli
2019-06-13 17:28 ` [PATCH net-next 0/4] net: dsa: use switchdev attr and obj handlers Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d73efad-17ee-8ba7-5c1f-c35f6e95cade@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).