linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 5930/6350] drivers/net/ethernet/amazon/ena/ena_netdev.c:1158:6: sparse: sparse: symbol 'ena_adjust_intr_moderation' was not declared. Should it be static?
@ 2019-06-14  3:02 kbuild test robot
  2019-06-14  3:02 ` [RFC PATCH linux-next] net: ena: ena_adjust_intr_moderation() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-06-14  3:02 UTC (permalink / raw)
  To: Sameeh Jubran
  Cc: kbuild-all, Netanel Belgazal, Saeed Bishara, Zorik Machulsky,
	Arthur Kiyanovski, Eric Dumazet, netdev, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da151e650328dcd37176cf49fc626a7f42bfbe17
commit: c2b542044761965db0e4cc400ab6abf670fc25b7 [5930/6350] net: ena: remove inline keyword from functions in *.c
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout c2b542044761965db0e4cc400ab6abf670fc25b7
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/amazon/ena/ena_netdev.c:1158:6: sparse: sparse: symbol 'ena_adjust_intr_moderation' was not declared. Should it be static?
   drivers/net/ethernet/amazon/ena/ena_netdev.c:3428:59: sparse: sparse: Using plain integer as NULL pointer

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH linux-next] net: ena: ena_adjust_intr_moderation() can be static
  2019-06-14  3:02 [linux-next:master 5930/6350] drivers/net/ethernet/amazon/ena/ena_netdev.c:1158:6: sparse: sparse: symbol 'ena_adjust_intr_moderation' was not declared. Should it be static? kbuild test robot
@ 2019-06-14  3:02 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-06-14  3:02 UTC (permalink / raw)
  To: Sameeh Jubran
  Cc: kbuild-all, Netanel Belgazal, Saeed Bishara, Zorik Machulsky,
	Arthur Kiyanovski, Eric Dumazet, netdev, linux-kernel


Fixes: c2b542044761 ("net: ena: remove inline keyword from functions in *.c")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ena_netdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index b7865ee..b63ae9b 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1155,7 +1155,7 @@ static int ena_clean_rx_irq(struct ena_ring *rx_ring, struct napi_struct *napi,
 	return 0;
 }
 
-void ena_adjust_intr_moderation(struct ena_ring *rx_ring,
+static void ena_adjust_intr_moderation(struct ena_ring *rx_ring,
 				       struct ena_ring *tx_ring)
 {
 	/* We apply adaptive moderation on Rx path only.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-14  3:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14  3:02 [linux-next:master 5930/6350] drivers/net/ethernet/amazon/ena/ena_netdev.c:1158:6: sparse: sparse: symbol 'ena_adjust_intr_moderation' was not declared. Should it be static? kbuild test robot
2019-06-14  3:02 ` [RFC PATCH linux-next] net: ena: ena_adjust_intr_moderation() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).