linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: android: fix style problem
@ 2019-06-14 19:41 Saiyam Doshi
  2019-06-15 17:31 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Saiyam Doshi @ 2019-06-14 19:41 UTC (permalink / raw)
  To: gregkh; +Cc: dri-devel, linux-kernel, linaro-mm-sig

checkpatch reported "WARNING: line over 80 characters". This
patch fixes it by aligning function arguments.

Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
---
 drivers/staging/android/ion/ion_chunk_heap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
index 3cdde9c1a717..6aceab2e77e4 100644
--- a/drivers/staging/android/ion/ion_chunk_heap.c
+++ b/drivers/staging/android/ion/ion_chunk_heap.c
@@ -107,7 +107,9 @@ static struct ion_heap_ops chunk_heap_ops = {
 	.unmap_kernel = ion_heap_unmap_kernel,
 };
 
-struct ion_heap *ion_chunk_heap_create(phys_addr_t base, size_t size, size_t chunk_size)
+struct ion_heap *ion_chunk_heap_create(phys_addr_t base,
+				       size_t size,
+				       size_t chunk_size)
 {
 	struct ion_chunk_heap *chunk_heap;
 	int ret;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: android: fix style problem
  2019-06-14 19:41 [PATCH] staging: android: fix style problem Saiyam Doshi
@ 2019-06-15 17:31 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-06-15 17:31 UTC (permalink / raw)
  To: Saiyam Doshi; +Cc: dri-devel, linux-kernel, linaro-mm-sig

On Sat, Jun 15, 2019 at 01:11:56AM +0530, Saiyam Doshi wrote:
> checkpatch reported "WARNING: line over 80 characters". This
> patch fixes it by aligning function arguments.
> 
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
> ---
>  drivers/staging/android/ion/ion_chunk_heap.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
> index 3cdde9c1a717..6aceab2e77e4 100644
> --- a/drivers/staging/android/ion/ion_chunk_heap.c
> +++ b/drivers/staging/android/ion/ion_chunk_heap.c
> @@ -107,7 +107,9 @@ static struct ion_heap_ops chunk_heap_ops = {
>  	.unmap_kernel = ion_heap_unmap_kernel,
>  };
>  
> -struct ion_heap *ion_chunk_heap_create(phys_addr_t base, size_t size, size_t chunk_size)
> +struct ion_heap *ion_chunk_heap_create(phys_addr_t base,
> +				       size_t size,
> +				       size_t chunk_size)

Just break the line at "size_t size,", no need for 3 lines when 2 will
do.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-15 17:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 19:41 [PATCH] staging: android: fix style problem Saiyam Doshi
2019-06-15 17:31 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).