* [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc
@ 2019-06-18 15:15 Colin King
2019-06-18 19:02 ` Saeed Mahameed
2019-06-19 2:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-06-18 15:15 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, David S . Miller, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Function mlx5_devlink_alloc is missing a void argument, add it
to clean up the non-ANSI function declaration.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
index ed4202e883f0..1533c657220b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
@@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops = {
.flash_update = mlx5_devlink_flash_update,
};
-struct devlink *mlx5_devlink_alloc()
+struct devlink *mlx5_devlink_alloc(void)
{
return devlink_alloc(&mlx5_devlink_ops, sizeof(struct mlx5_core_dev));
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc
2019-06-18 15:15 [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc Colin King
@ 2019-06-18 19:02 ` Saeed Mahameed
2019-06-19 2:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2019-06-18 19:02 UTC (permalink / raw)
To: linux-rdma, colin.king, davem, leon, netdev; +Cc: kernel-janitors, linux-kernel
On Tue, 2019-06-18 at 16:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index ed4202e883f0..1533c657220b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops =
> {
> .flash_update = mlx5_devlink_flash_update,
> };
>
> -struct devlink *mlx5_devlink_alloc()
> +struct devlink *mlx5_devlink_alloc(void)
> {
> return devlink_alloc(&mlx5_devlink_ops, sizeof(struct
> mlx5_core_dev));
> }
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Dave, this one can go to net-next.
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc
2019-06-18 15:15 [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc Colin King
2019-06-18 19:02 ` Saeed Mahameed
@ 2019-06-19 2:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-19 2:30 UTC (permalink / raw)
To: colin.king
Cc: saeedm, leon, netdev, linux-rdma, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 18 Jun 2019 16:15:10 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-19 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 15:15 [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc Colin King
2019-06-18 19:02 ` Saeed Mahameed
2019-06-19 2:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).