linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: [PATCH] x86/microcode: Fix the microcode load on CPU hotplug for real
Date: Tue, 18 Jun 2019 22:34:16 +0200	[thread overview]
Message-ID: <20190618203348.GA16699@zn.tnic> (raw)
In-Reply-To: <alpine.DEB.2.21.1906182228350.1766@nanos.tec.linutronix.de>

On Tue, Jun 18, 2019 at 10:31:40PM +0200, Thomas Gleixner wrote:
> A recent change moved the microcode loader hotplug callback into the early
> startup phase, which is running with interrupts disabled. It missed that
> the callbacks invoke sysfs functions which might sleep causing nice 'might
> sleep' splats with proper debugging enabled.
> 
> Split the callbacks and only load the microcode in the early startup phase
> and move the sysfs handling back into the later threaded and preemptible
> bringup phase where it was before.
> 
> Fixes: 78f4e932f776 ("x86/microcode, cpuhotplug: Add a microcode loader CPU hotplug callback")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
> ---
>  arch/x86/kernel/cpu/microcode/core.c |   15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Acked-by: Borislav Petkov <bp@suse.de>

Thanks for fixing that!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2019-06-18 20:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 20:31 [PATCH] x86/microcode: Fix the microcode load on CPU hotplug for real Thomas Gleixner
2019-06-18 20:34 ` Borislav Petkov [this message]
2019-06-19  7:31 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2019-06-26 17:20 ` [PATCH] " Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618203348.GA16699@zn.tnic \
    --to=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).