From: Evan Green <evgreen@chromium.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/microcode: Fix the microcode load on CPU hotplug for real
Date: Wed, 26 Jun 2019 10:20:12 -0700 [thread overview]
Message-ID: <CAE=gft6=TPF9xYmVbzR2WQJ8LDQjPm_cZ17cyHaPrh-K9UCgHA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1906182228350.1766@nanos.tec.linutronix.de>
On Tue, Jun 18, 2019 at 1:31 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> A recent change moved the microcode loader hotplug callback into the early
> startup phase, which is running with interrupts disabled. It missed that
> the callbacks invoke sysfs functions which might sleep causing nice 'might
> sleep' splats with proper debugging enabled.
>
> Split the callbacks and only load the microcode in the early startup phase
> and move the sysfs handling back into the later threaded and preemptible
> bringup phase where it was before.
>
> Fixes: 78f4e932f776 ("x86/microcode, cpuhotplug: Add a microcode loader CPU hotplug callback")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
I ran into the bug fixed by this. For 4.19:
Tested-by: Evan Green <evgreen@chromium.org>
prev parent reply other threads:[~2019-06-26 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 20:31 [PATCH] x86/microcode: Fix the microcode load on CPU hotplug for real Thomas Gleixner
2019-06-18 20:34 ` Borislav Petkov
2019-06-19 7:31 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2019-06-26 17:20 ` Evan Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft6=TPF9xYmVbzR2WQJ8LDQjPm_cZ17cyHaPrh-K9UCgHA@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).