From: Tyler Hicks <tyhicks@canonical.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: viro@zeniv.linux.org.uk, agruenba@redhat.com,
linux-kernel@vger.kernel.org, ecryptfs@vger.kernel.org
Subject: Re: [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static
Date: Wed, 19 Jun 2019 01:33:08 -0500 [thread overview]
Message-ID: <20190619063307.GA22021@lindsey> (raw)
In-Reply-To: <20190614155117.28988-1-yuehaibing@huawei.com>
On 2019-06-14 23:51:17, YueHaibing wrote:
> Fix sparse warning:
>
> fs/ecryptfs/inode.c:1138:28: warning:
> symbol 'ecryptfs_xattr_handler' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the cleanup! I've pushed this to the eCryptfs next branch.
Tyler
> ---
> fs/ecryptfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index 1e994d7..18426f4 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -1121,7 +1121,7 @@ static int ecryptfs_xattr_set(const struct xattr_handler *handler,
> }
> }
>
> -const struct xattr_handler ecryptfs_xattr_handler = {
> +static const struct xattr_handler ecryptfs_xattr_handler = {
> .prefix = "", /* match anything */
> .get = ecryptfs_xattr_get,
> .set = ecryptfs_xattr_set,
> --
> 2.7.4
>
>
prev parent reply other threads:[~2019-06-19 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 15:51 [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static YueHaibing
2019-06-19 6:33 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619063307.GA22021@lindsey \
--to=tyhicks@canonical.com \
--cc=agruenba@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).