* [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static
@ 2019-06-14 15:51 YueHaibing
2019-06-19 6:33 ` Tyler Hicks
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-14 15:51 UTC (permalink / raw)
To: tyhicks, viro, agruenba; +Cc: linux-kernel, ecryptfs, YueHaibing
Fix sparse warning:
fs/ecryptfs/inode.c:1138:28: warning:
symbol 'ecryptfs_xattr_handler' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/ecryptfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 1e994d7..18426f4 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -1121,7 +1121,7 @@ static int ecryptfs_xattr_set(const struct xattr_handler *handler,
}
}
-const struct xattr_handler ecryptfs_xattr_handler = {
+static const struct xattr_handler ecryptfs_xattr_handler = {
.prefix = "", /* match anything */
.get = ecryptfs_xattr_get,
.set = ecryptfs_xattr_set,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static
2019-06-14 15:51 [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static YueHaibing
@ 2019-06-19 6:33 ` Tyler Hicks
0 siblings, 0 replies; 2+ messages in thread
From: Tyler Hicks @ 2019-06-19 6:33 UTC (permalink / raw)
To: YueHaibing; +Cc: viro, agruenba, linux-kernel, ecryptfs
On 2019-06-14 23:51:17, YueHaibing wrote:
> Fix sparse warning:
>
> fs/ecryptfs/inode.c:1138:28: warning:
> symbol 'ecryptfs_xattr_handler' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the cleanup! I've pushed this to the eCryptfs next branch.
Tyler
> ---
> fs/ecryptfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index 1e994d7..18426f4 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -1121,7 +1121,7 @@ static int ecryptfs_xattr_set(const struct xattr_handler *handler,
> }
> }
>
> -const struct xattr_handler ecryptfs_xattr_handler = {
> +static const struct xattr_handler ecryptfs_xattr_handler = {
> .prefix = "", /* match anything */
> .get = ecryptfs_xattr_get,
> .set = ecryptfs_xattr_set,
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 15:51 [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static YueHaibing
2019-06-19 6:33 ` Tyler Hicks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).