* [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4
@ 2019-06-19 13:11 Arnd Bergmann
2019-06-19 14:54 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-06-19 13:11 UTC (permalink / raw)
To: Sekhar Nori
Cc: Arnd Bergmann, Bartosz Golaszewski, linux-arm-kernel, linux-kernel
When building a multiplatform kernel that includes armv4 support,
the default target CPU does not support the blx instruction,
which leads to a build failure:
arch/arm/mach-davinci/sleep.S: Assembler messages:
arch/arm/mach-davinci/sleep.S:56: Error: selected processor does not support `blx ip' in ARM mode
Add a .arch statement in the sources to make this file build.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-davinci/sleep.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/sleep.S b/arch/arm/mach-davinci/sleep.S
index 05d03f09ff54..71262dcdbca3 100644
--- a/arch/arm/mach-davinci/sleep.S
+++ b/arch/arm/mach-davinci/sleep.S
@@ -24,6 +24,7 @@
#define DEEPSLEEP_SLEEPENABLE_BIT BIT(31)
.text
+ .arch armv5te
/*
* Move DaVinci into deep sleep state
*
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4
2019-06-19 13:11 [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4 Arnd Bergmann
@ 2019-06-19 14:54 ` Sekhar Nori
0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2019-06-19 14:54 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Bartosz Golaszewski, linux-arm-kernel, linux-kernel
Hi Arnd,
On 19/06/19 6:41 PM, Arnd Bergmann wrote:
> When building a multiplatform kernel that includes armv4 support,
> the default target CPU does not support the blx instruction,
> which leads to a build failure:
>
> arch/arm/mach-davinci/sleep.S: Assembler messages:
> arch/arm/mach-davinci/sleep.S:56: Error: selected processor does not support `blx ip' in ARM mode
>
> Add a .arch statement in the sources to make this file build.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested on OMAP-L138 LCDK board with suspend-resume.
Assuming you will pick this directly:
Acked-by: Sekhar Nori <nsekhar@ti.com>
Regards,
Sekhar
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4
@ 2019-07-22 14:51 Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-07-22 14:51 UTC (permalink / raw)
To: soc, Sekhar Nori
Cc: Arnd Bergmann, Bartosz Golaszewski, linux-arm-kernel, linux-kernel
When building a multiplatform kernel that includes armv4 support,
the default target CPU does not support the blx instruction,
which leads to a build failure:
arch/arm/mach-davinci/sleep.S: Assembler messages:
arch/arm/mach-davinci/sleep.S:56: Error: selected processor does not support `blx ip' in ARM mode
Add a .arch statement in the sources to make this file build.
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I forgot to pick this up for arm-soc, sending again so it
ends up in the inbox
---
arch/arm/mach-davinci/sleep.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/sleep.S b/arch/arm/mach-davinci/sleep.S
index 05d03f09ff54..71262dcdbca3 100644
--- a/arch/arm/mach-davinci/sleep.S
+++ b/arch/arm/mach-davinci/sleep.S
@@ -24,6 +24,7 @@
#define DEEPSLEEP_SLEEPENABLE_BIT BIT(31)
.text
+ .arch armv5te
/*
* Move DaVinci into deep sleep state
*
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 13:11 [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4 Arnd Bergmann
2019-06-19 14:54 ` Sekhar Nori
2019-07-22 14:51 Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).