* [PATCH] FMC: fix 'passing zero to PTR_ERR()' warning
@ 2019-06-20 10:10 Ding Xiang
2019-06-20 14:28 ` Alessandro Rubini
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-06-20 10:10 UTC (permalink / raw)
To: rubini; +Cc: linux-kernel
Fix a static code checker warning:
drivers/fmc/fmc-debug.c:155
fmc_debug_init() warn: passing zero to 'PTR_ERR'
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/fmc/fmc-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 1734c7c..dd33951 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -152,7 +152,7 @@ int fmc_debug_init(struct fmc_device *fmc)
fmc->dbg_dir = debugfs_create_dir(dev_name(&fmc->dev), NULL);
if (IS_ERR_OR_NULL(fmc->dbg_dir)) {
pr_err("FMC: Cannot create debugfs\n");
- return PTR_ERR(fmc->dbg_dir);
+ return PTR_ERR_OR_ZERO(fmc->dbg_dir);
}
fmc->dbg_sdb_dump = debugfs_create_file(FMC_DBG_SDB_DUMP, 0444,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] FMC: fix 'passing zero to PTR_ERR()' warning
2019-06-20 10:10 [PATCH] FMC: fix 'passing zero to PTR_ERR()' warning Ding Xiang
@ 2019-06-20 14:28 ` Alessandro Rubini
0 siblings, 0 replies; 2+ messages in thread
From: Alessandro Rubini @ 2019-06-20 14:28 UTC (permalink / raw)
To: dingxiang; +Cc: linux-kernel
Hello.
drivers/fmc is going to be removed from the official kernel (removal
is queued by Linus Walleij, with approval by fmc authors).
So this patch should be dropped.
thanks
/alessandro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-20 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-20 10:10 [PATCH] FMC: fix 'passing zero to PTR_ERR()' warning Ding Xiang
2019-06-20 14:28 ` Alessandro Rubini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).