linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250
@ 2019-06-21 18:02 Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 2/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4 Krzysztof Kozlowski
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Add nodes for GPU (Mali 400) to Exynos3250.  This is still limited and
not tested:
1. No dynamic voltage and frequency scaling,
2. Not sure what to do with CLK_G3D clock responsible for gating entire
   IP block (it is now being disabled as unused).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Use samsung,exynos4210-mali compatible
2. Use CLK_G3D as bus clock (clock for entire IP block)
---
 arch/arm/boot/dts/exynos3250-artik5.dtsi |  5 ++++
 arch/arm/boot/dts/exynos3250-monk.dts    |  5 ++++
 arch/arm/boot/dts/exynos3250-rinato.dts  |  5 ++++
 arch/arm/boot/dts/exynos3250.dtsi        | 33 ++++++++++++++++++++++++
 4 files changed, 48 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index ace50e194a45..dee35e3a5c4b 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -59,6 +59,11 @@
 	cpu0-supply = <&buck2_reg>;
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &i2c_0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index e25765500e99..248bd372fe70 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -172,6 +172,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo15_reg>;
 	vusb_a-supply = <&ldo12_reg>;
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 7479993755da..86c26a4edfd7 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -244,6 +244,11 @@
 	};
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &i2c_0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 8ce3a7786b19..c17870a54acf 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -126,6 +126,39 @@
 		};
 	};
 
+	gpu: gpu@13000000 {
+		compatible = "samsung,exynos4210-mali", "arm,mali-400";
+		reg = <0x13000000 0x10000>;
+		interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "gp",
+				  "gpmmu",
+				  "pp0",
+				  "ppmmu0",
+				  "pp1",
+				  "ppmmu1",
+				  "pp2",
+				  "ppmmu2",
+				  "pp3",
+				  "ppmmu3",
+				  "pmu";
+		clocks = <&cmu CLK_G3D>,
+			 <&cmu CLK_SCLK_G3D>;
+		clock-names = "bus", "core";
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+		/* TODO: operating points for DVFS, assigned clock as 134 MHz */
+	};
+
 	pmu {
 		compatible = "arm,cortex-a7-pmu";
 		interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 2/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 3/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433 Krzysztof Kozlowski
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Add nodes for GPU (Mali 400) to Exynos4210 and Exynos4412.  Describe the
GPU as much as possible however still few elements are missing:
1. Exynos4210 bus clock is not described in hardware manual therefore
   the IP gate clock was provided,
2. Exynos4412: Not sure what to do with CLK_G3D clock responsible for
   gating entire IP block (it is now being disabled as unused),
3. Regulator supplies on Trats board.

Limited testing on Odroid U3 (Exynos4412).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Use samsung,exynos4210-mali compatible
2. Use CLK_G3D as bus clock (clock for entire IP block)
3. Remove some of operating points to match Mali in Tizen kernel.
   Previously they were taken from datasheet but this information is too
   generic.
4. Add 533 MHz opp to Exynos4412-prime.
---
 arch/arm/boot/dts/exynos4.dtsi                | 36 +++++++++++++++++++
 arch/arm/boot/dts/exynos4210-origen.dts       |  5 +++
 arch/arm/boot/dts/exynos4210-trats.dts        |  4 +++
 .../boot/dts/exynos4210-universal_c210.dts    |  5 +++
 arch/arm/boot/dts/exynos4210.dtsi             | 17 +++++++++
 .../boot/dts/exynos4412-itop-scp-core.dtsi    |  5 +++
 arch/arm/boot/dts/exynos4412-midas.dtsi       |  5 +++
 .../boot/dts/exynos4412-odroid-common.dtsi    |  5 +++
 arch/arm/boot/dts/exynos4412-prime.dtsi       |  7 ++++
 arch/arm/boot/dts/exynos4412.dtsi             | 25 +++++++++++++
 10 files changed, 114 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 36ccf227434d..ceaa169032c8 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -51,6 +51,42 @@
 		serial3 = &serial_3;
 	};
 
+	gpu: gpu@13000000 {
+		compatible = "samsung,exynos4210-mali", "arm,mali-400";
+		reg = <0x13000000 0x10000>;
+		interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "gp",
+				  "gpmmu",
+				  "pp0",
+				  "ppmmu0",
+				  "pp1",
+				  "ppmmu1",
+				  "pp2",
+				  "ppmmu2",
+				  "pp3",
+				  "ppmmu3",
+				  "pmu";
+		/*
+		 * CLK_G3D is not actually bus clock but a IP-level clock.
+		 * The bus clock is not described in hardware manual.
+		 */
+		clocks = <&clock CLK_G3D>,
+			 <&clock CLK_SCLK_G3D>;
+		clock-names = "bus", "core";
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+	};
+
 	pmu: pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupt-parent = <&combiner>;
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 36b1edea254a..0d1e1a9c2f6e 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -132,6 +132,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo3_reg>;
 	vusb_a-supply = <&ldo8_reg>;
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 6882480dbaf7..7c39dd1c4d3a 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -239,6 +239,10 @@
 	status = "okay";
 };
 
+&gpu {
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&vusb_reg>;
 	vusb_a-supply = <&vusbdac_reg>;
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index bf092e97e14f..82a8b5449978 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -262,6 +262,11 @@
 	};
 };
 
+&gpu {
+	mali-supply = <&buck2_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index ea0e043cd2b4..bf312ebed01f 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -449,6 +449,23 @@
 	samsung,lcd-wb;
 };
 
+&gpu {
+	operating-points-v2 = <&gpu_opp_table>;
+
+	gpu_opp_table: opp_table {
+		compatible = "operating-points-v2";
+
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <950000>;
+		};
+		opp-267000000 {
+			opp-hz = /bits/ 64 <267000000>;
+			opp-microvolt = <1050000>;
+		};
+	};
+};
+
 &mdma1 {
 	power-domains = <&pd_lcd0>;
 };
diff --git a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
index 0038465f38f1..462a5409b1de 100644
--- a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
+++ b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
@@ -115,6 +115,11 @@
 	cpu0-supply = <&buck2_reg>;
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo15_reg>;
 	vusb_a-supply = <&ldo12_reg>;
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
index 4c15cb616cdf..83be3a797411 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -453,6 +453,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 08d3a0a7b4eb..ea55f377d17c 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -229,6 +229,11 @@
 	assigned-clock-rates = <0>, <176000000>;
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/exynos4412-prime.dtsi b/arch/arm/boot/dts/exynos4412-prime.dtsi
index d83fbd4e434c..3731a225f779 100644
--- a/arch/arm/boot/dts/exynos4412-prime.dtsi
+++ b/arch/arm/boot/dts/exynos4412-prime.dtsi
@@ -38,3 +38,10 @@
 	cooling-device = <&cpu0 15 15>, <&cpu1 15 15>,
 			 <&cpu2 15 15>, <&cpu3 15 15>;
 };
+
+&gpu_opp_table {
+	opp-533000000 {
+		opp-hz = /bits/ 64 <533000000>;
+		opp-microvolt = <1075000>;
+	};
+};
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e5c041ec0756..fb53d96934cc 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -716,6 +716,31 @@
 	cpu-offset = <0x4000>;
 };
 
+&gpu {
+	operating-points-v2 = <&gpu_opp_table>;
+
+	gpu_opp_table: opp_table {
+		compatible = "operating-points-v2";
+
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <875000>;
+		};
+		opp-267000000 {
+			opp-hz = /bits/ 64 <267000000>;
+			opp-microvolt = <900000>;
+		};
+		opp-350000000 {
+			opp-hz = /bits/ 64 <350000000>;
+			opp-microvolt = <950000>;
+		};
+		opp-440000000 {
+			opp-hz = /bits/ 64 <440000000>;
+			opp-microvolt = <1025000>;
+		};
+	};
+};
+
 &hdmi {
 	compatible = "samsung,exynos4212-hdmi";
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 3/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 2/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4 Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 4/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7 Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Add nodes for GPU (Mali T760) to Exynos5433.  Missing element is the
cooling device.  Not tested on HW.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. None
---
 .../dts/exynos/exynos5433-tm2-common.dtsi     |  5 ++
 arch/arm64/boot/dts/exynos/exynos5433.dtsi    | 51 +++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index d2de16645e10..6f90b0e62cba 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -350,6 +350,11 @@
 	pinctrl-0 = <&te_irq>;
 };
 
+&gpu {
+	mali-supply = <&buck6_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index d29d13f4694f..a76f620f7f35 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -249,6 +249,57 @@
 		};
 	};
 
+	gpu: gpu@14ac0000 {
+		compatible = "samsung,exynos5433-mali", "arm,mali-t760";
+		reg = <0x14ac0000 0x5000>;
+		interrupts = <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "job", "mmu", "gpu";
+		clocks = <&cmu_g3d CLK_ACLK_G3D>;
+		clock-names = "core";
+		power-domains = <&pd_g3d>;
+		operating-points-v2 = <&gpu_opp_table>;
+		status = "disabled";
+
+		gpu_opp_table: opp_table {
+			compatible = "operating-points-v2";
+
+			opp-160000000 {
+				opp-hz = /bits/ 64 <160000000>;
+				opp-microvolt = <1000000>;
+			};
+			opp-267000000 {
+				opp-hz = /bits/ 64 <267000000>;
+				opp-microvolt = <1000000>;
+			};
+			opp-350000000 {
+				opp-hz = /bits/ 64 <350000000>;
+				opp-microvolt = <1025000>;
+			};
+			opp-420000000 {
+				opp-hz = /bits/ 64 <420000000>;
+				opp-microvolt = <1025000>;
+			};
+			opp-500000000 {
+				opp-hz = /bits/ 64 <500000000>;
+				opp-microvolt = <1075000>;
+			};
+			opp-550000000 {
+				opp-hz = /bits/ 64 <550000000>;
+				opp-microvolt = <1125000>;
+			};
+			opp-600000000 {
+				opp-hz = /bits/ 64 <600000000>;
+				opp-microvolt = <1150000>;
+			};
+			opp-700000000 {
+				opp-hz = /bits/ 64 <700000000>;
+				opp-microvolt = <1150000>;
+			};
+		};
+	};
+
 	psci {
 		compatible = "arm,psci";
 		method = "smc";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 4/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 2/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4 Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 3/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433 Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 5/7] ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Add nodes for GPU (Mali T760) to Exynos7.  Current support for Exynos7
misses a lot, including proper clocks, power domains, frequency and
voltage scaling and cooling.  However this still can provide basic GPU
description.  Not tested on HW.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. None
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |  5 +++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi         | 11 +++++++++++
 2 files changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index 00dd89b92b42..080e0f56e108 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -59,6 +59,11 @@
 	clock-frequency = <24000000>;
 };
 
+&gpu {
+	mali-supply = <&buck6_reg>;
+	status = "okay";
+};
+
 &serial_2 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 077d23478901..bcb9d8cee267 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -78,6 +78,17 @@
 		};
 	};
 
+	gpu: gpu@14ac0000 {
+		compatible = "samsung,exynos5433-mali", "arm,mali-t760";
+		reg = <0x14ac0000 0x5000>;
+		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 242 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "job", "mmu", "gpu";
+		status = "disabled";
+		/* TODO: operating points for DVFS, cooling device */
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 5/7] ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2019-06-21 18:02 ` [PATCH v2 4/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7 Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 6/7] ARM: exynos_defconfig: " Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver Krzysztof Kozlowski
  5 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Enable support for Mali GPU with Panfrost and LIMA drivers.  Most of
Exynos chipsets come with Mali GPUs:
1. Mali 400 (Exynos3250, Exynos4210, Exynos4412),
2. Mali T628 (Exynos542x).

As Mali GPU is quite popular among ARM vendors, other platforms will
benefit as well.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/configs/multi_v7_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 6b748f214eae..268161911fc9 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -656,6 +656,8 @@ CONFIG_DRM_VC4=m
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_MXSFB=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB_EFI=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y
@@ -940,7 +942,6 @@ CONFIG_ARCH_TEGRA_2x_SOC=y
 CONFIG_ARCH_TEGRA_3x_SOC=y
 CONFIG_ARCH_TEGRA_114_SOC=y
 CONFIG_ARCH_TEGRA_124_SOC=y
-CONFIG_PM_DEVFREQ=y
 CONFIG_ARM_TEGRA_DEVFREQ=m
 CONFIG_TI_AEMIF=y
 CONFIG_IIO=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 6/7] ARM: exynos_defconfig: Enable Panfrost and LIMA drivers
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2019-06-21 18:02 ` [PATCH v2 5/7] ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 18:02 ` [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver Krzysztof Kozlowski
  5 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Enable support for Mali GPU with Panfrost and LIMA drivers.  Most of
Exynos chipsets come with Mali GPUs:
1. Mali 400 (Exynos3250, Exynos4210, Exynos4412),
2. Mali T628 (Exynos542x).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/configs/exynos_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 8d08eed99aa1..f140532ddca7 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -212,6 +212,8 @@ CONFIG_DRM_NXP_PTN3460=y
 CONFIG_DRM_PARADE_PS8622=y
 CONFIG_DRM_SII9234=y
 CONFIG_DRM_TOSHIBA_TC358764=y
+CONFIG_DRM_LIMA=y
+CONFIG_DRM_PANFROST=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_LCD_PLATFORM=y
 CONFIG_BACKLIGHT_PWM=y
@@ -284,7 +286,6 @@ CONFIG_CROS_EC_SPI=y
 CONFIG_COMMON_CLK_MAX77686=y
 CONFIG_COMMON_CLK_S2MPS11=y
 CONFIG_EXYNOS_IOMMU=y
-CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
 CONFIG_DEVFREQ_GOV_POWERSAVE=y
 CONFIG_DEVFREQ_GOV_USERSPACE=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver
  2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
                   ` (4 preceding siblings ...)
  2019-06-21 18:02 ` [PATCH v2 6/7] ARM: exynos_defconfig: " Krzysztof Kozlowski
@ 2019-06-21 18:02 ` Krzysztof Kozlowski
  2019-06-21 20:15   ` Vasily Khoruzhick
  2019-06-22 19:18   ` [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers Krzysztof Kozlowski
  5 siblings, 2 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-21 18:02 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
	Catalin Marinas, Will Deacon, Marek Szyprowski, Chanwoo Choi,
	Olof Johansson, Arnd Bergmann, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Joseph Kogut, Bartlomiej Zolnierkiewicz, Inki Dae

Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433
and Exynos7 (having Mali T760).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 6b4f5cf23324..972b17239f13 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -717,7 +718,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver
  2019-06-21 18:02 ` [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver Krzysztof Kozlowski
@ 2019-06-21 20:15   ` Vasily Khoruzhick
  2019-06-22  8:39     ` Krzysztof Kozlowski
  2019-06-22 19:18   ` [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers Krzysztof Kozlowski
  1 sibling, 1 reply; 14+ messages in thread
From: Vasily Khoruzhick @ 2019-06-21 20:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Mark Rutland, Kukjin Kim, Catalin Marinas,
	Will Deacon, Marek Szyprowski, Chanwoo Choi, Olof Johansson,
	Arnd Bergmann, devicetree, arm-linux, linux-samsung-soc,
	linux-kernel, Joseph Kogut, Inki Dae, Bartlomiej Zolnierkiewicz

On Fri, Jun 21, 2019 at 11:04 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433
> and Exynos7 (having Mali T760).
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/configs/defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 6b4f5cf23324..972b17239f13 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
>  CONFIG_DRM_HISI_KIRIN=m
>  CONFIG_DRM_MESON=m
>  CONFIG_DRM_PL111=m
> +CONFIG_DRM_PANFROST=m

It makes sense to enable lima for arm64 defconfig as well since it's
used on number of 64-bit Allwinner SoCs.

>  CONFIG_FB=y
>  CONFIG_FB_MODE_HELPERS=y
>  CONFIG_BACKLIGHT_GENERIC=m
> @@ -717,7 +718,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
>  CONFIG_ARCH_K3_AM6_SOC=y
>  CONFIG_SOC_TI=y
>  CONFIG_TI_SCI_PM_DOMAINS=y
> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
>  CONFIG_EXTCON_USB_GPIO=y
>  CONFIG_EXTCON_USBC_CROS_EC=y
>  CONFIG_MEMORY=y
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver
  2019-06-21 20:15   ` Vasily Khoruzhick
@ 2019-06-22  8:39     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-22  8:39 UTC (permalink / raw)
  To: Vasily Khoruzhick
  Cc: Rob Herring, Mark Rutland, Kukjin Kim, Catalin Marinas,
	Will Deacon, Marek Szyprowski, Chanwoo Choi, Olof Johansson,
	Arnd Bergmann, devicetree, arm-linux, linux-samsung-soc,
	linux-kernel, Joseph Kogut, Inki Dae, Bartlomiej Zolnierkiewicz

On Fri, 21 Jun 2019 at 22:15, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>
> On Fri, Jun 21, 2019 at 11:04 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433
> > and Exynos7 (having Mali T760).
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  arch/arm64/configs/defconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 6b4f5cf23324..972b17239f13 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
> >  CONFIG_DRM_HISI_KIRIN=m
> >  CONFIG_DRM_MESON=m
> >  CONFIG_DRM_PL111=m
> > +CONFIG_DRM_PANFROST=m
>
> It makes sense to enable lima for arm64 defconfig as well since it's
> used on number of 64-bit Allwinner SoCs.

I wasn't aware that some of ARMv8 SoCs still use Utgard. In such case
it makes sense indeed, I will send a follow up.

Thanks for feedback!

Krzysztof

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
  2019-06-21 18:02 ` [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver Krzysztof Kozlowski
  2019-06-21 20:15   ` Vasily Khoruzhick
@ 2019-06-22 19:18   ` Krzysztof Kozlowski
  2019-06-23  4:30     ` Chanwoo Choi
  1 sibling, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-22 19:18 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Shawn Guo, Maxime Ripard,
	Olof Johansson, Jagan Teki, Simon Horman, Leonard Crestez,
	Bjorn Andersson, Dinh Nguyen, Enric Balletbo i Serra,
	linux-arm-kernel, linux-kernel
  Cc: Vasily Khoruzhick, Marek Szyprowski, Chanwoo Choi,
	linux-samsung-soc, Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Enable Lima driver
---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index fbbc065415d4..3d31611368af 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
  2019-06-22 19:18   ` [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers Krzysztof Kozlowski
@ 2019-06-23  4:30     ` Chanwoo Choi
  2019-06-23 19:16       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 14+ messages in thread
From: Chanwoo Choi @ 2019-06-23  4:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Catalin Marinas, Will Deacon, Shawn Guo, Maxime Ripard,
	Olof Johansson, Jagan Teki, Simon Horman, Leonard Crestez,
	Bjorn Andersson, Dinh Nguyen, Enric Balletbo i Serra,
	linux-arm-kernel, linux-kernel, Vasily Khoruzhick,
	Marek Szyprowski, Chanwoo Choi, linux-samsung-soc

Hi Krzysztof,

2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <krzk@kernel.org>님이 작성:
>
> Enable support for Mali GPU with Panfrost and Lima drivers for:
> 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
> 2. Allwiner A64 and H5 (Mali 400/450).
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Enable Lima driver
> ---
>  arch/arm64/configs/defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index fbbc065415d4..3d31611368af 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
>  CONFIG_DRM_HISI_KIRIN=m
>  CONFIG_DRM_MESON=m
>  CONFIG_DRM_PL111=m
> +CONFIG_DRM_LIMA=m
> +CONFIG_DRM_PANFROST=m
>  CONFIG_FB=y
>  CONFIG_FB_MODE_HELPERS=y
>  CONFIG_BACKLIGHT_GENERIC=m
> @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
>  CONFIG_ARCH_K3_AM6_SOC=y
>  CONFIG_SOC_TI=y
>  CONFIG_TI_SCI_PM_DOMAINS=y
> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y

Exynos5433-tm2 board support the exynos-bus device which
used the simple_ondmenad governor of devfreq.
Why do you remove this configuration from the defconfig?

>  CONFIG_EXTCON_USB_GPIO=y
>  CONFIG_EXTCON_USBC_CROS_EC=y
>  CONFIG_MEMORY=y
> --
> 2.17.1
>


-- 
Best Regards,
Chanwoo Choi

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
  2019-06-23  4:30     ` Chanwoo Choi
@ 2019-06-23 19:16       ` Krzysztof Kozlowski
  2019-06-23 23:39         ` Chanwoo Choi
  0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-23 19:16 UTC (permalink / raw)
  To: cwchoi00
  Cc: Catalin Marinas, Will Deacon, Shawn Guo, Maxime Ripard,
	Olof Johansson, Jagan Teki, Simon Horman, Leonard Crestez,
	Bjorn Andersson, Dinh Nguyen, Enric Balletbo i Serra,
	linux-arm-kernel, linux-kernel, Vasily Khoruzhick,
	Marek Szyprowski, Chanwoo Choi, linux-samsung-soc

On Sun, 23 Jun 2019 at 06:31, Chanwoo Choi <cwchoi00@gmail.com> wrote:
>
> Hi Krzysztof,
>
> 2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <krzk@kernel.org>님이 작성:
> >
> > Enable support for Mali GPU with Panfrost and Lima drivers for:
> > 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
> > 2. Allwiner A64 and H5 (Mali 400/450).
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Enable Lima driver
> > ---
> >  arch/arm64/configs/defconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index fbbc065415d4..3d31611368af 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
> >  CONFIG_DRM_HISI_KIRIN=m
> >  CONFIG_DRM_MESON=m
> >  CONFIG_DRM_PL111=m
> > +CONFIG_DRM_LIMA=m
> > +CONFIG_DRM_PANFROST=m
> >  CONFIG_FB=y
> >  CONFIG_FB_MODE_HELPERS=y
> >  CONFIG_BACKLIGHT_GENERIC=m
> > @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
> >  CONFIG_ARCH_K3_AM6_SOC=y
> >  CONFIG_SOC_TI=y
> >  CONFIG_TI_SCI_PM_DOMAINS=y
> > -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
>
> Exynos5433-tm2 board support the exynos-bus device which
> used the simple_ondmenad governor of devfreq.
> Why do you remove this configuration from the defconfig?

It is selected by default by DRM_PANFROST. The difference is that
PANFROST selects it as module. The 'y' is chosen because of:
  SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
  2019-06-23 19:16       ` Krzysztof Kozlowski
@ 2019-06-23 23:39         ` Chanwoo Choi
  2019-06-24  6:56           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 14+ messages in thread
From: Chanwoo Choi @ 2019-06-23 23:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski, cwchoi00
  Cc: Catalin Marinas, Will Deacon, Shawn Guo, Maxime Ripard,
	Olof Johansson, Jagan Teki, Simon Horman, Leonard Crestez,
	Bjorn Andersson, Dinh Nguyen, Enric Balletbo i Serra,
	linux-arm-kernel, linux-kernel, Vasily Khoruzhick,
	Marek Szyprowski, linux-samsung-soc

On 19. 6. 24. 오전 4:16, Krzysztof Kozlowski wrote:
> On Sun, 23 Jun 2019 at 06:31, Chanwoo Choi <cwchoi00@gmail.com> wrote:
>>
>> Hi Krzysztof,
>>
>> 2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <krzk@kernel.org>님이 작성:
>>>
>>> Enable support for Mali GPU with Panfrost and Lima drivers for:
>>> 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
>>> 2. Allwiner A64 and H5 (Mali 400/450).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Enable Lima driver
>>> ---
>>>  arch/arm64/configs/defconfig | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index fbbc065415d4..3d31611368af 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
>>>  CONFIG_DRM_HISI_KIRIN=m
>>>  CONFIG_DRM_MESON=m
>>>  CONFIG_DRM_PL111=m
>>> +CONFIG_DRM_LIMA=m
>>> +CONFIG_DRM_PANFROST=m
>>>  CONFIG_FB=y
>>>  CONFIG_FB_MODE_HELPERS=y
>>>  CONFIG_BACKLIGHT_GENERIC=m
>>> @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
>>>  CONFIG_ARCH_K3_AM6_SOC=y
>>>  CONFIG_SOC_TI=y
>>>  CONFIG_TI_SCI_PM_DOMAINS=y
>>> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
>>
>> Exynos5433-tm2 board support the exynos-bus device which
>> used the simple_ondmenad governor of devfreq.
>> Why do you remove this configuration from the defconfig?
> 
> It is selected by default by DRM_PANFROST. The difference is that
> PANFROST selects it as module. The 'y' is chosen because of:
>   SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]

When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND 
for defconfig, the following patch[1] added this configuration.
[1] b972ff75f2938c39e2205c23ea0e531d36b27f86
- "arm64: defconfig: Enable UFS on msm8996"

I think that this patch will affect the opration of 'USF on msm8998'.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
  2019-06-23 23:39         ` Chanwoo Choi
@ 2019-06-24  6:56           ` Krzysztof Kozlowski
  0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-24  6:56 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: cwchoi00, Catalin Marinas, Will Deacon, Shawn Guo, Maxime Ripard,
	Olof Johansson, Jagan Teki, Simon Horman, Leonard Crestez,
	Bjorn Andersson, Dinh Nguyen, Enric Balletbo i Serra,
	linux-arm-kernel, linux-kernel, Vasily Khoruzhick,
	Marek Szyprowski, linux-samsung-soc

On Mon, 24 Jun 2019 at 01:36, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> On 19. 6. 24. 오전 4:16, Krzysztof Kozlowski wrote:
> > On Sun, 23 Jun 2019 at 06:31, Chanwoo Choi <cwchoi00@gmail.com> wrote:
> >>
> >> Hi Krzysztof,
> >>
> >> 2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <krzk@kernel.org>님이 작성:
> >>>
> >>> Enable support for Mali GPU with Panfrost and Lima drivers for:
> >>> 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
> >>> 2. Allwiner A64 and H5 (Mali 400/450).
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>>
> >>> ---
> >>>
> >>> Changes since v1:
> >>> 1. Enable Lima driver
> >>> ---
> >>>  arch/arm64/configs/defconfig | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index fbbc065415d4..3d31611368af 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
> >>>  CONFIG_DRM_HISI_KIRIN=m
> >>>  CONFIG_DRM_MESON=m
> >>>  CONFIG_DRM_PL111=m
> >>> +CONFIG_DRM_LIMA=m
> >>> +CONFIG_DRM_PANFROST=m
> >>>  CONFIG_FB=y
> >>>  CONFIG_FB_MODE_HELPERS=y
> >>>  CONFIG_BACKLIGHT_GENERIC=m
> >>> @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
> >>>  CONFIG_ARCH_K3_AM6_SOC=y
> >>>  CONFIG_SOC_TI=y
> >>>  CONFIG_TI_SCI_PM_DOMAINS=y
> >>> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
> >>
> >> Exynos5433-tm2 board support the exynos-bus device which
> >> used the simple_ondmenad governor of devfreq.
> >> Why do you remove this configuration from the defconfig?
> >
> > It is selected by default by DRM_PANFROST. The difference is that
> > PANFROST selects it as module. The 'y' is chosen because of:
> >   SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]
>
> When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND
> for defconfig, the following patch[1] added this configuration.
> [1] b972ff75f2938c39e2205c23ea0e531d36b27f86
> - "arm64: defconfig: Enable UFS on msm8996"
>
> I think that this patch will affect the opration of 'USF on msm8998'.

Hi Chanwoo,

Thanks for the feedback. Unfortunately I do not see how removing a
dependency will affect that SCSI_UFSHCD. The
DEVFREQ_GOV_SIMPLE_ONDEMAND is still built in, exactly the same as
before...

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-06-24  6:56 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 18:02 [PATCH v2 1/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250 Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 2/7] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4 Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 3/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433 Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 4/7] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7 Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 5/7] ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 6/7] ARM: exynos_defconfig: " Krzysztof Kozlowski
2019-06-21 18:02 ` [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver Krzysztof Kozlowski
2019-06-21 20:15   ` Vasily Khoruzhick
2019-06-22  8:39     ` Krzysztof Kozlowski
2019-06-22 19:18   ` [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers Krzysztof Kozlowski
2019-06-23  4:30     ` Chanwoo Choi
2019-06-23 19:16       ` Krzysztof Kozlowski
2019-06-23 23:39         ` Chanwoo Choi
2019-06-24  6:56           ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).