* [PATCH v8 2/5] usb: phy: Workaround for USB erratum-A005728
2019-06-24 7:22 [PATCH v8 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
@ 2019-06-24 7:22 ` Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918 Yinbo Zhu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Yinbo Zhu @ 2019-06-24 7:22 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: yinbo.zhu, xiaobo.xie, jiafei.pan, Ramneek Mehresh,
Nikhil Badola, Ran Wang, linux-usb, linux-kernel, Suresh Gupta
From: Suresh Gupta <B42813@freescale.com>
PHY_CLK_VALID bit for UTMI PHY in USBDR does not set even
if PHY is providing valid clock. Workaround for this
involves resetting of PHY and check PHY_CLK_VALID bit
multiple times. If PHY_CLK_VALID bit is still not set even
after 5 retries, it would be safe to deaclare that PHY
clock is not available.
This erratum is applicable for USBDR less then ver 2.4.
Signed-off-by: Suresh Gupta <B42813@freescale.com>
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
Change in v2:
replace Yinbo.Zhu with Yinbo Zhu.
Change in v3:
replace in_be32 with ioread32be.
Change in v4:
Incorrect indentation of the continuation line.
replace pr_err with dev_err.
Change in v5:
remove dev_err function unnecessary parameters.
drivers/usb/host/ehci-fsl.c | 37 ++++++++++++++++++++++++++-----------
drivers/usb/host/ehci-fsl.h | 3 +++
2 files changed, 29 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 38674b7aa51e..8f3bf3efb038 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -183,6 +183,17 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)
return retval;
}
+static bool usb_phy_clk_valid(struct usb_hcd *hcd)
+{
+ void __iomem *non_ehci = hcd->regs;
+ bool ret = true;
+
+ if (!(ioread32be(non_ehci + FSL_SOC_USB_CTRL) & PHY_CLK_VALID))
+ ret = false;
+
+ return ret;
+}
+
static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
enum fsl_usb2_phy_modes phy_mode,
unsigned int port_offset)
@@ -226,6 +237,16 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
/* fall through */
case FSL_USB2_PHY_UTMI:
case FSL_USB2_PHY_UTMI_DUAL:
+ /* PHY_CLK_VALID bit is de-featured from all controller
+ * versions below 2.4 and is to be checked only for
+ * internal UTMI phy
+ */
+ if (pdata->controller_ver > FSL_USB_VER_2_4 &&
+ pdata->have_sysif_regs && !usb_phy_clk_valid(hcd)) {
+ dev_err(dev, "USB PHY clock invalid\n");
+ return -EINVAL;
+ }
+
if (pdata->have_sysif_regs && pdata->controller_ver) {
/* controller version 1.6 or above */
tmp = ioread32be(non_ehci + FSL_SOC_USB_CTRL);
@@ -249,17 +270,11 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
break;
}
- /*
- * check PHY_CLK_VALID to determine phy clock presence before writing
- * to portsc
- */
- if (pdata->check_phy_clk_valid) {
- if (!(ioread32be(non_ehci + FSL_SOC_USB_CTRL) &
- PHY_CLK_VALID)) {
- dev_warn(hcd->self.controller,
- "USB PHY clock invalid\n");
- return -EINVAL;
- }
+ if (pdata->have_sysif_regs &&
+ pdata->controller_ver > FSL_USB_VER_1_6 &&
+ !usb_phy_clk_valid(hcd)) {
+ dev_warn(hcd->self.controller, "USB PHY clock invalid\n");
+ return -EINVAL;
}
ehci_writel(ehci, portsc, &ehci->regs->port_status[port_offset]);
diff --git a/drivers/usb/host/ehci-fsl.h b/drivers/usb/host/ehci-fsl.h
index cbc422032e50..9d18c6e6ab27 100644
--- a/drivers/usb/host/ehci-fsl.h
+++ b/drivers/usb/host/ehci-fsl.h
@@ -50,4 +50,7 @@
#define UTMI_PHY_EN (1<<9)
#define ULPI_PHY_CLK_SEL (1<<10)
#define PHY_CLK_VALID (1<<17)
+
+/* Retry count for checking UTMI PHY CLK validity */
+#define UTMI_PHY_CLK_VALID_CHK_RETRY 5
#endif /* _EHCI_FSL_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v8 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918
2019-06-24 7:22 [PATCH v8 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 2/5] usb: phy: Workaround for USB erratum-A005728 Yinbo Zhu
@ 2019-06-24 7:22 ` Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 4/5] usb: host: Stops USB controller init if PLL fails to lock Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 5/5] usb :fsl: Change string format for errata property Yinbo Zhu
3 siblings, 0 replies; 5+ messages in thread
From: Yinbo Zhu @ 2019-06-24 7:22 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: yinbo.zhu, xiaobo.xie, jiafei.pan, Ramneek Mehresh,
Nikhil Badola, Ran Wang, linux-usb, linux-kernel
This patch is to add member has_fsl_erratum_a006918 in platform data
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
include/linux/fsl_devices.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
index cb2b46f57af3..5d231ce8709b 100644
--- a/include/linux/fsl_devices.h
+++ b/include/linux/fsl_devices.h
@@ -98,6 +98,7 @@ struct fsl_usb2_platform_data {
unsigned has_fsl_erratum_14:1;
unsigned has_fsl_erratum_a005275:1;
unsigned has_fsl_erratum_a005697:1;
+ unsigned has_fsl_erratum_a006918:1;
unsigned check_phy_clk_valid:1;
/* register save area for suspend/resume */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v8 4/5] usb: host: Stops USB controller init if PLL fails to lock
2019-06-24 7:22 [PATCH v8 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 2/5] usb: phy: Workaround for USB erratum-A005728 Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918 Yinbo Zhu
@ 2019-06-24 7:22 ` Yinbo Zhu
2019-06-24 7:22 ` [PATCH v8 5/5] usb :fsl: Change string format for errata property Yinbo Zhu
3 siblings, 0 replies; 5+ messages in thread
From: Yinbo Zhu @ 2019-06-24 7:22 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: yinbo.zhu, xiaobo.xie, jiafei.pan, Ramneek Mehresh,
Nikhil Badola, Ran Wang, linux-usb, linux-kernel
From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
USB erratum-A006918 workaround tries to start internal PHY inside
uboot (when PLL fails to lock). However, if the workaround also
fails, then USB initialization is also stopped inside Linux.
Erratum-A006918 workaround failure creates "fsl,erratum_a006918"
node in device-tree. Presence of this node in device-tree is
used to stop USB controller initialization in Linux
Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
Change in v2:
replace Yinbo.Zhu with Yinbo Zhu.
Change in v5:
add the erratum commont replace "/* fall through */".
Change in v6:
remove "/* fall through */".
Change in v7:
keep v5 change.
Change in v8:
Add "/* fall through */" for case FSL_USB2_PHY_UTMIII.
drivers/usb/host/ehci-fsl.c | 9 +++++++++
drivers/usb/host/fsl-mph-dr-of.c | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 8f3bf3efb038..9e9c232e896f 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -236,6 +236,15 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
portsc |= PORT_PTS_PTW;
/* fall through */
case FSL_USB2_PHY_UTMI:
+ /* Presence of this node "has_fsl_erratum_a006918"
+ * in device-tree is used to stop USB controller
+ * initialization in Linux
+ */
+ if (pdata->has_fsl_erratum_a006918) {
+ dev_warn(dev, "USB PHY clock invalid\n");
+ return -EINVAL;
+ }
+ /* fall through */
case FSL_USB2_PHY_UTMI_DUAL:
/* PHY_CLK_VALID bit is de-featured from all controller
* versions below 2.4 and is to be checked only for
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 4f8b8a08c914..762b97600ab0 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -224,13 +224,14 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
of_property_read_bool(np, "fsl,usb-erratum-a005275");
pdata->has_fsl_erratum_a005697 =
of_property_read_bool(np, "fsl,usb_erratum-a005697");
+ pdata->has_fsl_erratum_a006918 =
+ of_property_read_bool(np, "fsl,usb_erratum-a006918");
if (of_get_property(np, "fsl,usb_erratum_14", NULL))
pdata->has_fsl_erratum_14 = 1;
else
pdata->has_fsl_erratum_14 = 0;
-
/*
* Determine whether phy_clk_valid needs to be checked
* by reading property in device tree
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v8 5/5] usb :fsl: Change string format for errata property
2019-06-24 7:22 [PATCH v8 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
` (2 preceding siblings ...)
2019-06-24 7:22 ` [PATCH v8 4/5] usb: host: Stops USB controller init if PLL fails to lock Yinbo Zhu
@ 2019-06-24 7:22 ` Yinbo Zhu
3 siblings, 0 replies; 5+ messages in thread
From: Yinbo Zhu @ 2019-06-24 7:22 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: yinbo.zhu, xiaobo.xie, jiafei.pan, Ramneek Mehresh,
Nikhil Badola, Ran Wang, linux-usb, linux-kernel
From: Nikhil Badola <nikhil.badola@freescale.com>
Remove USB errata checking code from driver. Applicability of erratum
is retrieved by reading corresponding property in device tree.
This property is written during device tree fixup.
Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
drivers/usb/host/fsl-mph-dr-of.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 762b97600ab0..ae8f60f6e6a5 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -226,11 +226,8 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
of_property_read_bool(np, "fsl,usb_erratum-a005697");
pdata->has_fsl_erratum_a006918 =
of_property_read_bool(np, "fsl,usb_erratum-a006918");
-
- if (of_get_property(np, "fsl,usb_erratum_14", NULL))
- pdata->has_fsl_erratum_14 = 1;
- else
- pdata->has_fsl_erratum_14 = 0;
+ pdata->has_fsl_erratum_14 =
+ of_property_read_bool(np, "fsl,usb_erratum-14");
/*
* Determine whether phy_clk_valid needs to be checked
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread