* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
[not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1>
@ 2019-06-24 6:59 ` MyungJoo Ham
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8>
2019-06-25 1:42 ` MyungJoo Ham
1 sibling, 1 reply; 9+ messages in thread
From: MyungJoo Ham @ 2019-06-24 6:59 UTC (permalink / raw)
To: digetx, janathanh, Chanwoo Choi; +Cc: linux-pm, linux-tegra, linux-kernel
> On Thu, May 02, 2019 at 02:38:12AM +0300, Dmitry Osipenko wrote:
> > The devfreq driver can be used on Tegra30 without any code change and
> > it works perfectly fine, the default Tegra124 parameters are good enough
> > for Tegra30.
> >
> > Reviewed-by: Chanwoo Choi
> > Signed-off-by: Dmitry Osipenko
> > ---
> > drivers/devfreq/Kconfig | 4 ++--
> > drivers/devfreq/tegra-devfreq.c | 1 +
> > 2 files changed, 3 insertions(+), 2 deletions(-)
>
> Acked-by: Thierry Reding
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 7dd46d4..b291803 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -93,8 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ
> This does not yet operate with optimal voltages.
>
> config ARM_TEGRA_DEVFREQ
> - tristate "Tegra DEVFREQ Driver"
> - depends on ARCH_TEGRA_124_SOC
> + tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
> + depends on ARCH_TEGRA
> select PM_OPP
> help
> This adds the DEVFREQ driver for the Tegra family of SoCs.
A question:
Does this driver support Tegra20 as well?
I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC
according to /drivers/soc/tegra/Kconfig.
Cheers,
MyungJoo.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
[not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1>
2019-06-24 6:59 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 MyungJoo Ham
@ 2019-06-25 1:42 ` MyungJoo Ham
2019-06-25 11:30 ` Dmitry Osipenko
1 sibling, 1 reply; 9+ messages in thread
From: MyungJoo Ham @ 2019-06-25 1:42 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh,
thierry.reding
Sender : Dmitry Osipenko <digetx@gmail.com>
>24.06.2019 14:11, MyungJoo Ham пишет:
>>>
>>> --------- Original Message ---------
>>> Sender : Dmitry Osipenko <digetx@gmail.com>
>>>
>>> 24.06.2019 10:34, MyungJoo Ham пишет:
>>>>>
>>>>> A question:
>>>>>
>>>>> Does this driver support Tegra20 as well?
>>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC
>>>>> according to /drivers/soc/tegra/Kconfig.
>>>>>
>>>>
>>>> For this matter, how about updating your 13/16 patch as follows?
>>>>
>> []
>>>
>>> Good call! I'll update this patch following yours suggestion, thanks.
>>
>> Or, you may approve the modified commits here:
>> https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next
>
>Looks almost good to me!
>
>I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence
>the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines
>for readability):
>
>diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>index ccb1a68c4b51..bd2efbc27725 100644
>--- a/drivers/devfreq/Kconfig
>+++ b/drivers/devfreq/Kconfig
>@@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
>
> config ARM_TEGRA_DEVFREQ
> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
>- depends on ARCH_TEGRA || COMPILE_TEST
>+ depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>+ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>+ ARCH_TEGRA_210_SOC || \
>+ COMPILE_TEST
> select PM_OPP
> help
> This adds the DEVFREQ driver for the Tegra family of SoCs.
>
>Could you please adjust the patches like I'm suggesting? I'll approve yours change
>then and won't re-spin the first batch of the patches.
I've adjusted as you suggested. It's pushed to the git repo as well.
Cheers,
MyungJoo.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
2019-06-25 1:42 ` MyungJoo Ham
@ 2019-06-25 11:30 ` Dmitry Osipenko
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Osipenko @ 2019-06-25 11:30 UTC (permalink / raw)
To: myungjoo.ham
Cc: Chanwoo Choi, linux-pm, linux-tegra, linux-kernel, jonathanh,
thierry.reding
25.06.2019 4:42, MyungJoo Ham пишет:
> Sender : Dmitry Osipenko <digetx@gmail.com>
>> 24.06.2019 14:11, MyungJoo Ham пишет:
>>>>
>>>> --------- Original Message ---------
>>>> Sender : Dmitry Osipenko <digetx@gmail.com>
>>>>
>>>> 24.06.2019 10:34, MyungJoo Ham пишет:
>>>>>>
>>>>>> A question:
>>>>>>
>>>>>> Does this driver support Tegra20 as well?
>>>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC
>>>>>> according to /drivers/soc/tegra/Kconfig.
>>>>>>
>>>>>
>>>>> For this matter, how about updating your 13/16 patch as follows?
>>>>>
>>> []
>>>>
>>>> Good call! I'll update this patch following yours suggestion, thanks.
>>>
>>> Or, you may approve the modified commits here:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/log/?h=for-next
>>
>> Looks almost good to me!
>>
>> I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence
>> the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines
>> for readability):
>>
>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>> index ccb1a68c4b51..bd2efbc27725 100644
>> --- a/drivers/devfreq/Kconfig
>> +++ b/drivers/devfreq/Kconfig
>> @@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
>>
>> config ARM_TEGRA_DEVFREQ
>> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
>> - depends on ARCH_TEGRA || COMPILE_TEST
>> + depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>> + ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>> + ARCH_TEGRA_210_SOC || \
>> + COMPILE_TEST
>> select PM_OPP
>> help
>> This adds the DEVFREQ driver for the Tegra family of SoCs.
>>
>> Could you please adjust the patches like I'm suggesting? I'll approve yours change
>> then and won't re-spin the first batch of the patches.
>
> I've adjusted as you suggested. It's pushed to the git repo as well.
Thank you very much, looking good now!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support
@ 2019-05-01 23:37 Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
0 siblings, 1 reply; 9+ messages in thread
From: Dmitry Osipenko @ 2019-05-01 23:37 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park,
Chanwoo Choi, Tomeu Vizoso
Cc: linux-pm, linux-tegra, linux-kernel
Changelog:
v4: Addressed all review comments that were made by Chanwoo Choi to v3:
- changed the driver removal order to match the probe exactly
- added clarifying comment for 1/8 ratio to the Tegra20 driver
Chanwoo, please also note that the clk patch that should fix
compilation problem that was reported the kbuild-test-robot is already
applied and available in the recent linux-next.
v3: Addressed all review comments that were made by Chanwoo Choi to v2.
Patch "Synchronize IRQ after masking it in hardware" morphed into
"Properly disable interrupts", which disables interrupts more solidly.
Added new minor patch: "Rename tegra-devfreq.c to tegra30-devfreq.c".
Added missed error handlings for dev_pm_opp_add().
v2: The patchset was quite heavily reworked since v1, few patches we
dropped or squashed into the new ones and more patches we added.
In a result more bugs and potential problems are fixed now, driver's
code got more clean up.
The Tegra20 driver-addition patch is now a part of this series, it has
no changes since v1.
Dmitry Osipenko (16):
PM / devfreq: tegra: Fix kHz to Hz conversion
PM / devfreq: tegra: Replace readl-writel with relaxed versions
PM / devfreq: tegra: Replace write memory barrier with the read
barrier
PM / devfreq: tegra: Don't ignore clk errors
PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe
PM / devfreq: tegra: Drop primary interrupt handler
PM / devfreq: tegra: Properly disable interrupts
PM / devfreq: tegra: Clean up driver's probe / remove
PM / devfreq: tegra: Avoid inconsistency of current frequency value
PM / devfreq: tegra: Mark ACTMON's governor as immutable
PM / devfreq: tegra: Move governor registration to driver's probe
PM / devfreq: tegra: Reconfigure hardware on governor's restart
PM / devfreq: tegra: Support Tegra30
PM / devfreq: tegra: Enable COMPILE_TEST for the driver
PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c
PM / devfreq: Introduce driver for NVIDIA Tegra20
MAINTAINERS | 8 +
drivers/devfreq/Kconfig | 15 +-
drivers/devfreq/Makefile | 3 +-
drivers/devfreq/tegra20-devfreq.c | 212 ++++++++++++
.../{tegra-devfreq.c => tegra30-devfreq.c} | 315 ++++++++----------
5 files changed, 379 insertions(+), 174 deletions(-)
create mode 100644 drivers/devfreq/tegra20-devfreq.c
rename drivers/devfreq/{tegra-devfreq.c => tegra30-devfreq.c} (81%)
--
2.21.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
2019-05-01 23:37 [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support Dmitry Osipenko
@ 2019-05-01 23:38 ` Dmitry Osipenko
2019-06-04 11:18 ` Thierry Reding
0 siblings, 1 reply; 9+ messages in thread
From: Dmitry Osipenko @ 2019-05-01 23:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park,
Chanwoo Choi, Tomeu Vizoso
Cc: linux-pm, linux-tegra, linux-kernel
The devfreq driver can be used on Tegra30 without any code change and
it works perfectly fine, the default Tegra124 parameters are good enough
for Tegra30.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/devfreq/Kconfig | 4 ++--
drivers/devfreq/tegra-devfreq.c | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index a78dffe603c1..56db9dc05edb 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -92,8 +92,8 @@ config ARM_EXYNOS_BUS_DEVFREQ
This does not yet operate with optimal voltages.
config ARM_TEGRA_DEVFREQ
- tristate "Tegra DEVFREQ Driver"
- depends on ARCH_TEGRA_124_SOC
+ tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
+ depends on ARCH_TEGRA
select PM_OPP
help
This adds the DEVFREQ driver for the Tegra family of SoCs.
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index 2d9d53daedd8..dd0fbd2c8e04 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -738,6 +738,7 @@ static int tegra_devfreq_remove(struct platform_device *pdev)
}
static const struct of_device_id tegra_devfreq_of_match[] = {
+ { .compatible = "nvidia,tegra30-actmon" },
{ .compatible = "nvidia,tegra124-actmon" },
{ },
};
--
2.21.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
2019-05-01 23:38 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
@ 2019-06-04 11:18 ` Thierry Reding
0 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2019-06-04 11:18 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Tomeu Vizoso, linux-pm, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Thu, May 02, 2019 at 02:38:12AM +0300, Dmitry Osipenko wrote:
> The devfreq driver can be used on Tegra30 without any code change and
> it works perfectly fine, the default Tegra124 parameters are good enough
> for Tegra30.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/Kconfig | 4 ++--
> drivers/devfreq/tegra-devfreq.c | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-25 11:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p1>
2019-06-24 6:59 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 MyungJoo Ham
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p8>
2019-06-24 7:34 ` MyungJoo Ham
2019-06-24 10:42 ` Dmitry Osipenko
[not found] ` <CGME20190624065919epcms1p1a366de5f455f5138c438d1da8151c12f@epcms1p3>
2019-06-24 11:11 ` MyungJoo Ham
2019-06-24 11:24 ` Dmitry Osipenko
2019-06-25 1:42 ` MyungJoo Ham
2019-06-25 11:30 ` Dmitry Osipenko
2019-05-01 23:37 [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
2019-06-04 11:18 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).