* [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT
@ 2019-06-24 16:09 Marcos Paulo de Souza
2019-07-02 22:55 ` Marcos Paulo de Souza
0 siblings, 1 reply; 3+ messages in thread
From: Marcos Paulo de Souza @ 2019-06-24 16:09 UTC (permalink / raw)
To: linux-kernel
Cc: Marcos Paulo de Souza, Marcos Paulo de Souza, Josef Bacik,
Jens Axboe, open list:NETWORK BLOCK DEVICE (NBD),
open list:NETWORK BLOCK DEVICE (NBD)
set_capacity expects the disk size in sectors of 512 bytes, and changing
the magic number 9 to SECTOR_SHIFT clarifies this intent.
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 3a9bca3aa093..fd3bc061c600 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -288,7 +288,7 @@ static void nbd_size_update(struct nbd_device *nbd)
}
blk_queue_logical_block_size(nbd->disk->queue, config->blksize);
blk_queue_physical_block_size(nbd->disk->queue, config->blksize);
- set_capacity(nbd->disk, config->bytesize >> 9);
+ set_capacity(nbd->disk, config->bytesize >> SECTOR_SHIFT);
if (bdev) {
if (bdev->bd_disk) {
bd_set_size(bdev, config->bytesize);
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT
2019-06-24 16:09 [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT Marcos Paulo de Souza
@ 2019-07-02 22:55 ` Marcos Paulo de Souza
2019-07-14 4:09 ` Marcos Paulo de Souza
0 siblings, 1 reply; 3+ messages in thread
From: Marcos Paulo de Souza @ 2019-07-02 22:55 UTC (permalink / raw)
To: linux-kernel
Cc: Marcos Paulo de Souza, Josef Bacik, Jens Axboe,
open list:NETWORK BLOCK DEVICE (NBD),
open list:NETWORK BLOCK DEVICE (NBD),
marcos.souza.org
ping?
On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> set_capacity expects the disk size in sectors of 512 bytes, and changing
> the magic number 9 to SECTOR_SHIFT clarifies this intent.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
> drivers/block/nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 3a9bca3aa093..fd3bc061c600 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -288,7 +288,7 @@ static void nbd_size_update(struct nbd_device *nbd)
> }
> blk_queue_logical_block_size(nbd->disk->queue, config->blksize);
> blk_queue_physical_block_size(nbd->disk->queue, config->blksize);
> - set_capacity(nbd->disk, config->bytesize >> 9);
> + set_capacity(nbd->disk, config->bytesize >> SECTOR_SHIFT);
> if (bdev) {
> if (bdev->bd_disk) {
> bd_set_size(bdev, config->bytesize);
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT
2019-07-02 22:55 ` Marcos Paulo de Souza
@ 2019-07-14 4:09 ` Marcos Paulo de Souza
0 siblings, 0 replies; 3+ messages in thread
From: Marcos Paulo de Souza @ 2019-07-14 4:09 UTC (permalink / raw)
To: linux-kernel
Cc: Marcos Paulo de Souza, Josef Bacik, Jens Axboe,
open list:NETWORK BLOCK DEVICE (NBD),
open list:NETWORK BLOCK DEVICE (NBD)
ping?
On Tue, Jul 02, 2019 at 07:55:21PM -0300, Marcos Paulo de Souza wrote:
> ping?
>
> On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> > set_capacity expects the disk size in sectors of 512 bytes, and changing
> > the magic number 9 to SECTOR_SHIFT clarifies this intent.
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> > ---
> > drivers/block/nbd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> > index 3a9bca3aa093..fd3bc061c600 100644
> > --- a/drivers/block/nbd.c
> > +++ b/drivers/block/nbd.c
> > @@ -288,7 +288,7 @@ static void nbd_size_update(struct nbd_device *nbd)
> > }
> > blk_queue_logical_block_size(nbd->disk->queue, config->blksize);
> > blk_queue_physical_block_size(nbd->disk->queue, config->blksize);
> > - set_capacity(nbd->disk, config->bytesize >> 9);
> > + set_capacity(nbd->disk, config->bytesize >> SECTOR_SHIFT);
> > if (bdev) {
> > if (bdev->bd_disk) {
> > bd_set_size(bdev, config->bytesize);
> > --
> > 2.21.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-14 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 16:09 [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT Marcos Paulo de Souza
2019-07-02 22:55 ` Marcos Paulo de Souza
2019-07-14 4:09 ` Marcos Paulo de Souza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).