* [PATCH] get_maintainer: Add --cc option @ 2019-06-24 13:03 Sebastian Andrzej Siewior 2019-06-24 13:33 ` Peter Zijlstra 0 siblings, 1 reply; 12+ messages in thread From: Sebastian Andrzej Siewior @ 2019-06-24 13:03 UTC (permalink / raw) To: linux-kernel; +Cc: Joe Perches, Peter Zijlstra, Sebastian Andrzej Siewior The --cc adds a Cc: prefix infront of the email address so it can be used by other Scripts directly instead of adding another wrapper for this. Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- scripts/get_maintainer.pl | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index c1c088ef1420e..7f812d23218e5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -46,6 +46,8 @@ my $output_multiline = 1; my $output_separator = ", "; my $output_roles = 0; my $output_rolestats = 1; +my $output_cc_prefix = 0; +my $cc_prefix = ""; my $output_section_maxlen = 50; my $scm = 0; my $tree = 1; @@ -252,6 +254,7 @@ if (!GetOptions( 'multiline!' => \$output_multiline, 'roles!' => \$output_roles, 'rolestats!' => \$output_rolestats, + 'cc!' => \$output_cc_prefix, 'separator=s' => \$output_separator, 'subsystem!' => \$subsystem, 'status!' => \$status, @@ -298,6 +301,10 @@ $output_multiline = 0 if ($output_separator ne ", "); $output_rolestats = 1 if ($interactive); $output_roles = 1 if ($output_rolestats); +if ($output_cc_prefix) { + $cc_prefix = "Cc: "; +} + if ($sections || $letters ne "") { $sections = 1; $email = 0; @@ -2462,9 +2469,9 @@ sub merge_email { my ($address, $role) = @$_; if (!$saw{$address}) { if ($output_roles) { - push(@lines, "$address ($role)"); + push(@lines, "$cc_prefix" . "$address ($role)"); } else { - push(@lines, $address); + push(@lines, "$cc_prefix" . "$address"); } $saw{$address} = 1; } -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] get_maintainer: Add --cc option 2019-06-24 13:03 [PATCH] get_maintainer: Add --cc option Sebastian Andrzej Siewior @ 2019-06-24 13:33 ` Peter Zijlstra 2019-06-24 14:27 ` Joe Perches 0 siblings, 1 reply; 12+ messages in thread From: Peter Zijlstra @ 2019-06-24 13:33 UTC (permalink / raw) To: Sebastian Andrzej Siewior; +Cc: linux-kernel, Joe Perches On Mon, Jun 24, 2019 at 03:03:23PM +0200, Sebastian Andrzej Siewior wrote: > The --cc adds a Cc: prefix infront of the email address so it can be > used by other Scripts directly instead of adding another wrapper for > this. Would it make sense to make '--cc' imply --no-roles --no-rolestats ? > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Thanks bigeasy! ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] get_maintainer: Add --cc option 2019-06-24 13:33 ` Peter Zijlstra @ 2019-06-24 14:27 ` Joe Perches 2019-06-24 20:25 ` Peter Zijlstra 2019-06-25 16:37 ` [PATCH v2] get_maintainer: Add --prefix option Sebastian Andrzej Siewior 0 siblings, 2 replies; 12+ messages in thread From: Joe Perches @ 2019-06-24 14:27 UTC (permalink / raw) To: Peter Zijlstra, Sebastian Andrzej Siewior; +Cc: linux-kernel On Mon, 2019-06-24 at 15:33 +0200, Peter Zijlstra wrote: > On Mon, Jun 24, 2019 at 03:03:23PM +0200, Sebastian Andrzej Siewior wrote: > > The --cc adds a Cc: prefix infront of the email address so it can be > > used by other Scripts directly instead of adding another wrapper for > > this. Not sure I like the "--cc" option naming. Maybe "--prefix [string]" to be a bit more generic. > Would it make sense to make '--cc' imply --no-roles --no-rolestats ? Maybe. It's also unlikely to be sensibly used with mailing lists so maybe --nol too. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] get_maintainer: Add --cc option 2019-06-24 14:27 ` Joe Perches @ 2019-06-24 20:25 ` Peter Zijlstra 2019-06-24 20:42 ` Joe Perches 2019-06-28 9:25 ` [PATCH] get_maintainer: Add ability to skip moderated mailing lists Joe Perches 2019-06-25 16:37 ` [PATCH v2] get_maintainer: Add --prefix option Sebastian Andrzej Siewior 1 sibling, 2 replies; 12+ messages in thread From: Peter Zijlstra @ 2019-06-24 20:25 UTC (permalink / raw) To: Joe Perches; +Cc: Sebastian Andrzej Siewior, linux-kernel On Mon, Jun 24, 2019 at 07:27:47AM -0700, Joe Perches wrote: > On Mon, 2019-06-24 at 15:33 +0200, Peter Zijlstra wrote: > > On Mon, Jun 24, 2019 at 03:03:23PM +0200, Sebastian Andrzej Siewior wrote: > > > The --cc adds a Cc: prefix infront of the email address so it can be > > > used by other Scripts directly instead of adding another wrapper for > > > this. > > Not sure I like the "--cc" option naming. > Maybe "--prefix [string]" to be a bit more generic. > > > Would it make sense to make '--cc' imply --no-roles --no-rolestats ? > > Maybe. > > It's also unlikely to be sensibly used with mailing > lists so maybe --nol too. Is there also an option to exclude moderated lists? --no-s doesn't seem to do that. I hate it when people cross-post to moderated lists, and this thing just made me do it :-( ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] get_maintainer: Add --cc option 2019-06-24 20:25 ` Peter Zijlstra @ 2019-06-24 20:42 ` Joe Perches 2019-06-25 7:45 ` Peter Zijlstra 2019-06-28 9:25 ` [PATCH] get_maintainer: Add ability to skip moderated mailing lists Joe Perches 1 sibling, 1 reply; 12+ messages in thread From: Joe Perches @ 2019-06-24 20:42 UTC (permalink / raw) To: Peter Zijlstra, Andrew Morton; +Cc: Sebastian Andrzej Siewior, linux-kernel On Mon, 2019-06-24 at 22:25 +0200, Peter Zijlstra wrote: > On Mon, Jun 24, 2019 at 07:27:47AM -0700, Joe Perches wrote: > > On Mon, 2019-06-24 at 15:33 +0200, Peter Zijlstra wrote: > > > On Mon, Jun 24, 2019 at 03:03:23PM +0200, Sebastian Andrzej Siewior wrote: > > > > The --cc adds a Cc: prefix infront of the email address so it can be > > > > used by other Scripts directly instead of adding another wrapper for > > > > this. > > > > Not sure I like the "--cc" option naming. > > Maybe "--prefix [string]" to be a bit more generic. > > > > > Would it make sense to make '--cc' imply --no-roles --no-rolestats ? > > > > Maybe. > > > > It's also unlikely to be sensibly used with mailing > > lists so maybe --nol too. > > Is there also an option to exclude moderated lists? Nope. Not yet ;) > --no-s doesn't seem to do that. I suppose a --nomoderated could work. (-m is already maintainers) > I hate it when people cross-post to moderated lists, and > this thing just made me do it :-( Maybe: --- scripts/get_maintainer.pl | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index c1c088ef1420..8c2fc22f3a11 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -27,6 +27,7 @@ my $email_usename = 1; my $email_maintainer = 1; my $email_reviewer = 1; my $email_list = 1; +my $email_moderated_list = 1; my $email_subscriber_list = 0; my $email_git_penguin_chiefs = 0; my $email_git = 0; @@ -248,6 +249,7 @@ if (!GetOptions( 'r!' => \$email_reviewer, 'n!' => \$email_usename, 'l!' => \$email_list, + 'moderated!' => \$email_moderated_list, 's!' => \$email_subscriber_list, 'multiline!' => \$output_multiline, 'roles!' => \$output_roles, @@ -1023,7 +1025,8 @@ MAINTAINER field selection options: --r => include reviewer(s) if any --n => include name 'Full Name <addr\@domain.tld>' --l => include list(s) if any - --s => include subscriber only list(s) if any + --moderated => include moderated lists(s) if any (default: true) + --s => include subscriber only list(s) if any (default: false) --remove-duplicates => minimize duplicate email names/addresses --roles => show roles (status:subsystem, git-signer, list, etc...) --rolestats => show roles and statistics (commits/total_commits, %) @@ -1313,11 +1316,14 @@ sub add_categories { } else { if ($email_list) { if (!$hash_list_to{lc($list_address)}) { - $hash_list_to{lc($list_address)} = 1; if ($list_additional =~ m/moderated/) { - push(@list_to, [$list_address, - "moderated list${list_role}"]); + if ($email_moderated_list) { + $hash_list_to{lc($list_address)} = 1; + push(@list_to, [$list_address, + "moderated list${list_role}"]); + } } else { + $hash_list_to{lc($list_address)} = 1; push(@list_to, [$list_address, "open list${list_role}"]); } ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] get_maintainer: Add --cc option 2019-06-24 20:42 ` Joe Perches @ 2019-06-25 7:45 ` Peter Zijlstra 0 siblings, 0 replies; 12+ messages in thread From: Peter Zijlstra @ 2019-06-25 7:45 UTC (permalink / raw) To: Joe Perches; +Cc: Andrew Morton, Sebastian Andrzej Siewior, linux-kernel On Mon, Jun 24, 2019 at 01:42:13PM -0700, Joe Perches wrote: > On Mon, 2019-06-24 at 22:25 +0200, Peter Zijlstra wrote: > > I hate it when people cross-post to moderated lists, and > > this thing just made me do it :-( > > Maybe: That seems to work, Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org> Thanks! > --- > scripts/get_maintainer.pl | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index c1c088ef1420..8c2fc22f3a11 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -27,6 +27,7 @@ my $email_usename = 1; > my $email_maintainer = 1; > my $email_reviewer = 1; > my $email_list = 1; > +my $email_moderated_list = 1; > my $email_subscriber_list = 0; > my $email_git_penguin_chiefs = 0; > my $email_git = 0; > @@ -248,6 +249,7 @@ if (!GetOptions( > 'r!' => \$email_reviewer, > 'n!' => \$email_usename, > 'l!' => \$email_list, > + 'moderated!' => \$email_moderated_list, > 's!' => \$email_subscriber_list, > 'multiline!' => \$output_multiline, > 'roles!' => \$output_roles, > @@ -1023,7 +1025,8 @@ MAINTAINER field selection options: > --r => include reviewer(s) if any > --n => include name 'Full Name <addr\@domain.tld>' > --l => include list(s) if any > - --s => include subscriber only list(s) if any > + --moderated => include moderated lists(s) if any (default: true) > + --s => include subscriber only list(s) if any (default: false) > --remove-duplicates => minimize duplicate email names/addresses > --roles => show roles (status:subsystem, git-signer, list, etc...) > --rolestats => show roles and statistics (commits/total_commits, %) > @@ -1313,11 +1316,14 @@ sub add_categories { > } else { > if ($email_list) { > if (!$hash_list_to{lc($list_address)}) { > - $hash_list_to{lc($list_address)} = 1; > if ($list_additional =~ m/moderated/) { > - push(@list_to, [$list_address, > - "moderated list${list_role}"]); > + if ($email_moderated_list) { > + $hash_list_to{lc($list_address)} = 1; > + push(@list_to, [$list_address, > + "moderated list${list_role}"]); > + } > } else { > + $hash_list_to{lc($list_address)} = 1; > push(@list_to, [$list_address, > "open list${list_role}"]); > } > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] get_maintainer: Add ability to skip moderated mailing lists 2019-06-24 20:25 ` Peter Zijlstra 2019-06-24 20:42 ` Joe Perches @ 2019-06-28 9:25 ` Joe Perches 1 sibling, 0 replies; 12+ messages in thread From: Joe Perches @ 2019-06-28 9:25 UTC (permalink / raw) To: Andrew Morton; +Cc: Peter Zijlstra, linux-kernel Add a command line switch --no-moderated to skip L: mailing lists marked with 'moderated'. Some people prefer not emailing moderated mailing lists as the moderation time can be indeterminate and some emails can be intentionally dropped by a moderator. This can cause fragmentation of email threads when some are subscribed to a moderated list but others are not and emails are dropped. Signed-off-by: Joe Perches <joe@perches.com> Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org> --- scripts/get_maintainer.pl | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index c1c088ef1420..8c2fc22f3a11 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -27,6 +27,7 @@ my $email_usename = 1; my $email_maintainer = 1; my $email_reviewer = 1; my $email_list = 1; +my $email_moderated_list = 1; my $email_subscriber_list = 0; my $email_git_penguin_chiefs = 0; my $email_git = 0; @@ -248,6 +249,7 @@ if (!GetOptions( 'r!' => \$email_reviewer, 'n!' => \$email_usename, 'l!' => \$email_list, + 'moderated!' => \$email_moderated_list, 's!' => \$email_subscriber_list, 'multiline!' => \$output_multiline, 'roles!' => \$output_roles, @@ -1023,7 +1025,8 @@ MAINTAINER field selection options: --r => include reviewer(s) if any --n => include name 'Full Name <addr\@domain.tld>' --l => include list(s) if any - --s => include subscriber only list(s) if any + --moderated => include moderated lists(s) if any (default: true) + --s => include subscriber only list(s) if any (default: false) --remove-duplicates => minimize duplicate email names/addresses --roles => show roles (status:subsystem, git-signer, list, etc...) --rolestats => show roles and statistics (commits/total_commits, %) @@ -1313,11 +1316,14 @@ sub add_categories { } else { if ($email_list) { if (!$hash_list_to{lc($list_address)}) { - $hash_list_to{lc($list_address)} = 1; if ($list_additional =~ m/moderated/) { - push(@list_to, [$list_address, - "moderated list${list_role}"]); + if ($email_moderated_list) { + $hash_list_to{lc($list_address)} = 1; + push(@list_to, [$list_address, + "moderated list${list_role}"]); + } } else { + $hash_list_to{lc($list_address)} = 1; push(@list_to, [$list_address, "open list${list_role}"]); } ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] get_maintainer: Add --prefix option 2019-06-24 14:27 ` Joe Perches 2019-06-24 20:25 ` Peter Zijlstra @ 2019-06-25 16:37 ` Sebastian Andrzej Siewior 2019-06-25 17:23 ` Joe Perches 1 sibling, 1 reply; 12+ messages in thread From: Sebastian Andrzej Siewior @ 2019-06-25 16:37 UTC (permalink / raw) To: Joe Perches; +Cc: Peter Zijlstra, linux-kernel The --prefix option adds a Cc: prefix by default infront of the email address so it can be used by other Scripts directly instead of adding another wrapper for this. The option takes an optional argument so "--prefix=Bcc: " is also valid. Since it is expected to be output an email address it implies "--no-roles --no-rolestats". Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- On 2019-06-24 07:27:47 [-0700], Joe Perches wrote: > On Mon, 2019-06-24 at 15:33 +0200, Peter Zijlstra wrote: > > Would it make sense to make '--cc' imply --no-roles --no-rolestats ? > > Maybe. > > It's also unlikely to be sensibly used with mailing > lists so maybe --nol too. I don't see a problem with lists but I think it would make sense to imply also "--nomoderated" once available. v1…v2: - use --prefix instead --cc with "Cc: " as the default argument if not specified - imply --no-roles --no-rolestats scripts/get_maintainer.pl | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index c1c088ef1420e..60da8444d6667 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -46,6 +46,8 @@ my $output_multiline = 1; my $output_separator = ", "; my $output_roles = 0; my $output_rolestats = 1; +my $output_prefix = undef; +my $cc_prefix = ""; my $output_section_maxlen = 50; my $scm = 0; my $tree = 1; @@ -252,6 +254,7 @@ if (!GetOptions( 'multiline!' => \$output_multiline, 'roles!' => \$output_roles, 'rolestats!' => \$output_rolestats, + 'prefix:s' => \$output_prefix, 'separator=s' => \$output_separator, 'subsystem!' => \$subsystem, 'status!' => \$status, @@ -298,6 +301,16 @@ $output_multiline = 0 if ($output_separator ne ", "); $output_rolestats = 1 if ($interactive); $output_roles = 1 if ($output_rolestats); +if (defined($output_prefix)) { + if ($output_prefix eq "") { + $cc_prefix = "Cc: "; + } else { + $cc_prefix = $output_prefix; + } + $output_rolestats = 0; + $output_roles = 0; +} + if ($sections || $letters ne "") { $sections = 1; $email = 0; @@ -1037,6 +1050,7 @@ version: $V --separator [, ] => separator for multiple entries on 1 line using --separator also sets --nomultiline if --separator is not [, ] --multiline => print 1 entry per line + --prefix => prints a prefix infront of the entry. CC: is default if not specified Other options: --pattern-depth => Number of pattern directory traversals (default: 0 (all)) @@ -2462,9 +2476,9 @@ sub merge_email { my ($address, $role) = @$_; if (!$saw{$address}) { if ($output_roles) { - push(@lines, "$address ($role)"); + push(@lines, "$cc_prefix" . "$address ($role)"); } else { - push(@lines, $address); + push(@lines, "$cc_prefix" . "$address"); } $saw{$address} = 1; } -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] get_maintainer: Add --prefix option 2019-06-25 16:37 ` [PATCH v2] get_maintainer: Add --prefix option Sebastian Andrzej Siewior @ 2019-06-25 17:23 ` Joe Perches 2019-06-26 9:36 ` Peter Zijlstra 0 siblings, 1 reply; 12+ messages in thread From: Joe Perches @ 2019-06-25 17:23 UTC (permalink / raw) To: Sebastian Andrzej Siewior; +Cc: Peter Zijlstra, linux-kernel On Tue, 2019-06-25 at 18:37 +0200, Sebastian Andrzej Siewior wrote: > The --prefix option adds a Cc: prefix by default infront of the email > address so it can be used by other Scripts directly instead of adding > another wrapper for this. > The option takes an optional argument so "--prefix=Bcc: " is also valid. > Since it is expected to be output an email address it implies > "--no-roles --no-rolestats". > > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > On 2019-06-24 07:27:47 [-0700], Joe Perches wrote: > > On Mon, 2019-06-24 at 15:33 +0200, Peter Zijlstra wrote: > > > Would it make sense to make '--cc' imply --no-roles --no-rolestats ? > > > > Maybe. > > > > It's also unlikely to be sensibly used with mailing > > lists so maybe --nol too. > > I don't see a problem with lists This isn't acceptable to me in its current form. The most likely use case for this is to add "CC: <foo>" entries to a commit description. I doubt anyone cares about the cc'd mailing lists in a commit description. I'd prefer that commit descriptions don't have "CC:" lines at all as it was really only useful for adding email address to a proposed patch and as commit information is actually pretty useless. There are now simple ways to make sure a patch submission is cc'd to appropriate parties. git send-email supports --cc-cmd > but I think it would make sense to > imply also "--nomoderated" once available. I do not believe that's true. I want to proposed patches to moderated lists and believe everyone really should too. I don't care if moderated lists send a "waiting for moderation" message as long as the list gets the proposed patch eventually. I think only Peter cares about those, to him, superfluous "being moderated" messages. > v1…v2: > - use --prefix instead --cc with "Cc: " as the default argument > if not specified > - imply --no-roles --no-rolestats > > scripts/get_maintainer.pl | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl [] > @@ -46,6 +46,8 @@ my $output_multiline = 1; > my $output_separator = ", "; > my $output_roles = 0; > my $output_rolestats = 1; > +my $output_prefix = undef; > +my $cc_prefix = ""; Not necessary > my $output_section_maxlen = 50; > my $scm = 0; > my $tree = 1; > @@ -252,6 +254,7 @@ if (!GetOptions( > 'multiline!' => \$output_multiline, > 'roles!' => \$output_roles, > 'rolestats!' => \$output_rolestats, > + 'prefix:s' => \$output_prefix, I'd prefer the user specify the prefix. > 'separator=s' => \$output_separator, > 'subsystem!' => \$subsystem, > 'status!' => \$status, > @@ -298,6 +301,16 @@ $output_multiline = 0 if ($output_separator ne ", "); > $output_rolestats = 1 if ($interactive); > $output_roles = 1 if ($output_rolestats); > > +if (defined($output_prefix)) { > + if ($output_prefix eq "") { > + $cc_prefix = "Cc: "; > + } else { > + $cc_prefix = $output_prefix; > + } > + $output_rolestats = 0; > + $output_roles = 0; I do not care for this. If a switch is specified on the command line, it should be followed. > +} > + > if ($sections || $letters ne "") { > $sections = 1; > $email = 0; > @@ -1037,6 +1050,7 @@ version: $V > --separator [, ] => separator for multiple entries on 1 line > using --separator also sets --nomultiline if --separator is not [, ] > --multiline => print 1 entry per line > + --prefix => prints a prefix infront of the entry. CC: is default if not specified infront isn't a word. > > Other options: > --pattern-depth => Number of pattern directory traversals (default: 0 (all)) > @@ -2462,9 +2476,9 @@ sub merge_email { > my ($address, $role) = @$_; > if (!$saw{$address}) { > if ($output_roles) { > - push(@lines, "$address ($role)"); > + push(@lines, "$cc_prefix" . "$address ($role)"); It should not be $cc_prefix either, but $output_prefix > } else { > - push(@lines, $address); > + push(@lines, "$cc_prefix" . "$address"); > } And this should become something like: if (!$saw($address)) { my $output_address = ""; $output_address .= "$output_prefix " if (defined $output_prefix); $output_address .= $address; $output_address .= " ($role)" if ($output_roles); push(@lines, $output_address); $saw{$address} = 1; } ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] get_maintainer: Add --prefix option 2019-06-25 17:23 ` Joe Perches @ 2019-06-26 9:36 ` Peter Zijlstra 2019-06-26 15:36 ` Joe Perches 0 siblings, 1 reply; 12+ messages in thread From: Peter Zijlstra @ 2019-06-26 9:36 UTC (permalink / raw) To: Joe Perches; +Cc: Sebastian Andrzej Siewior, linux-kernel On Tue, Jun 25, 2019 at 10:23:34AM -0700, Joe Perches wrote: > There are now simple ways to make sure a patch > submission is cc'd to appropriate parties. > > git send-email supports --cc-cmd That assumes one is using git; I'm not, git stinks. > I want to proposed patches to moderated lists > and believe everyone really should too. > > I don't care if moderated lists send a > "waiting for moderation" message as long as the > list gets the proposed patch eventually. > > I think only Peter cares about those, to him, > superfluous "being moderated" messages. I'm really not alone in that. Not only do you get those annoying messages, the people reading that list might get the discussion in fragments, because some people that reply are subscribed and do not require moderation while others do get caught in the moderation thing and then delayed. It also puts a burden on the moderator, do they allow the whole discussion or only part. What if they deem the thing off-topic and want to kill it, but then some of their whitelisted people do reply. Cross-posting to moderated lists has been considered bad form ever since I got on the interweb in the early 90s. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] get_maintainer: Add --prefix option 2019-06-26 9:36 ` Peter Zijlstra @ 2019-06-26 15:36 ` Joe Perches 2019-06-26 17:18 ` Peter Zijlstra 0 siblings, 1 reply; 12+ messages in thread From: Joe Perches @ 2019-06-26 15:36 UTC (permalink / raw) To: Peter Zijlstra; +Cc: Sebastian Andrzej Siewior, linux-kernel On Wed, 2019-06-26 at 11:36 +0200, Peter Zijlstra wrote: > On Tue, Jun 25, 2019 at 10:23:34AM -0700, Joe Perches wrote: [] > > I want to proposed patches to moderated lists > > and believe everyone really should too. > > > > I don't care if moderated lists send a > > "waiting for moderation" message as long as the > > list gets the proposed patch eventually. > > > > I think only Peter cares about those, to him, > > superfluous "being moderated" messages. > > I'm really not alone in that. Not only do you get those annoying > messages, the people reading that list might get the discussion in > fragments, because some people that reply are subscribed and do not > require moderation while others do get caught in the moderation thing > and then delayed. <shrug> email moderation time is up to any moderator. > It also puts a burden on the moderator, do they allow the whole > discussion or only part. What if they deem the thing off-topic and want > to kill it, but then some of their whitelisted people do reply. Please remember any moderated list entries originate here by using get_maintainers.pl for a proposed patch or discuss a particular subsystem. If a moderator of a list decides an email chain about a patch is somehow off-topic and does not forward the email, likely that moderated list should be removed from MAINTAINERS. Under what use case would you want to use get_maintainer and _not_ cc a particular mailing list? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] get_maintainer: Add --prefix option 2019-06-26 15:36 ` Joe Perches @ 2019-06-26 17:18 ` Peter Zijlstra 0 siblings, 0 replies; 12+ messages in thread From: Peter Zijlstra @ 2019-06-26 17:18 UTC (permalink / raw) To: Joe Perches; +Cc: Sebastian Andrzej Siewior, linux-kernel On Wed, Jun 26, 2019 at 08:36:33AM -0700, Joe Perches wrote: > On Wed, 2019-06-26 at 11:36 +0200, Peter Zijlstra wrote: > If a moderator of a list decides an email chain about a > patch is somehow off-topic and does not forward the email, > likely that moderated list should be removed from MAINTAINERS. I think I've seen kernel-hardening complain about this; and that's not even a moderated list I think. Yes, the patch touched one of 'their' files, but was mostly unrelated. I forgot the exact thread. > Under what use case would you want to use get_maintainer and > _not_ cc a particular mailing list? I'm basically going to never send anything to a moderated list, ever. It's what I've been doing for a long while, but I got lazy the other day because a patch I did was a wide spray all over the tree and I didn't want to manually compose the Cc list. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-06-28 9:25 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-06-24 13:03 [PATCH] get_maintainer: Add --cc option Sebastian Andrzej Siewior 2019-06-24 13:33 ` Peter Zijlstra 2019-06-24 14:27 ` Joe Perches 2019-06-24 20:25 ` Peter Zijlstra 2019-06-24 20:42 ` Joe Perches 2019-06-25 7:45 ` Peter Zijlstra 2019-06-28 9:25 ` [PATCH] get_maintainer: Add ability to skip moderated mailing lists Joe Perches 2019-06-25 16:37 ` [PATCH v2] get_maintainer: Add --prefix option Sebastian Andrzej Siewior 2019-06-25 17:23 ` Joe Perches 2019-06-26 9:36 ` Peter Zijlstra 2019-06-26 15:36 ` Joe Perches 2019-06-26 17:18 ` Peter Zijlstra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).