* [PATCH 4.4 0/1] 4.4.184-stable review
@ 2019-06-26 8:45 Greg Kroah-Hartman
2019-06-26 8:45 ` [PATCH 4.4 1/1] tcp: refine memory limit test in tcp_fragment() Greg Kroah-Hartman
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-26 8:45 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
ben.hutchings, lkft-triage, stable
This is the start of the stable review cycle for the 4.4.184 release.
There are 1 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linux 4.4.184-rc1
Eric Dumazet <edumazet@google.com>
tcp: refine memory limit test in tcp_fragment()
-------------
Diffstat:
Makefile | 4 ++--
net/ipv4/tcp_output.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4.4 1/1] tcp: refine memory limit test in tcp_fragment()
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
@ 2019-06-26 8:45 ` Greg Kroah-Hartman
2019-06-26 17:35 ` [PATCH 4.4 0/1] 4.4.184-stable review Guenter Roeck
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-26 8:45 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Eric Dumazet, Christoph Paasch,
David S. Miller
From: Eric Dumazet <edumazet@google.com>
commit b6653b3629e5b88202be3c9abc44713973f5c4b4 upstream.
tcp_fragment() might be called for skbs in the write queue.
Memory limits might have been exceeded because tcp_sendmsg() only
checks limits at full skb (64KB) boundaries.
Therefore, we need to make sure tcp_fragment() wont punish applications
that might have setup very low SO_SNDBUF values.
Fixes: f070ef2ac667 ("tcp: tcp_fragment() should apply sane memory limits")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Christoph Paasch <cpaasch@apple.com>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1161,7 +1161,7 @@ int tcp_fragment(struct sock *sk, struct
if (nsize < 0)
nsize = 0;
- if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf)) {
+ if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf + 0x20000)) {
NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPWQUEUETOOBIG);
return -ENOMEM;
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
2019-06-26 8:45 ` [PATCH 4.4 1/1] tcp: refine memory limit test in tcp_fragment() Greg Kroah-Hartman
@ 2019-06-26 17:35 ` Guenter Roeck
2019-06-26 18:41 ` Daniel Díaz
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2019-06-26 17:35 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings,
lkft-triage, stable
On Wed, Jun 26, 2019 at 04:45:04PM +0800, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.184 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> Anything received after that time might be too late.
>
Build results:
total: 170 pass: 170 fail: 0
Qemu test results:
total: 307 pass: 307 fail: 0
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
2019-06-26 8:45 ` [PATCH 4.4 1/1] tcp: refine memory limit test in tcp_fragment() Greg Kroah-Hartman
2019-06-26 17:35 ` [PATCH 4.4 0/1] 4.4.184-stable review Guenter Roeck
@ 2019-06-26 18:41 ` Daniel Díaz
2019-06-26 21:46 ` shuah
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Daniel Díaz @ 2019-06-26 18:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, shuah, patches, ben.hutchings,
lkft-triage, stable
Hello!
On 6/26/19 3:45 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.184 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.4.184-rc1
git repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.4.y
git commit: 5f1824292521531d662f05e2e24275767d18c0c4
git describe: v4.4.183-2-g5f1824292521
Test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-4.4-oe/build/v4.4.183-2-g5f1824292521
No regressions (compared to build v4.4.183)
No fixes (compared to build v4.4.183)
Ran 20117 total tests in the following environments and test suites.
Environments
--------------
- i386
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* build
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* network-basic-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* kvm-unit-tests
* install-android-platform-tools-r2600
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
* prep-tmp-disk
Summary
------------------------------------------------------------------------
kernel: 4.4.184-rc1
git repo: https://git.linaro.org/lkft/arm64-stable-rc.git
git branch: 4.4.184-rc1-hikey-20190626-477
git commit: de92183312a3d85ab8b3516096a61210a4e9f458
git describe: 4.4.184-rc1-hikey-20190626-477
Test details:
https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.184-rc1-hikey-20190626-477
No regressions (compared to build 4.4.184-rc1-hikey-20190624-475)
No fixes (compared to build 4.4.184-rc1-hikey-20190624-475)
Ran 1549 total tests in the following environments and test suites.
Environments
--------------
- hi6220-hikey - arm64
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
Greetings!
Daniel Díaz
daniel.diaz@linaro.org
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
` (2 preceding siblings ...)
2019-06-26 18:41 ` Daniel Díaz
@ 2019-06-26 21:46 ` shuah
2019-06-27 8:36 ` Jon Hunter
2019-06-28 8:26 ` Kelsey
5 siblings, 0 replies; 8+ messages in thread
From: shuah @ 2019-06-26 21:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, patches, ben.hutchings, lkft-triage,
stable, shuah
On 6/26/19 2:45 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.184 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Linux 4.4.184-rc1
>
> Eric Dumazet <edumazet@google.com>
> tcp: refine memory limit test in tcp_fragment()
>
>
> -------------
>
> Diffstat:
>
> Makefile | 4 ++--
> net/ipv4/tcp_output.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>
>
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
` (3 preceding siblings ...)
2019-06-26 21:46 ` shuah
@ 2019-06-27 8:36 ` Jon Hunter
2019-06-27 16:54 ` Greg Kroah-Hartman
2019-06-28 8:26 ` Kelsey
5 siblings, 1 reply; 8+ messages in thread
From: Jon Hunter @ 2019-06-27 8:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: torvalds, akpm, linux, shuah, patches, ben.hutchings,
lkft-triage, stable, linux-tegra
On 26/06/2019 09:45, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.184 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests are passing for Tegra ...
Test results for stable-v4.4:
6 builds: 6 pass, 0 fail
12 boots: 12 pass, 0 fail
19 tests: 19 pass, 0 fail
Linux version: 4.4.184-rc1-g5f1824292521
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra30-cardhu-a04
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-27 8:36 ` Jon Hunter
@ 2019-06-27 16:54 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-27 16:54 UTC (permalink / raw)
To: Jon Hunter
Cc: linux-kernel, torvalds, akpm, linux, shuah, patches,
ben.hutchings, lkft-triage, stable, linux-tegra
On Thu, Jun 27, 2019 at 09:36:55AM +0100, Jon Hunter wrote:
>
> On 26/06/2019 09:45, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.4.184 release.
> > There are 1 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> All tests are passing for Tegra ...
>
> Test results for stable-v4.4:
> 6 builds: 6 pass, 0 fail
> 12 boots: 12 pass, 0 fail
> 19 tests: 19 pass, 0 fail
>
> Linux version: 4.4.184-rc1-g5f1824292521
> Boards tested: tegra124-jetson-tk1, tegra20-ventana,
> tegra30-cardhu-a04
>
Thanks for testing all of these and letting me know.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.4 0/1] 4.4.184-stable review
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
` (4 preceding siblings ...)
2019-06-27 8:36 ` Jon Hunter
@ 2019-06-28 8:26 ` Kelsey
5 siblings, 0 replies; 8+ messages in thread
From: Kelsey @ 2019-06-28 8:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, linux, shuah, patches,
ben.hutchings, lkft-triage, stable
Compiled, booted, and no dmesg regressions on my system.
Cheers,
Kelsey
> On Jun 26, 2019, at 2:45 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.4.184 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri 28 Jun 2019 08:35:42 AM UTC.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.184-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Linux 4.4.184-rc1
>
> Eric Dumazet <edumazet@google.com>
> tcp: refine memory limit test in tcp_fragment()
>
>
> -------------
>
> Diffstat:
>
> Makefile | 4 ++--
> net/ipv4/tcp_output.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-28 8:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26 8:45 [PATCH 4.4 0/1] 4.4.184-stable review Greg Kroah-Hartman
2019-06-26 8:45 ` [PATCH 4.4 1/1] tcp: refine memory limit test in tcp_fragment() Greg Kroah-Hartman
2019-06-26 17:35 ` [PATCH 4.4 0/1] 4.4.184-stable review Guenter Roeck
2019-06-26 18:41 ` Daniel Díaz
2019-06-26 21:46 ` shuah
2019-06-27 8:36 ` Jon Hunter
2019-06-27 16:54 ` Greg Kroah-Hartman
2019-06-28 8:26 ` Kelsey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).