* [GIT PULL] smp/urgent fixes
@ 2019-06-29 19:45 Ingo Molnar
2019-06-29 19:59 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Ingo Molnar @ 2019-06-29 19:45 UTC (permalink / raw)
To: Linus Torvalds
Cc: linux-kernel, Thomas Gleixner, Peter Zijlstra, Borislav Petkov,
Andrew Morton
Linus,
Please pull the latest smp-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus
# HEAD: 33d4a5a7a5b4d02915d765064b2319e90a11cbde cpu/hotplug: Fix out-of-bounds read when setting fail state
Two fixes:
- Fix an out of bounds access when writing nonsensical values to
/sys/devices/system/cpu/cpuX/hotplug/fail
- Warn about unsupported mitigations= parameters.
Thanks,
Ingo
------------------>
Eiichi Tsukata (1):
cpu/hotplug: Fix out-of-bounds read when setting fail state
Geert Uytterhoeven (1):
cpu/speculation: Warn on unsupported mitigations= parameter
kernel/cpu.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 077fde6fb953..ef1c565edc5d 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1964,6 +1964,9 @@ static ssize_t write_cpuhp_fail(struct device *dev,
if (ret)
return ret;
+ if (fail < CPUHP_OFFLINE || fail > CPUHP_ONLINE)
+ return -EINVAL;
+
/*
* Cannot fail STARTING/DYING callbacks.
*/
@@ -2339,6 +2342,9 @@ static int __init mitigations_parse_cmdline(char *arg)
cpu_mitigations = CPU_MITIGATIONS_AUTO;
else if (!strcmp(arg, "auto,nosmt"))
cpu_mitigations = CPU_MITIGATIONS_AUTO_NOSMT;
+ else
+ pr_crit("Unsupported mitigations=%s, system may still be vulnerable\n",
+ arg);
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [GIT PULL] smp/urgent fixes
2019-06-29 19:45 [GIT PULL] smp/urgent fixes Ingo Molnar
@ 2019-06-29 19:59 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2019-06-29 19:59 UTC (permalink / raw)
To: Linus Torvalds
Cc: linux-kernel, Thomas Gleixner, Peter Zijlstra, Borislav Petkov,
Andrew Morton
* Ingo Molnar <mingo@kernel.org> wrote:
> Linus,
>
> Please pull the latest smp-urgent-for-linus git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus
>
> # HEAD: 33d4a5a7a5b4d02915d765064b2319e90a11cbde cpu/hotplug: Fix out-of-bounds read when setting fail state
>
> Two fixes:
>
> - Fix an out of bounds access when writing nonsensical values to
> /sys/devices/system/cpu/cpuX/hotplug/fail
>
> - Warn about unsupported mitigations= parameters.
Linus, please ignore this duplicate pull request. I thought Thomas didn't
send this one yet, but he has a few hours ago but the Cc: to me was buggy
so I didn't notice it at first. :-/
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-29 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-29 19:45 [GIT PULL] smp/urgent fixes Ingo Molnar
2019-06-29 19:59 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).