linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ethernet: broadcom: bcm63xx_enet: Remove unneeded memset
@ 2019-06-30 14:29 Hariprasad Kelam
  2019-07-02  2:29 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-06-30 14:29 UTC (permalink / raw)
  To: David S. Miller, Florian Fainelli, bcm-kernel-feedback-list,
	Andrew Lunn, Greg Kroah-Hartman, Hariprasad Kelam, YueHaibing,
	Thomas Gleixner, Luis Chamberlain, netdev, linux-arm-kernel,
	linux-kernel

Remove unneeded memset as alloc_etherdev is using kvzalloc which uses
__GFP_ZERO flag

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 85e6102..f2dd74c 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2659,8 +2659,7 @@ static int bcm_enetsw_probe(struct platform_device *pdev)
 	if (!dev)
 		return -ENOMEM;
 	priv = netdev_priv(dev);
-	memset(priv, 0, sizeof(*priv));
-
+
 	/* initialize default and fetch platform data */
 	priv->enet_is_sw = true;
 	priv->irq_rx = irq_rx;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ethernet: broadcom: bcm63xx_enet: Remove unneeded memset
  2019-06-30 14:29 [PATCH] net: ethernet: broadcom: bcm63xx_enet: Remove unneeded memset Hariprasad Kelam
@ 2019-07-02  2:29 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-02  2:29 UTC (permalink / raw)
  To: hariprasad.kelam
  Cc: f.fainelli, bcm-kernel-feedback-list, andrew, gregkh, yuehaibing,
	tglx, mcgrof, netdev, linux-arm-kernel, linux-kernel

From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Date: Sun, 30 Jun 2019 19:59:49 +0530

> Remove unneeded memset as alloc_etherdev is using kvzalloc which uses
> __GFP_ZERO flag
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-02  2:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-30 14:29 [PATCH] net: ethernet: broadcom: bcm63xx_enet: Remove unneeded memset Hariprasad Kelam
2019-07-02  2:29 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).