linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: syzbot <syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com>,
	anna.schumaker@netapp.com, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	trond.myklebust@hammerspace.com
Subject: Re: memory leak in nfs_get_client
Date: Mon, 1 Jul 2019 23:31:40 -0700	[thread overview]
Message-ID: <20190702063140.GE3054@sol.localdomain> (raw)
In-Reply-To: <223AB0C9-D93E-4D3C-BBBB-4AF40D8EA436@redhat.com>

On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote:
> Ugh.. Now that you can cancel the wait, you have to also handle if "new" was
> allocated.  I think this needs:
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index d7e4f0848e28..4d90f5bf0b0a 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -406,10 +406,10 @@ struct nfs_client *nfs_get_client(const struct
> nfs_client_initdata *cl_init)
>                 clp = nfs_match_client(cl_init);
>                 if (clp) {
>                         spin_unlock(&nn->nfs_client_lock);
> -                       if (IS_ERR(clp))
> -                               return clp;
>                         if (new)
>                                 new->rpc_ops->free_client(new);
> +                       if (IS_ERR(clp))
> +                               return clp;
>                         return nfs_found_client(cl_init, clp);
>                 }
>                 if (new) {
> 
> I'll patch/test and send it along.
> 
> Ben

Hi Ben, what happened to this patch?

- Eric

  reply	other threads:[~2019-07-02  6:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11  4:05 memory leak in nfs_get_client syzbot
2019-06-11 16:23 ` Benjamin Coddington
2019-07-02  6:31   ` Eric Biggers [this message]
2019-07-02 11:23     ` Benjamin Coddington
2019-07-02 16:11       ` Eric Biggers
2019-07-02 18:29         ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702063140.GE3054@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=anna.schumaker@netapp.com \
    --cc=bcodding@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).