From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Eric Biggers" <ebiggers@kernel.org>
Cc: syzbot <syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com>,
anna.schumaker@netapp.com, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, syzkaller-bugs@googlegroups.com,
trond.myklebust@hammerspace.com
Subject: Re: memory leak in nfs_get_client
Date: Tue, 02 Jul 2019 14:29:48 -0400 [thread overview]
Message-ID: <83F17B36-F557-45CD-B59B-30335D33E49B@redhat.com> (raw)
In-Reply-To: <20190702161110.GD895@sol.localdomain>
On 2 Jul 2019, at 12:11, Eric Biggers wrote:
> On Tue, Jul 02, 2019 at 07:23:32AM -0400, Benjamin Coddington wrote:
>> On 2 Jul 2019, at 2:31, Eric Biggers wrote:
>>
>>> On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote:
>>>> Ugh.. Now that you can cancel the wait, you have to also handle if
>>>> "new" was
>>>> allocated. I think this needs:
>>>>
>>>> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
>>>> index d7e4f0848e28..4d90f5bf0b0a 100644
>>>> --- a/fs/nfs/client.c
>>>> +++ b/fs/nfs/client.c
>>>> @@ -406,10 +406,10 @@ struct nfs_client *nfs_get_client(const
>>>> struct
>>>> nfs_client_initdata *cl_init)
>>>> clp = nfs_match_client(cl_init);
>>>> if (clp) {
>>>> spin_unlock(&nn->nfs_client_lock);
>>>> - if (IS_ERR(clp))
>>>> - return clp;
>>>> if (new)
>>>> new->rpc_ops->free_client(new);
>>>> + if (IS_ERR(clp))
>>>> + return clp;
>>>> return nfs_found_client(cl_init, clp);
>>>> }
>>>> if (new) {
>>>>
>>>> I'll patch/test and send it along.
>>>>
>>>> Ben
>>>
>>> Hi Ben, what happened to this patch?
>>
>> I sent it along:
>>
>> https://lore.kernel.org/linux-nfs/65b675cec79d140df64bc30def88b1def32bf87e.1560272160.git.bcodding@redhat.com/
>>
>> I don't think it will go in 5.2.. it's not a huge problem.
>>
>> Ben
>
> Okay, great. I didn't see it in linux-next and there was no further
> reply to
> this thread, which usually (having seen it happen on lots of syzbot
> bugs) means
> the person forgot about it.
>
> Tip: you can use the '--in-reply-to=<MESSAGE_ID>' option to 'git
> send-email' or
> 'git format-patch' to send the patch in response to the original
> thread, which
> makes it very easy to see that a patch was actually sent out.
Yep, that's nice for those following along, but sometimes I think that
makes
it harder for the maintainers to scrape the patches off the list. I've
had
patches get dropped that were buried at the end of a long discussion, so
I've made a habit of always making patches the top.
Ben
prev parent reply other threads:[~2019-07-02 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 4:05 memory leak in nfs_get_client syzbot
2019-06-11 16:23 ` Benjamin Coddington
2019-07-02 6:31 ` Eric Biggers
2019-07-02 11:23 ` Benjamin Coddington
2019-07-02 16:11 ` Eric Biggers
2019-07-02 18:29 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83F17B36-F557-45CD-B59B-30335D33E49B@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).