linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade
Date: Tue, 2 Jul 2019 20:09:19 -0300	[thread overview]
Message-ID: <20190702230919.GB19791@continental> (raw)
In-Reply-To: <yq14l4kro9l.fsf@oracle.com>

On Thu, Jun 20, 2019 at 04:32:38PM -0400, Martin K. Petersen wrote:
> 
> Marcos,
> 
> > My first idea was to add a vendor:product mapping at SCSI layer, but
> > so far I haven't found one, so I added the model/vendor found by
> > INQUIRY. Would it be better to check for prod:vendor (as values,
> > instead of the description)?
> 
> Your patch is functionally fine. I'm just trying to establish how risky
> it is for me to pick it up.

I've tried to find any official document about Cruzer Blade devices, stating
that all of them have at least SPC-3 to support VPD, but no luck so far :(

So feel free to ignore the patch if you think it's too risky.

Thanks,
Marcos

> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-07-03  0:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  1:31 [PATCH 0/2] Honor VPD check in usb/storage for SanDisk device Marcos Paulo de Souza
2019-06-18  1:31 ` [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade Marcos Paulo de Souza
2019-06-19  3:21   ` Martin K. Petersen
2019-06-19  9:45     ` Marcos Paulo de Souza
2019-06-19 12:03       ` Marcos Paulo de Souza
2019-06-20 20:32         ` Martin K. Petersen
2019-07-02 23:09           ` Marcos Paulo de Souza [this message]
2019-06-20 20:31       ` Martin K. Petersen
2019-07-12  0:41   ` Martin K. Petersen
2019-06-18  1:31 ` [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set Marcos Paulo de Souza
2019-06-18  6:49   ` Greg Kroah-Hartman
2019-06-18 10:30     ` Marcos Paulo de Souza
2019-06-18 10:52       ` Greg Kroah-Hartman
2019-06-18 10:56         ` Marcos Paulo de Souza
2019-06-18 13:48   ` Alan Stern
2019-06-18 15:17     ` Marcos Paulo de Souza
2019-06-18 16:07       ` Greg Kroah-Hartman
2019-06-18 22:46         ` Marcos Paulo de Souza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702230919.GB19791@continental \
    --to=marcos.souza.org@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).