From: Alan Stern <stern@rowland.harvard.edu>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB MASS STORAGE DRIVER" <linux-usb@vger.kernel.org>,
"open list:USB MASS STORAGE DRIVER"
<usb-storage@lists.one-eyed-alien.net>
Subject: Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set
Date: Tue, 18 Jun 2019 09:48:01 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1906180946160.1659-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <20190618013146.21961-3-marcos.souza.org@gmail.com>
On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
> If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
> drivers/usb/storage/scsiglue.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> index 59190d88fa9f..0a9520780771 100644
> --- a/drivers/usb/storage/scsiglue.c
> +++ b/drivers/usb/storage/scsiglue.c
> @@ -195,8 +195,11 @@ static int slave_configure(struct scsi_device *sdev)
> */
> sdev->skip_ms_page_8 = 1;
>
> - /* Some devices don't handle VPD pages correctly */
> - sdev->skip_vpd_pages = 1;
> + /*
> + * Some devices don't handle VPD pages correctly, so skip vpd
> + * pages if not forced by SCSI layer.
> + */
> + sdev->skip_vpd_pages = sdev->try_vpd_pages == 0;
>
> /* Do not attempt to use REPORT SUPPORTED OPERATION CODES */
> sdev->no_report_opcodes = 1;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Although I think it would be clearer to write:
sdev->skip_vpd_pages = !sdev->try_vpd_pages;
But that's just personal preference. This is okay as it is.
Alan Stern
next prev parent reply other threads:[~2019-06-18 13:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 1:31 [PATCH 0/2] Honor VPD check in usb/storage for SanDisk device Marcos Paulo de Souza
2019-06-18 1:31 ` [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade Marcos Paulo de Souza
2019-06-19 3:21 ` Martin K. Petersen
2019-06-19 9:45 ` Marcos Paulo de Souza
2019-06-19 12:03 ` Marcos Paulo de Souza
2019-06-20 20:32 ` Martin K. Petersen
2019-07-02 23:09 ` Marcos Paulo de Souza
2019-06-20 20:31 ` Martin K. Petersen
2019-07-12 0:41 ` Martin K. Petersen
2019-06-18 1:31 ` [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set Marcos Paulo de Souza
2019-06-18 6:49 ` Greg Kroah-Hartman
2019-06-18 10:30 ` Marcos Paulo de Souza
2019-06-18 10:52 ` Greg Kroah-Hartman
2019-06-18 10:56 ` Marcos Paulo de Souza
2019-06-18 13:48 ` Alan Stern [this message]
2019-06-18 15:17 ` Marcos Paulo de Souza
2019-06-18 16:07 ` Greg Kroah-Hartman
2019-06-18 22:46 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1906180946160.1659-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).