[PATCH] crypto: cryptd - Fix skcipher instance memory leak

[PATCH] crypto: cryptd - Fix skcipher instance memory leak

[Vincent Whitchurch]

cryptd_skcipher_free() fails to free the struct skcipher_instance
allocated in cryptd_create_skcipher(), leading to a memory leak.  This
is detected by kmemleak on bootup on ARM64 platforms:

 unreferenced object 0xffff80003377b180 (size 1024):
   comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s)
   backtrace:
     kmem_cache_alloc_trace+0x270/0x2d0
     cryptd_create+0x990/0x124c
     cryptomgr_probe+0x5c/0x1e8
     kthread+0x258/0x318
     ret_from_fork+0x10/0x1c

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
 crypto/cryptd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/cryptd.c b/crypto/cryptd.c
index 1ce1bf6d3bab..5f76c6e222c6 100644
--- a/crypto/cryptd.c
+++ b/crypto/cryptd.c
@@ -388,6 +388,7 @@ static void cryptd_skcipher_free(struct skcipher_instance *inst)
 	struct skcipherd_instance_ctx *ctx = skcipher_instance_ctx(inst);
 
 	crypto_drop_skcipher(&ctx->spawn);
+	kfree(inst);
 }
 
 static int cryptd_create_skcipher(struct crypto_template *tmpl,
-- 
2.20.0

Re: [PATCH] crypto: cryptd - Fix skcipher instance memory leak

[Herbert Xu]

Vincent Whitchurch <vincent.whitchurch@axis.com> wrote:
> cryptd_skcipher_free() fails to free the struct skcipher_instance
> allocated in cryptd_create_skcipher(), leading to a memory leak.  This
> is detected by kmemleak on bootup on ARM64 platforms:
> 
> unreferenced object 0xffff80003377b180 (size 1024):
>   comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s)
>   backtrace:
>     kmem_cache_alloc_trace+0x270/0x2d0
>     cryptd_create+0x990/0x124c
>     cryptomgr_probe+0x5c/0x1e8
>     kthread+0x258/0x318
>     ret_from_fork+0x10/0x1c
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
> crypto/cryptd.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt