From: Greg KH <gregkh@linuxfoundation.org>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: jeyentam <je.yen.tam@ni.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices
Date: Wed, 3 Jul 2019 17:59:41 +0200 [thread overview]
Message-ID: <20190703155941.GB19567@kroah.com> (raw)
In-Reply-To: <d6910b29-3ba6-4a3b-04e2-bc7c3c012554@metux.net>
On Wed, Jul 03, 2019 at 05:41:25PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 03.07.19 16:47, Greg KH wrote:
> > On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult wrote:
> >>> /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define NI8430_PORTCON_TXVR_ENABLE (1 << 3)
> >> Can we have that renaming as a separate patch, to ease review ?
> >>
> >> And what about introducing a config sym for the new device specific
> >> stuff ? These devices seem to be pretty rare - never seen them in
> >> embeded world, where we do need to care of kernel size.
> >
> > No, that's not the way this driver works, sorry.
>
> That's sad, because in embedded world we often have to care about
> code size, so making those devices optional would be of great help.
Really? are you sure? Try it and see what you really end up saving.
greg k-h
next prev parent reply other threads:[~2019-07-03 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:24 [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices jeyentam
2019-07-03 8:42 ` Greg KH
2019-07-04 7:55 ` Je Yen Tam
2019-07-04 8:15 ` Greg KH
2019-07-04 8:20 ` Je Yen Tam
2019-07-03 13:27 ` Enrico Weigelt, metux IT consult
2019-07-03 14:47 ` Greg KH
2019-07-03 15:41 ` Enrico Weigelt, metux IT consult
2019-07-03 15:59 ` Greg KH [this message]
2019-07-04 18:17 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703155941.GB19567@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=je.yen.tam@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkml@metux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).