From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jeyentam <je.yen.tam@ni.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices
Date: Thu, 4 Jul 2019 20:17:56 +0200 [thread overview]
Message-ID: <9f08515a-3498-709e-d72b-538a54b704ad@metux.net> (raw)
In-Reply-To: <20190703155941.GB19567@kroah.com>
On 03.07.19 17:59, Greg KH wrote:
>> That's sad, because in embedded world we often have to care about
>> code size, so making those devices optional would be of great help.
>
> Really? are you sure? Try it and see what you really end up saving.
Just in 8250_pci.c alone, I could (depending on actual target) drop
about 80% LoC. Haven't tested how much the difference in image size
will really be.
But if you really like to know and would consider taking some patches
for making those things optional, I'll take some time and do the
dirty work.
By the way: would you still be opposed when these options are masked
behind CONFIG_EXPERT or CONFIG_EMBEDDED ? I can imagine this could be a
good compromise.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-07-04 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:24 [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices jeyentam
2019-07-03 8:42 ` Greg KH
2019-07-04 7:55 ` Je Yen Tam
2019-07-04 8:15 ` Greg KH
2019-07-04 8:20 ` Je Yen Tam
2019-07-03 13:27 ` Enrico Weigelt, metux IT consult
2019-07-03 14:47 ` Greg KH
2019-07-03 15:41 ` Enrico Weigelt, metux IT consult
2019-07-03 15:59 ` Greg KH
2019-07-04 18:17 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f08515a-3498-709e-d72b-538a54b704ad@metux.net \
--to=lkml@metux.net \
--cc=gregkh@linuxfoundation.org \
--cc=je.yen.tam@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).