* [PATCH] btrfs: Fix build error while LIBCRC32C is module
@ 2019-07-02 14:39 YueHaibing
2019-07-04 9:16 ` Johannes Thumshirn
2019-07-04 16:19 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-02 14:39 UTC (permalink / raw)
To: clm, josef, dsterba, jthumshirn; +Cc: linux-kernel, linux-btrfs, YueHaibing
If CONFIG_BTRFS_FS is y and CONFIG_LIBCRC32C is m,
building fails:
fs/btrfs/super.o: In function `btrfs_mount_root':
super.c:(.text+0xb7f9): undefined reference to `crc32c_impl'
fs/btrfs/super.o: In function `init_btrfs_fs':
super.c:(.init.text+0x3465): undefined reference to `crc32c_impl'
fs/btrfs/extent-tree.o: In function `hash_extent_data_ref':
extent-tree.c:(.text+0xe60): undefined reference to `crc32c'
extent-tree.c:(.text+0xe78): undefined reference to `crc32c'
extent-tree.c:(.text+0xe8b): undefined reference to `crc32c'
fs/btrfs/dir-item.o: In function `btrfs_insert_xattr_item':
dir-item.c:(.text+0x291): undefined reference to `crc32c'
fs/btrfs/dir-item.o: In function `btrfs_insert_dir_item':
dir-item.c:(.text+0x429): undefined reference to `crc32c'
Select LIBCRC32C to fix it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/btrfs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 2521a24..df4041d 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -4,6 +4,7 @@ config BTRFS_FS
tristate "Btrfs filesystem support"
select CRYPTO
select CRYPTO_CRC32C
+ select LIBCRC32C
select CRYPTO_SHA256
select ZLIB_INFLATE
select ZLIB_DEFLATE
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Fix build error while LIBCRC32C is module
2019-07-02 14:39 [PATCH] btrfs: Fix build error while LIBCRC32C is module YueHaibing
@ 2019-07-04 9:16 ` Johannes Thumshirn
2019-07-04 16:19 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2019-07-04 9:16 UTC (permalink / raw)
To: YueHaibing; +Cc: clm, josef, dsterba, linux-kernel, linux-btrfs
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Fix build error while LIBCRC32C is module
2019-07-02 14:39 [PATCH] btrfs: Fix build error while LIBCRC32C is module YueHaibing
2019-07-04 9:16 ` Johannes Thumshirn
@ 2019-07-04 16:19 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-07-04 16:19 UTC (permalink / raw)
To: YueHaibing; +Cc: clm, josef, dsterba, jthumshirn, linux-kernel, linux-btrfs
On Tue, Jul 02, 2019 at 10:39:03PM +0800, YueHaibing wrote:
> If CONFIG_BTRFS_FS is y and CONFIG_LIBCRC32C is m,
> building fails:
>
> fs/btrfs/super.o: In function `btrfs_mount_root':
> super.c:(.text+0xb7f9): undefined reference to `crc32c_impl'
> fs/btrfs/super.o: In function `init_btrfs_fs':
> super.c:(.init.text+0x3465): undefined reference to `crc32c_impl'
> fs/btrfs/extent-tree.o: In function `hash_extent_data_ref':
> extent-tree.c:(.text+0xe60): undefined reference to `crc32c'
> extent-tree.c:(.text+0xe78): undefined reference to `crc32c'
> extent-tree.c:(.text+0xe8b): undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_insert_xattr_item':
> dir-item.c:(.text+0x291): undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_insert_dir_item':
> dir-item.c:(.text+0x429): undefined reference to `crc32c'
>
> Select LIBCRC32C to fix it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
Thanks, queued for 5.3. I hoped we could reduce the config dependencies
a bit, oh well.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-04 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02 14:39 [PATCH] btrfs: Fix build error while LIBCRC32C is module YueHaibing
2019-07-04 9:16 ` Johannes Thumshirn
2019-07-04 16:19 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).